Re: [PATCH mptcp-next] Squash to "selftests: mptcp: add splice io mode"

Matthieu Baerts
2026-01-30T18:45:42Z

Hi Geliang,

On 30/01/2026 14:46, Geliang Tang wrote:
> Hi Matt,
>
> Thanks for this fix.
>
> On Fri, 2026-01-30 at 11:17 +0100, Matthieu Baerts (NGI0) wrote:
>> NIPA review assistant rightly spotted errors with splice() are
>> simply...
>> ignored! Technically, mptcp_connect.sh will check the integrity of
>> the
>> transfer, but still, that's clearly not a good practice!
>>
>> The different possible errors are now caught, printed, and reported
>> to
>> the caller.
>>
>> Link:
>> https://netdev-ai.bots.linux.dev/ai-review.html?id=93466fc9-574b-45fc-996e-13a19a1490a9
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> Looks good to me!
>
> Reviewed-by: Geliang Tang <geliang@kernel.org>
>
>> ---
>>  tools/testing/selftests/net/mptcp/mptcp_connect.c | 34
>> +++++++++++++++++------
>>  1 file changed, 25 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c
>> b/tools/testing/selftests/net/mptcp/mptcp_connect.c
>> index ff1a298d3469..34d8efe429a4 100644
>> --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
>> +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
>> @@ -937,24 +937,40 @@ static int do_splice(const int infd, const int
>> outfd, const size_t len,
>>        struct wstate *winfo)
>>  {
>>   int pipefd[2];
>> - ssize_t bytes;
>> + ssize_t in_bytes, out_bytes;
>
> This line is longer than the previous one; their positions could be
> swapped.

Good point, I missed that. I just fixed that when applying the patch.

New patches for t/upstream:
- f09f3f41e540: Squash to "selftests: mptcp: add splice io mode"
- Results: 50e7f60d4f2a..6f5b41319f11 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/e34e5e3567f9b0fc679d6e6778c749684db62186/checks

Cheers,
Matt
--