From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-net 1/3] mptcp: add lookup_addr for userspace pm
Date: Tue, 5 Nov 2024 18:31:10 +0100 [thread overview]
Message-ID: <e939014a-de58-41fd-b9b7-8a39b1530c1c@kernel.org> (raw)
In-Reply-To: <9ef5e8b9d589488850f31cb6dbd1da0f39e21210.1730799589.git.tanggeliang@kylinos.cn>
Hi Geliang,
Thank you for the patches!
On 05/11/2024 10:40, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Like __lookup_addr() helper in pm_netlink.c, a new helper
> mptcp_userspace_pm_lookup_addr() is also defined in pm_userspace.c.
> It looks up the corresponding mptcp_pm_addr_entry address in
> userspace_pm_local_addr_list through the passed "addr" parameter
> and returns it.
>
> This helper can be used in mptcp_userspace_pm_delete_local_addr(),
> mptcp_userspace_pm_get_local_id() and mptcp_userspace_pm_is_backup()
> to simplify the code.
I would prefer to avoid the refactoring for -net if it is not needed:
this will make the next fix harder to backport. Please see my comment on
the next patch.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-11-05 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 9:40 [PATCH mptcp-net 0/3] fixes for userspace pm Geliang Tang
2024-11-05 9:40 ` [PATCH mptcp-net 1/3] mptcp: add lookup_addr " Geliang Tang
2024-11-05 17:31 ` Matthieu Baerts [this message]
2024-11-05 9:40 ` [PATCH mptcp-net 2/3] mptcp: update local address flags when setting it Geliang Tang
2024-11-05 17:31 ` Matthieu Baerts
2024-11-05 9:41 ` [PATCH mptcp-net 3/3] mptcp: hold pm lock when deleting entry Geliang Tang
2024-11-05 11:25 ` [PATCH mptcp-net 0/3] fixes for userspace pm MPTCP CI
2024-11-05 15:40 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e939014a-de58-41fd-b9b7-8a39b1530c1c@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox