MPTCP Linux Development
 help / color / mirror / Atom feed
From: Mat Martineau <mathew.j.martineau at linux.intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH mptcp-net v2] mptcp: fix pending data accounting
Date: Tue, 15 Dec 2020 16:57:01 -0800	[thread overview]
Message-ID: <eb942018-61b7-a0e7-df80-a474ece98266@linux.intel.com> (raw)
In-Reply-To: edd14c0ddd620edf4acb99c0b9ef9012a97e7461.1607959409.git.pabeni@redhat.com

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

On Mon, 14 Dec 2020, Paolo Abeni wrote:

> When sendmsg() needs to wait for memory, the pending data
> is not updated. That causes a drift in forward memory allocation,
> leading to stall and/or warnings at socket close time.
>
> This change addresses the above issue moving the pending data
> counter update inside the sendmsg() main loop.
>
> Fixes: 6e628cd3a8f7 ("mptcp: use mptcp release_cb for delayed tasks")
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> ---
> v1 -> v2:
> - really fix broken accounting
> ---
> net/mptcp/protocol.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>

Thanks Paolo, looks good for the -net tree.

Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

--
Mat Martineau
Intel

                 reply	other threads:[~2020-12-16  0:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb942018-61b7-a0e7-df80-a474ece98266@linux.intel.com \
    --to=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox