From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Geliang Tang <geliang.tang@suse.com>, mptcp@lists.linux.dev
Cc: Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH mptcp-next] mptcp: use nlmsg_free instead of kfree_skb
Date: Fri, 2 Dec 2022 11:20:40 +0100 [thread overview]
Message-ID: <ed2e87b2-932e-b386-e2c6-c1b81ccec7a7@tessares.net> (raw)
In-Reply-To: <20221202053736.2980-1-geliang.tang@suse.com>
Hi Geliang,
On 02/12/2022 06:37, Geliang Tang wrote:
> Use nlmsg_free() instead of kfree_skb() in pm_netlink.c.
Thank you for the quick follow up!
I suggest to add a bit more text to have a clear explanation about why
it is clean-up and not a fix, e.g.
The skb has been created by nlmsg_new(). The proper free should then
be done with nlmsg_free().
For the moment, nlmsg_free() is simply calling kfree_skb() so we
don't change the behaviour here.
I can modify the commit message when applying the patch, no need to send
a v2 ;-)
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2022-12-02 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 5:37 [PATCH mptcp-next] mptcp: use nlmsg_free instead of kfree_skb Geliang Tang
2022-12-02 6:43 ` mptcp: use nlmsg_free instead of kfree_skb: Tests Results MPTCP CI
2022-12-02 10:20 ` Matthieu Baerts [this message]
2022-12-02 11:12 ` [PATCH mptcp-next] mptcp: use nlmsg_free instead of kfree_skb Matthieu Baerts
2022-12-02 11:54 ` mptcp: use nlmsg_free instead of kfree_skb: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed2e87b2-932e-b386-e2c6-c1b81ccec7a7@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=geliang.tang@suse.com \
--cc=kuba@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox