From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v7 07/11] mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible
Date: Mon, 6 Jan 2025 10:04:33 +0100 [thread overview]
Message-ID: <ef4e0d23-4852-452c-85d0-ba2eff5d0d60@kernel.org> (raw)
In-Reply-To: <4ab3a73300cdc4e2f222127e53ca66a696d3e6e6.1736150983.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 06/01/2025 09:16, Geliang Tang wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
>
> Instead of only returning a text message with GENL_SET_ERR_MSG(),
> NL_SET_ERR_MSG_ATTR() can help the userspace developers by also
> reporting which attribute is faulty.
>
> When the error is specific to an attribute, NL_SET_ERR_MSG_ATTR() is now
> used. The error messages have not been modified in this commit.
>
> mptcp_userspace_pm_remove_id_zero_address() has been modified to set the
> missing attribute.
It is no longer the case. Can you remove these 2 lines please?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-01-06 9:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:16 [PATCH mptcp-next v7 00/11] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm Geliang Tang
2025-01-06 8:16 ` [PATCH mptcp-next v7 01/11] mptcp: pm: more precise error messages Geliang Tang
2025-01-06 9:17 ` Matthieu Baerts
2025-01-06 8:16 ` [PATCH mptcp-next v7 02/11] mptcp: userspace pm set_flags id support Geliang Tang
2025-01-06 9:31 ` Matthieu Baerts
2025-01-06 8:16 ` [PATCH mptcp-next v7 03/11] mptcp: drop skb parameter of set_flags Geliang Tang
2025-01-06 8:16 ` [PATCH mptcp-next v7 04/11] mptcp: change rem type " Geliang Tang
2025-01-06 8:16 ` [PATCH mptcp-next v7 05/11] mptcp: add local & remote parameters for set_flags Geliang Tang
2025-01-06 9:39 ` Matthieu Baerts
2025-01-06 10:01 ` Matthieu Baerts
2025-01-06 8:16 ` [PATCH mptcp-next v7 06/11] mptcp: drop info of userspace_pm_remove_id_zero_address Geliang Tang
2025-01-06 9:48 ` Matthieu Baerts
2025-01-06 8:16 ` [PATCH mptcp-next v7 07/11] mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible Geliang Tang
2025-01-06 9:04 ` Matthieu Baerts [this message]
2025-01-06 8:16 ` [PATCH mptcp-next v7 08/11] mptcp: pm: improve error messages Geliang Tang
2025-01-06 9:55 ` Matthieu Baerts
2025-01-06 8:16 ` [PATCH mptcp-next v7 09/11] mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK Geliang Tang
2025-01-06 8:16 ` [PATCH mptcp-next v7 10/11] mptcp: pm: remove duplicated error messages Geliang Tang
2025-01-06 8:16 ` [PATCH mptcp-next v7 11/11] mptcp: pm: mark missing address attributes Geliang Tang
2025-01-06 9:20 ` [PATCH mptcp-next v7 00/11] mptcp: use GENL_REQ_ATTR_CHECK in userspace pm MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef4e0d23-4852-452c-85d0-ba2eff5d0d60@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox