From: Paolo Abeni <pabeni@redhat.com>
To: Mat Martineau <martineau@kernel.org>
Cc: mptcp@lists.linux.dev, Geliang Tang <geliang@kernel.org>
Subject: Re: [PATCH v6 mptcp-next 05/11] mptcp: fix MSG_PEEK stream corruption
Date: Fri, 24 Oct 2025 09:34:27 +0200 [thread overview]
Message-ID: <f101b253-9116-42bf-98c8-4e7a958bce50@redhat.com> (raw)
In-Reply-To: <9a415164-74cb-3650-9299-edc82652b086@kernel.org>
On 10/23/25 6:56 PM, Mat Martineau wrote:
> On Wed, 22 Oct 2025, Paolo Abeni wrote:
>
>> If a MSG_PEEK | MSG_WAITALL read operation consumes all the bytes in the
>> receive queue and recvmsg() need to waits for more data - i.e. it's a
>> blocking one - upon arrival of the next packet the MPTCP protocol will
>> start again copying the oldest data present in the receive queue,
>> corrupting the data stream.
>>
>> Address the issue explicitly tracking the peeked sequence number,
>> restarting from the last peeked byte.
>>
>> Fixes: ca4fb892579f ("mptcp: add MSG_PEEK support")
>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>> ---
>> This may sound quite esoteric, but it will soon become very easy to
>> reproduce with mptcp_connect, thanks to the backlog.
>
> Would it be good to apply this to -net?
FWIW, I'm fine with applying this to -net.
Thanks,
Paolo
next prev parent reply other threads:[~2025-10-24 7:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 14:31 [PATCH v6 mptcp-next 00/11] mptcp: introduce backlog processing Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 01/11] mptcp: drop bogus optimization in __mptcp_check_push() Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 02/11] mptcp: borrow forward memory from subflow Paolo Abeni
2025-10-23 6:38 ` Geliang Tang
2025-10-22 14:31 ` [PATCH v6 mptcp-next 03/11] mptcp: cleanup fallback data fin reception Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 04/11] mptcp: cleanup fallback dummy mapping generation Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 05/11] mptcp: fix MSG_PEEK stream corruption Paolo Abeni
2025-10-23 16:56 ` Mat Martineau
2025-10-24 7:34 ` Paolo Abeni [this message]
2025-10-22 14:31 ` [PATCH v6 mptcp-next 06/11] mptcp: ensure the kernel PM does not take action too late Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 07/11] mptcp: do not miss early first subflow close event notification Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 08/11] mptcp: make mptcp_destroy_common() static Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 09/11] mptcp: drop the __mptcp_data_ready() helper Paolo Abeni
2025-10-23 6:38 ` Geliang Tang
2025-10-22 14:31 ` [PATCH v6 mptcp-next 10/11] mptcp: introduce mptcp-level backlog Paolo Abeni
2025-10-22 14:31 ` [PATCH v6 mptcp-next 11/11] mptcp: leverage the backlog for RX packet processing Paolo Abeni
2025-10-23 15:11 ` Paolo Abeni
2025-10-23 15:52 ` Matthieu Baerts
2025-10-23 17:02 ` Mat Martineau
2025-10-23 17:43 ` Matthieu Baerts
2025-10-22 15:50 ` [PATCH v6 mptcp-next 00/11] mptcp: introduce backlog processing MPTCP CI
2025-10-23 6:37 ` Geliang Tang
2025-10-27 12:17 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f101b253-9116-42bf-98c8-4e7a958bce50@redhat.com \
--to=pabeni@redhat.com \
--cc=geliang@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox