Re: [PATCH mptcp-next v3 0/5] mptcp_join userspace pm tests

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Thu, 16 Jun 2022, Geliang Tang wrote:

> This patch set adds add address, remove address, create subflow, and
> destroy subflow test cases for userspace pm in mptcp_join script.
>
> v3:
> - use MPTCP_INC_STATS instead of __MPTCP_INC_STATS.
> - drop unneeded pm_nl_set_limits.

Thanks Geliang.

Series looks good, with a squash-to request (see patch 3 comment):

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

>
> v2:
> - add more tests in mptcp_join.sh
> - patch 4, add kill_wait helper as Matt suggested.
>
> Geliang Tang (5):
>  mptcp: update MIB_RMSUBFLOW in cmd_sf_destroy
>  selftests: mptcp: userspace pm address tests
>  selftests: mptcp: userspace pm subflow tests
>  selftests: mptcp: avoid Terminated messages in userspace_pm
>  selftests: mptcp: update pm_nl_ctl usage header
>
> net/mptcp/pm_userspace.c                      |  2 +
> .../testing/selftests/net/mptcp/mptcp_join.sh | 82 ++++++++++++++++++-
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  2 +-
> .../selftests/net/mptcp/userspace_pm.sh       | 40 +++++----
> 4 files changed, 106 insertions(+), 20 deletions(-)
>
> -- 
> 2.35.3
>
>
>

--
Mat Martineau
Intel