Re: [PATCH mptcp-next v2] mptcp: increment RmAddr MIB counter once per RM_ADDR

[Matthieu Baerts <matttbe@kernel.org>]

Hello,

On 27/05/2024 18:03, Matthieu Baerts (NGI0) wrote:
> From: YonglongLi <liyonglong@chinatelecom.cn>
> 
> The RmAddr MIB counter is supposed to be incremented once when a valid
> RM_ADDR has been received. Before this patch, it could have been
> incremented as many times as the number of subflows connected to the
> linked address ID, so it could have been 0, 1 or more than 1.
> 
> The "RmSubflow" is incremented after a local operation. In this case,
> it is normal to tied it with the number of subflows that have been
> actually removed.
> 
> The "remove invalid addresses" MP Join subtest has been modified to
> validate this case. A broadcast IP address is now used instead: the
> client will not be able to create a subflow to this address. The
> consequence is that when receiving the RM_ADDR with the ID attached to
> this broadcast IP address, no subflow linked to this ID will be found.

Now in our tree (fixes for -net):

New patches for t/upstream-net and t/upstream:
- 9c592aa6f604: mptcp: increment RmAddr MIB counter once per RM_ADDR
- Results: bbdf7fd48eef..e85c0954b4e4 (export-net)
- Results: 05497250894c..5e8a75a149b7 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/0cd8eb1e3be7cc7691835ad2b30d34a122253081/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/37ac616090e02d163a41ceefbc28d3ff41afe470/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.