Re: [PATCH mptcp-next v4 5/7] selftests: mptcp: add mptcp_lib_make_file

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 13/10/2023 09:44, Geliang Tang wrote:
> To avoid duplicated code in different MPTCP selftests, we can add
> and use helpers defined in mptcp_lib.sh.
> 
> make_file() helper in mptcp_sockopt.sh and userspace_pm.sh are the same.
> Export it into mptcp_lib.sh and rename it as mptcp_lib_kill_wait(). Use
> it in both mptcp_connect.sh and mptcp_join.sh.

Thank you for the new verison!

> diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
> index bfa744e350ef..755ae0f5ac4b 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
> @@ -251,8 +251,7 @@ make_file()
>  	local who=$2
>  	local size=$3
>  
> -	dd if=/dev/urandom of="$name" bs=1024 count=$size 2> /dev/null
> -	echo -e "\nMPTCP_TEST_FILE_END_MARKER" >> "$name"
> +	mptcp_lib_make_file $name $bs $size

Here, '$bs' is not declared, I guess you should use '1024' instead.

I can fix that when applying the patch if there is nothing else.

Cheers,
Matt