From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v1 1/6] mptcp: pm: in-kernel: avoid access entry without lock
Date: Mon, 24 Feb 2025 09:31:26 +0100 [thread overview]
Message-ID: <fe83ef4a-ba6c-4704-8d44-ad14b4e65622@kernel.org> (raw)
In-Reply-To: <1ccd8b5eee126272e4841635d69616ca79977ad8.1740384564.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 24/02/2025 09:13, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> In mptcp_pm_nl_set_flags(), "entry" is copied to "local" when pernet->lock
> is held to avoid direct access to entry without pernet->lock.
>
> Therefore, "local->flags" should be passed to mptcp_nl_set_flags instead
> of "entry->flags" when pernet->lock is not held, so as to avoid access to
> entry.
Good catch! I see that this is a fix for a patch that has been sent to
net-next, but not applied yet.
Fixes: TODO ("mptcp: pm: change to fullmesh only for 'subflow'")
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-02-24 8:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 8:13 [PATCH mptcp-next v1 0/6] BPF path manager, part 4 Geliang Tang
2025-02-24 8:13 ` [PATCH mptcp-next v1 1/6] mptcp: pm: in-kernel: avoid access entry without lock Geliang Tang
2025-02-24 8:31 ` Matthieu Baerts [this message]
2025-02-24 11:02 ` Matthieu Baerts
2025-02-24 8:13 ` [PATCH mptcp-next v1 2/6] mptcp: pm: in-kernel: reduce parameters of set_flags Geliang Tang
2025-02-24 8:13 ` [PATCH mptcp-next v1 3/6] mptcp: pm: use addr entry for get_local_id Geliang Tang
2025-02-24 8:13 ` [PATCH mptcp-next v1 4/6] mptcp: pm: in-kernel: use kmemdup helper Geliang Tang
2025-02-24 8:13 ` [PATCH mptcp-next v1 5/6] sock: add sock_kmemdup helper Geliang Tang
2025-02-24 8:54 ` Matthieu Baerts
2025-02-24 10:42 ` Geliang Tang
2025-02-24 10:59 ` Matthieu Baerts
2025-02-24 8:13 ` [PATCH mptcp-next v1 6/6] mptcp: pm: userspace: use " Geliang Tang
2025-02-24 9:22 ` [PATCH mptcp-next v1 0/6] BPF path manager, part 4 MPTCP CI
2025-02-24 11:05 ` Matthieu Baerts
2025-02-26 16:29 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe83ef4a-ba6c-4704-8d44-ad14b4e65622@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox