MPTCP Linux Development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH net 2/7] mptcp: push pending data after a sendmsg copy fault
Date: Tue, 17 Nov 2026 22:09:15 +0000	[thread overview]
Message-ID: <sashiko-outbox-219728@kernel.org> (raw)
In-Reply-To: <20261116-net-mptcp-misc-fixes-7-4-rc4-v1-2-bf7656de653e@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mptcp: Fixes trailer in commit message cites 69800e516e96
  instead of d9ca1de8c0cd
--

commit 54f71c9aefbcf7d32b7ddbd0cfb6524d738c4d31
Author: Quanye Yang <quanyeyang@proton.me>

> mptcp: push pending data after a sendmsg copy fault
>
> mptcp_sendmsg() copies into the msk write queue first, then
> __mptcp_push_pending() on the success path. tcp_sendmsg_locked()
> does the opposite: its do_error path jumps to out, and out
> calls tcp_push() when copied > 0.
>
> A later iovec fault (copy_from_iter / -EFAULT) after a successful
> iteration therefore returns the partial byte count but leaves the
> already-queued dfrag on rtx_queue. No subflow packet is sent, no
> retransmission timer is armed, and DATA_FIN stays blocked on
> first_pending.
>
> Push in do_error when copied is already non-zero. Do not move
> the push to out: copied is a size_t, and sk_stream_error()
> stores a negative errno there.
>
> The issue was spot by Sashiko, but easy to reproduce with Packetdrill:
>
>   writev(4, [{..., 32728}, {NULL, 4096}], 2) = 32728
>
> Fixes: 69800e516e96 ("mptcp: propagate fastclose error")
> Cc: stable@vger.kernel.org
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/640
> Signed-off-by: Quanye Yang <quanyeyang@proton.me>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

[Severity: Low]
Should the Fixes: tag point to d9ca1de8c0cd ("mptcp: move page frag
allocation in mptcp_sendmsg()") instead?

Before 69800e516e96 ("mptcp: propagate fastclose error"), a copy_page_from_iter()
failure in mptcp_sendmsg() already jumped directly to out:, bypassing
__mptcp_push_pending() and returning the partial byte count when copied > 0.
Commit d9ca1de8c0cd ("mptcp: move page frag allocation in mptcp_sendmsg()")
introduced the loop that queues data into msk->rtx_queue first and pushes
only after the loop, while jumping past mptcp_push_pending() to out: on a
copy fault.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-net-mptcp-misc-fixes-7-4-rc4-v1-0-bf7656de653e@kernel.org?part=2

  reply	other threads:[~2026-11-17 22:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:06 [PATCH net 0/7] mptcp: misc fixes for v7.4-rc4 Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 1/7] mptcp: do not use a raised snd_wnd for the send window Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 2/7] mptcp: push pending data after a sendmsg copy fault Matthieu Baerts (NGI0)
2026-11-17 22:09   ` sashiko-bot [this message]
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:01     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 3/7] mptcp: use sk instead of casting msk in check_fully_established() Matthieu Baerts (NGI0)
2026-11-16 22:06 ` [PATCH net 4/7] mptcp: push queued data on passive TFO subflows becoming established Matthieu Baerts (NGI0)
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:02     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 5/7] mptcp: push queued data on subflows falling back at the handshake Matthieu Baerts (NGI0)
2026-11-17 22:09   ` sashiko-bot
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:02     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 6/7] mptcp: don't send a FIN before the pending data on fallback Matthieu Baerts (NGI0)
2026-11-17 22:09   ` sashiko-bot
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:03     ` Matthieu Baerts
2026-11-16 22:06 ` [PATCH net 7/7] mptcp: fix dummy mapping of overlapping segments Matthieu Baerts (NGI0)
2026-11-17 22:29   ` netdev-bot+sashiko
2026-11-18 22:04     ` Matthieu Baerts
2026-11-18 22:05 ` [PATCH net 0/7] mptcp: misc fixes for v7.4-rc4 Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219728@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox