From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0F72253F2 for ; Sun, 19 Oct 2025 06:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760854626; cv=none; b=Jz1quF6aAT5J8pkvT40lDMvOjr7amk5AZRB5hoEEHTUAXUomWjNh8IQzG6Q4T2AnjnL0AdWwisj2UDG/Xv+5k1csYvW37mUmp4IXk/AC1JhFHprf9xkWV3Gx1aJdUMBAPZZZd+juedrwt/PpcCVVfjnPuqjJiIEN7l5k4+lwCxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760854626; c=relaxed/simple; bh=63R7gEzXBdYWCrB40yN9xIT54GZs9xo6d7YiOcC4r1M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ODmdhJIjRbVsyQSf8bZaLg89VS7G/vX10LyZRg/E8mrTr5BaKTCuHn6Wrnp7+5MjlznQt1yCdrZaunuAkIEH7WBczWDoS8sq+qpiYA/ceIitLN0h+7pO3TK12XACD/3pAXjDC/PiCerHSuBLtp7+xtwcrmZpSAUyd7urB2/UY8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iAK7DG+7; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAK7DG+7" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-794e300e20dso3556286b3a.1 for ; Sat, 18 Oct 2025 23:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760854624; x=1761459424; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dLqqJGV/L+ji7bkggNzrd9CKo82o255TTwQERVGyCig=; b=iAK7DG+7yWISmoBZ0fYBeGb6aAei5nqiKTRCu1K+QdzxV0HYsXJB2I+BQhZ4mWZiqI NldQ1WMHCbX4P5TaXTW4JWH85An//qBdsaAbOnl3OK+2UyIma6E5OvnyDUQC5JTVOfdx 8AagTv4/Wy0T8FF19SeeuaYa7rmHU4E3tnTLNEgLtmvWE2qlcWsbFh0ido5ZhaMghCZs YTM7oPaL1BYQP2Uf/z4QuZf2+Q/rRVFjod7p2ypmVEfzaw85lMQQSlFsHrOdjLsXw3jX tWJXaKOCYyZZc1x8XiiHO6nGePmsi8HC7Gy+akKM0IwM+r3rA4NxvBQrUcYFgZQWVnRK 4O2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760854624; x=1761459424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dLqqJGV/L+ji7bkggNzrd9CKo82o255TTwQERVGyCig=; b=mgwvMT8z6utDgX82Z2jmer04OohNO53uuaEZlG8ufieTCj3MNi1fYoE+eUmYhHw/4j O9phy/GMOkbq13gOeOUT7+8qPXpKWVxWDpc+21kI1vEUzDF/Dtsw2NgmbBbEngi01HPE SBO2M9v0x9yAM2qNp+La7DhS/aScfjoVSyeZBRI4nCtp88GQ0QsAcXOrOxjjckTI18yA UEWHSfOUEJjmJe4kK9ZOWGcUB2DUnIBKFq8Sv3zTBd9RL/qWM/09qbgP4lnQmkemtmQJ mTCOL3GHH4jiNaAVp2uADkyUJ/JB/kM8VVw0l984knVPp5ewlxKRp0bih2WQLKV/icCF duuA== X-Forwarded-Encrypted: i=1; AJvYcCVaNwqYqOse8i9ElFy4NIw9gW610nNjykH6t315I27iqQm/k00QnG5Pw2apFwS7joBFkHustNumJIHpWQ==@lists.linux.dev X-Gm-Message-State: AOJu0YyRqCsFBOl0Nd3cC5aFK4SHqPYMNYCL9EBAOx4F6wMIsNzdDnWF KyQXhSFKzQvtxyIPLa2MUTaCMnxCapjbf+amt6tAALYy2jsPyDksrKZp X-Gm-Gg: ASbGncszMXLFYuWT9UPj0y1k5fFNYYZrR83Onq3YCk5lxhrkhPTdI8tD5KSoxJXT/1/ obHnzNpP09nIDkjP0uNfPWHgX5mj3gFc1l3kzVOjEudef6rXXA9dcK6Loyx08CVAwnArv9sfshl IRga/PjnxrwJvqVy/V4GRRLLilVkXhESt+GyFqlO/g/jTjpZfaRATGzGBSRTcaRevRnJp03rJcE q107Cp8BxirGYutTMfHdiqN1nDjGG/5o16ozxPizGvPW9fQjQxhAlNv9+ZjPe1qBlCmzg5SYR/+ UIvgevScdXyjuBJAU8vkxcHuVknFzcuwpncsQCjSP3SwMiWRDAzmduLtIOFVzA196Uht18eVjZf wKS3lXpx9AGoMqEx3kyyMzVJSq1z4HfohdVTEonmcVk931UU9TPPUdZpTwx96ALCyyTeFCw5qEH ESg/MwV7INYLgZ3Do= X-Google-Smtp-Source: AGHT+IHnfm9cDhxkKo6634pD1Qrn3qveTjwFz5affIoqxA2b6S+MUJtfZj8poS0j4agHQFerUWJNwQ== X-Received: by 2002:a05:6a20:3d84:b0:278:bc13:d83e with SMTP id adf61e73a8af0-334a787d9c2mr12210119637.11.1760854623674; Sat, 18 Oct 2025 23:17:03 -0700 (PDT) Received: from pop-os.. ([2601:647:6881:9060:bc87:d8fe:3e55:7ffb]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6a76b6f302sm4332032a12.38.2025.10.18.23.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 23:17:03 -0700 (PDT) From: Cong Wang To: linux-kernel@vger.kernel.org Cc: jiri@resnulli.us, stefanha@redhat.com, multikernel@lists.linux.dev, pasha.tatashin@soleen.com, Cong Wang , Andrew Morton , Baoquan He , Alexander Graf , Mike Rapoport , Changyuan Lyu , kexec@lists.infradead.org, linux-mm@kvack.org Subject: [RFC Patch v2 07/16] kexec: Implement dynamic kimage tracking Date: Sat, 18 Oct 2025 23:16:21 -0700 Message-Id: <20251019061631.2235405-8-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251019061631.2235405-1-xiyou.wangcong@gmail.com> References: <20251019061631.2235405-1-xiyou.wangcong@gmail.com> Precedence: bulk X-Mailing-List: multikernel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Cong Wang Replace static kexec_image and kexec_crash_image globals with a dynamic linked list infrastructure to support multiple kernel images. This change enables multikernel functionality while maintaining backward compatibility. Key changes: - Add list_head member to kimage structure for chaining - Implement thread-safe linked list management with global mutex - Update kexec load/unload logic to use list-based APIs for multikernel - Add helper functions for finding and managing multiple kimages - Preserve existing kexec_image/kexec_crash_image pointers for compatibility - Update architecture-specific crash handling to use new APIs The multikernel case now properly uses list-based management instead of overwriting compatibility pointers, allowing multiple multikernel images to coexist in the system. Signed-off-by: Cong Wang --- arch/powerpc/kexec/crash.c | 8 ++-- arch/x86/kernel/crash.c | 4 +- include/linux/kexec.h | 13 ++++++ kernel/kexec.c | 60 ++++++++++++++++++++++++++-- kernel/kexec_core.c | 81 ++++++++++++++++++++++++++++++++++++++ kernel/kexec_file.c | 33 ++++++++++++++-- 6 files changed, 187 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c index a325c1c02f96..af190fad4f22 100644 --- a/arch/powerpc/kexec/crash.c +++ b/arch/powerpc/kexec/crash.c @@ -477,13 +477,13 @@ static void update_crash_elfcorehdr(struct kimage *image, struct memory_notify * ptr = __va(mem); if (ptr) { /* Temporarily invalidate the crash image while it is replaced */ - xchg(&kexec_crash_image, NULL); + kimage_update_compat_pointers(NULL, KEXEC_TYPE_CRASH); /* Replace the old elfcorehdr with newly prepared elfcorehdr */ memcpy((void *)ptr, elfbuf, elfsz); /* The crash image is now valid once again */ - xchg(&kexec_crash_image, image); + kimage_update_compat_pointers(image, KEXEC_TYPE_CRASH); } out: kvfree(cmem); @@ -537,14 +537,14 @@ static void update_crash_fdt(struct kimage *image) fdt = __va((void *)image->segment[fdt_index].mem); /* Temporarily invalidate the crash image while it is replaced */ - xchg(&kexec_crash_image, NULL); + kimage_update_compat_pointers(NULL, KEXEC_TYPE_CRASH); /* update FDT to reflect changes in CPU resources */ if (update_cpus_node(fdt)) pr_err("Failed to update crash FDT"); /* The crash image is now valid once again */ - xchg(&kexec_crash_image, image); + kimage_update_compat_pointers(image, KEXEC_TYPE_CRASH); } int arch_crash_hotplug_support(struct kimage *image, unsigned long kexec_flags) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index 335fd2ee9766..a81f91d4352d 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -559,9 +559,9 @@ void arch_crash_handle_hotplug_event(struct kimage *image, void *arg) * Temporarily invalidate the crash image while the * elfcorehdr is updated. */ - xchg(&kexec_crash_image, NULL); + kimage_update_compat_pointers(NULL, KEXEC_TYPE_CRASH); memcpy_flushcache(old_elfcorehdr, elfbuf, elfsz); - xchg(&kexec_crash_image, image); + kimage_update_compat_pointers(image, KEXEC_TYPE_CRASH); kunmap_local(old_elfcorehdr); pr_debug("updated elfcorehdr\n"); diff --git a/include/linux/kexec.h b/include/linux/kexec.h index edf64bc98ed5..69877db5360b 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -431,6 +431,9 @@ struct kimage { /* dm crypt keys buffer */ unsigned long dm_crypt_keys_addr; unsigned long dm_crypt_keys_sz; + + /* For multikernel support: linked list node */ + struct list_head list; }; /* kexec interface functions */ @@ -534,6 +537,16 @@ extern bool kexec_file_dbg_print; extern void *kimage_map_segment(struct kimage *image, unsigned long addr, unsigned long size); extern void kimage_unmap_segment(void *buffer); + +/* Multikernel support functions */ +extern struct kimage *kimage_find_by_type(int type); +extern void kimage_add_to_list(struct kimage *image); +extern void kimage_remove_from_list(struct kimage *image); +extern void kimage_update_compat_pointers(struct kimage *new_image, int type); +extern int kimage_get_all_by_type(int type, struct kimage **images, int max_count); +extern void kimage_list_lock(void); +extern void kimage_list_unlock(void); +extern void kimage_list_multikernel_images(void); #else /* !CONFIG_KEXEC_CORE */ struct pt_regs; struct task_struct; diff --git a/kernel/kexec.c b/kernel/kexec.c index 28008e3d462e..74b8df4670e0 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -114,7 +114,31 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, if (nr_segments == 0) { /* Uninstall image */ - kimage_free(xchg(dest_image, NULL)); + if (flags & KEXEC_ON_CRASH) { + struct kimage *old_image = xchg(&kexec_crash_image, NULL); + if (old_image) { + kimage_remove_from_list(old_image); + kimage_free(old_image); + } + } else if (flags & KEXEC_MULTIKERNEL) { + /* For multikernel unload, we need to specify which image to remove */ + /* For now, remove all multikernel images - this could be enhanced */ + struct kimage *images[10]; + int count, i; + + count = kimage_get_all_by_type(KEXEC_TYPE_MULTIKERNEL, images, 10); + for (i = 0; i < count; i++) { + kimage_remove_from_list(images[i]); + kimage_free(images[i]); + } + pr_info("Unloaded %d multikernel images\n", count); + } else { + struct kimage *old_image = xchg(&kexec_image, NULL); + if (old_image) { + kimage_remove_from_list(old_image); + kimage_free(old_image); + } + } ret = 0; goto out_unlock; } @@ -124,7 +148,11 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, * crashes. Free any current crash dump kernel before * we corrupt it. */ - kimage_free(xchg(&kexec_crash_image, NULL)); + struct kimage *old_crash_image = xchg(&kexec_crash_image, NULL); + if (old_crash_image) { + kimage_remove_from_list(old_crash_image); + kimage_free(old_crash_image); + } } ret = kimage_alloc_init(&image, entry, nr_segments, segments, flags); @@ -164,7 +192,33 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments, goto out; /* Install the new kernel and uninstall the old */ - image = xchg(dest_image, image); + if (flags & KEXEC_ON_CRASH) { + struct kimage *old_image = xchg(&kexec_crash_image, image); + if (old_image) { + kimage_remove_from_list(old_image); + kimage_free(old_image); + } + if (image) { + kimage_add_to_list(image); + kimage_update_compat_pointers(image, KEXEC_TYPE_CRASH); + } + image = NULL; /* Don't free the new image */ + } else if (flags & KEXEC_MULTIKERNEL) { + if (image) + kimage_add_to_list(image); + image = NULL; /* Don't free the new image */ + } else { + struct kimage *old_image = xchg(&kexec_image, image); + if (old_image) { + kimage_remove_from_list(old_image); + kimage_free(old_image); + } + if (image) { + kimage_add_to_list(image); + kimage_update_compat_pointers(image, KEXEC_TYPE_DEFAULT); + } + image = NULL; /* Don't free the new image */ + } out: #ifdef CONFIG_CRASH_DUMP diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 7d89d00e2cde..449096060fe8 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -56,6 +56,10 @@ bool kexec_in_progress = false; bool kexec_file_dbg_print; +/* Linked list of dynamically allocated kimages */ +static LIST_HEAD(kexec_image_list); +static DEFINE_MUTEX(kexec_image_mutex); + /* * When kexec transitions to the new kernel there is a one-to-one * mapping between physical and virtual addresses. On processors @@ -248,6 +252,9 @@ struct kimage *do_kimage_alloc_init(void) /* Initialize the list of unusable pages */ INIT_LIST_HEAD(&image->unusable_pages); + /* Initialize the list node for multikernel support */ + INIT_LIST_HEAD(&image->list); + #ifdef CONFIG_CRASH_HOTPLUG image->hp_action = KEXEC_CRASH_HP_NONE; image->elfcorehdr_index = -1; @@ -580,6 +587,13 @@ void kimage_free(struct kimage *image) if (!image) return; + /* Remove from linked list and update compatibility pointers */ + kimage_remove_from_list(image); + if (image == kexec_image) + kimage_update_compat_pointers(NULL, KEXEC_TYPE_DEFAULT); + else if (image == kexec_crash_image) + kimage_update_compat_pointers(NULL, KEXEC_TYPE_CRASH); + #ifdef CONFIG_CRASH_DUMP if (image->vmcoreinfo_data_copy) { crash_update_vmcoreinfo_safecopy(NULL); @@ -1096,6 +1110,72 @@ void kimage_unmap_segment(void *segment_buffer) vunmap(segment_buffer); } +void kimage_add_to_list(struct kimage *image) +{ + mutex_lock(&kexec_image_mutex); + list_add_tail(&image->list, &kexec_image_list); + mutex_unlock(&kexec_image_mutex); +} + +void kimage_remove_from_list(struct kimage *image) +{ + mutex_lock(&kexec_image_mutex); + if (!list_empty(&image->list)) + list_del_init(&image->list); + mutex_unlock(&kexec_image_mutex); +} + +struct kimage *kimage_find_by_type(int type) +{ + struct kimage *image; + + mutex_lock(&kexec_image_mutex); + list_for_each_entry(image, &kexec_image_list, list) { + if (image->type == type) { + mutex_unlock(&kexec_image_mutex); + return image; + } + } + mutex_unlock(&kexec_image_mutex); + return NULL; +} + +void kimage_update_compat_pointers(struct kimage *new_image, int type) +{ + mutex_lock(&kexec_image_mutex); + if (type == KEXEC_TYPE_CRASH) { + kexec_crash_image = new_image; + } else if (type == KEXEC_TYPE_DEFAULT) { + kexec_image = new_image; + } + mutex_unlock(&kexec_image_mutex); +} + +int kimage_get_all_by_type(int type, struct kimage **images, int max_count) +{ + struct kimage *image; + int count = 0; + + mutex_lock(&kexec_image_mutex); + list_for_each_entry(image, &kexec_image_list, list) { + if (image->type == type && count < max_count) { + images[count++] = image; + } + } + mutex_unlock(&kexec_image_mutex); + return count; +} + +void kimage_list_lock(void) +{ + mutex_lock(&kexec_image_mutex); +} + +void kimage_list_unlock(void) +{ + mutex_unlock(&kexec_image_mutex); +} + struct kexec_load_limit { /* Mutex protects the limit count. */ struct mutex mutex; @@ -1112,6 +1192,7 @@ static struct kexec_load_limit load_limit_panic = { .limit = -1, }; +/* Compatibility: maintain pointers to current default and crash images */ struct kimage *kexec_image; struct kimage *kexec_crash_image; static int kexec_load_disabled; diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index eb62a9794242..2d9d5626c8da 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -400,8 +400,13 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, * same memory where old crash kernel might be loaded. Free any * current crash dump kernel before we corrupt it. */ - if (flags & KEXEC_FILE_ON_CRASH) - kimage_free(xchg(&kexec_crash_image, NULL)); + if (flags & KEXEC_FILE_ON_CRASH) { + struct kimage *old_crash_image = xchg(&kexec_crash_image, NULL); + if (old_crash_image) { + kimage_remove_from_list(old_crash_image); + kimage_free(old_crash_image); + } + } ret = kimage_file_alloc_init(&image, kernel_fd, initrd_fd, cmdline_ptr, cmdline_len, flags); @@ -457,7 +462,29 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, */ kimage_file_post_load_cleanup(image); exchange: - image = xchg(dest_image, image); + if (image_type == KEXEC_TYPE_CRASH) { + struct kimage *old_image = xchg(&kexec_crash_image, image); + if (old_image) { + kimage_remove_from_list(old_image); + kimage_free(old_image); + } + if (image) { + kimage_add_to_list(image); + kimage_update_compat_pointers(image, KEXEC_TYPE_CRASH); + } + image = NULL; /* Don't free the new image */ + } else { + struct kimage *old_image = xchg(&kexec_image, image); + if (old_image) { + kimage_remove_from_list(old_image); + kimage_free(old_image); + } + if (image) { + kimage_add_to_list(image); + kimage_update_compat_pointers(image, KEXEC_TYPE_DEFAULT); + } + image = NULL; /* Don't free the new image */ + } out: #ifdef CONFIG_CRASH_DUMP if ((flags & KEXEC_FILE_ON_CRASH) && kexec_crash_image) -- 2.34.1