netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: syzbot <syzbot+c613e88b3093ebf3686e@syzkaller.appspotmail.com>
To: bjorn.andersson@linaro.org, dan.carpenter@oracle.com,
	eric.dumazet@gmail.com, hdanton@sina.com,
	linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org,
	netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING: refcount bug in qrtr_node_lookup
Date: Wed, 01 Sep 2021 19:32:06 -0700	[thread overview]
Message-ID: <0000000000002d262305caf9fdde@google.com> (raw)
In-Reply-To: <20210902005238.2413-1-hdanton@sina.com>

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
UBSAN: object-size-mismatch in send4

================================================================================
UBSAN: object-size-mismatch in ./include/net/flow.h:197:33
member access within address 000000001597b753 with insufficient space
for an object of type 'struct flowi'
CPU: 1 PID: 231 Comm: kworker/u4:4 Not tainted 5.14.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: wg-kex-wg0 wg_packet_handshake_send_worker
Call Trace:
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x15e/0x1d3 lib/dump_stack.c:105
 ubsan_epilogue lib/ubsan.c:148 [inline]
 handle_object_size_mismatch lib/ubsan.c:229 [inline]
 ubsan_type_mismatch_common+0x1de/0x390 lib/ubsan.c:242
 __ubsan_handle_type_mismatch_v1+0x41/0x50 lib/ubsan.c:271
 flowi4_to_flowi_common include/net/flow.h:197 [inline]
 send4+0x39b/0xdd0 drivers/net/wireguard/socket.c:52
 wg_socket_send_skb_to_peer+0xc7/0x200 drivers/net/wireguard/socket.c:174
 wg_packet_send_handshake_initiation drivers/net/wireguard/send.c:40 [inline]
 wg_packet_handshake_send_worker+0x14a/0x190 drivers/net/wireguard/send.c:51
 process_one_work+0x471/0x840 kernel/workqueue.c:2276
 worker_thread+0x686/0x9e0 kernel/workqueue.c:2422
 kthread+0x3ca/0x3f0 kernel/kthread.c:319
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
================================================================================
================================================================================
UBSAN: object-size-mismatch in ./include/net/flow.h:197:33
member access within address 000000001597b753 with insufficient space
for an object of type 'union (anonymous union at ./include/net/flow.h:172:2)'
CPU: 1 PID: 231 Comm: kworker/u4:4 Not tainted 5.14.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: wg-kex-wg0 wg_packet_handshake_send_worker
Call Trace:
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x15e/0x1d3 lib/dump_stack.c:105
 ubsan_epilogue lib/ubsan.c:148 [inline]
 handle_object_size_mismatch lib/ubsan.c:229 [inline]
 ubsan_type_mismatch_common+0x1de/0x390 lib/ubsan.c:242
 __ubsan_handle_type_mismatch_v1+0x41/0x50 lib/ubsan.c:271
 flowi4_to_flowi_common include/net/flow.h:197 [inline]
 send4+0x3aa/0xdd0 drivers/net/wireguard/socket.c:52
 wg_socket_send_skb_to_peer+0xc7/0x200 drivers/net/wireguard/socket.c:174
 wg_packet_send_handshake_initiation drivers/net/wireguard/send.c:40 [inline]
 wg_packet_handshake_send_worker+0x14a/0x190 drivers/net/wireguard/send.c:51
 process_one_work+0x471/0x840 kernel/workqueue.c:2276
 worker_thread+0x686/0x9e0 kernel/workqueue.c:2422
 kthread+0x3ca/0x3f0 kernel/kthread.c:319
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
================================================================================


Tested on:

commit:         b91db6a0 Merge tag 'for-5.15/io_uring-vfs-2021-08-30' ..
git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=11740133300000
kernel config:  https://syzkaller.appspot.com/x/.config?x=7d1b73d0f1d597e4
dashboard link: https://syzkaller.appspot.com/bug?extid=c613e88b3093ebf3686e
compiler:       Debian clang version 11.0.1-2, GNU ld (GNU Binutils for Debian) 2.35.1
patch:          https://syzkaller.appspot.com/x/patch.diff?x=13a44435300000


       reply	other threads:[~2021-09-02  2:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210902005238.2413-1-hdanton@sina.com>
2021-09-02  2:32 ` syzbot [this message]
     [not found]   ` <20210902041238.2559-1-hdanton@sina.com>
2021-09-02 13:58     ` [syzbot] WARNING: refcount bug in qrtr_node_lookup Paul Moore
2021-09-03  2:40       ` Paul Moore
     [not found] <20210903042820.2733-1-hdanton@sina.com>
2021-09-03 11:04 ` syzbot
     [not found] <20210901030636.2336-1-hdanton@sina.com>
2021-09-01  3:41 ` syzbot
2021-09-01  4:26   ` Eric Dumazet
2020-09-07 21:18 syzbot
2021-08-28 18:32 ` [syzbot] " syzbot
2021-08-30  8:39   ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0000000000002d262305caf9fdde@google.com \
    --to=syzbot+c613e88b3093ebf3686e@syzkaller.appspotmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=dan.carpenter@oracle.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).