netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: KASAN: slab-out-of-bounds Read in tick_sched_handle
       [not found] <000000000000551b80057d31a5f7@google.com>
@ 2019-03-16 14:49 ` syzbot
  2019-03-16 15:52   ` Stefano Brivio
  0 siblings, 1 reply; 4+ messages in thread
From: syzbot @ 2019-03-16 14:49 UTC (permalink / raw)
  To: davem, fweisbec, kuznet, linux-kernel, mingo, netdev, sbrivio, sd,
	syzkaller-bugs, tglx, yoshfuji

syzbot has bisected this bug to:

commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e
Author: Stefano Brivio <sbrivio@redhat.com>
Date:   Thu Nov 8 11:19:23 2018 +0000

     fou, fou6: ICMP error handlers for FoU and GUE

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=16f943e7200000
start commit:   b8a51b38 fou, fou6: ICMP error handlers for FoU and GUE
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=15f943e7200000
console output: https://syzkaller.appspot.com/x/log.txt?x=11f943e7200000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b05cfdb4ee8ab9b2
dashboard link: https://syzkaller.appspot.com/bug?extid=09d51a30df9fe76edb2a
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17359fab400000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=154a2a37400000

Reported-by: syzbot+09d51a30df9fe76edb2a@syzkaller.appspotmail.com
Fixes: b8a51b38 ("fou, fou6: ICMP error handlers for FoU and GUE")

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: KASAN: slab-out-of-bounds Read in tick_sched_handle
  2019-03-16 14:49 ` KASAN: slab-out-of-bounds Read in tick_sched_handle syzbot
@ 2019-03-16 15:52   ` Stefano Brivio
  2019-03-16 16:07     ` Dmitry Vyukov
  0 siblings, 1 reply; 4+ messages in thread
From: Stefano Brivio @ 2019-03-16 15:52 UTC (permalink / raw)
  To: syzbot
  Cc: davem, fweisbec, kuznet, linux-kernel, mingo, netdev, sd,
	syzkaller-bugs, tglx, yoshfuji, Eric Dumazet

On Sat, 16 Mar 2019 07:49:01 -0700
syzbot <syzbot+09d51a30df9fe76edb2a@syzkaller.appspotmail.com> wrote:

> syzbot has bisected this bug to:
> 
> commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e
> Author: Stefano Brivio <sbrivio@redhat.com>
> Date:   Thu Nov 8 11:19:23 2018 +0000
> 
>      fou, fou6: ICMP error handlers for FoU and GUE
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=16f943e7200000
> start commit:   b8a51b38 fou, fou6: ICMP error handlers for FoU and GUE
> git tree:       upstream
> final crash:    https://syzkaller.appspot.com/x/report.txt?x=15f943e7200000
> console output: https://syzkaller.appspot.com/x/log.txt?x=11f943e7200000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=b05cfdb4ee8ab9b2
> dashboard link: https://syzkaller.appspot.com/bug?extid=09d51a30df9fe76edb2a
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17359fab400000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=154a2a37400000
> 
> Reported-by: syzbot+09d51a30df9fe76edb2a@syzkaller.appspotmail.com
> Fixes: b8a51b38 ("fou, fou6: ICMP error handlers for FoU and GUE")

Might be fixed by bc6e019b6ee6 ("fou: Prevent unbounded recursion in GUE
error handler also with UDP-Lite"), testing/checking now.

-- 
Stefano

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: KASAN: slab-out-of-bounds Read in tick_sched_handle
  2019-03-16 15:52   ` Stefano Brivio
@ 2019-03-16 16:07     ` Dmitry Vyukov
  2019-03-16 16:22       ` Stefano Brivio
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Vyukov @ 2019-03-16 16:07 UTC (permalink / raw)
  To: Stefano Brivio
  Cc: syzbot, David Miller, Frédéric Weisbecker,
	Alexey Kuznetsov, LKML, Ingo Molnar, netdev, Sabrina Dubroca,
	syzkaller-bugs, Thomas Gleixner, Hideaki YOSHIFUJI, Eric Dumazet

On Sat, Mar 16, 2019 at 4:53 PM Stefano Brivio <sbrivio@redhat.com> wrote:
>
> On Sat, 16 Mar 2019 07:49:01 -0700
> syzbot <syzbot+09d51a30df9fe76edb2a@syzkaller.appspotmail.com> wrote:
>
> > syzbot has bisected this bug to:
> >
> > commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e
> > Author: Stefano Brivio <sbrivio@redhat.com>
> > Date:   Thu Nov 8 11:19:23 2018 +0000
> >
> >      fou, fou6: ICMP error handlers for FoU and GUE
> >
> > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=16f943e7200000
> > start commit:   b8a51b38 fou, fou6: ICMP error handlers for FoU and GUE
> > git tree:       upstream
> > final crash:    https://syzkaller.appspot.com/x/report.txt?x=15f943e7200000
> > console output: https://syzkaller.appspot.com/x/log.txt?x=11f943e7200000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=b05cfdb4ee8ab9b2
> > dashboard link: https://syzkaller.appspot.com/bug?extid=09d51a30df9fe76edb2a
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17359fab400000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=154a2a37400000
> >
> > Reported-by: syzbot+09d51a30df9fe76edb2a@syzkaller.appspotmail.com
> > Fixes: b8a51b38 ("fou, fou6: ICMP error handlers for FoU and GUE")
>
> Might be fixed by bc6e019b6ee6 ("fou: Prevent unbounded recursion in GUE
> error handler also with UDP-Lite"), testing/checking now.

Yes, most likely it is. The bug was just never closed as fixed. But
the last crash happened 2 months ago.
So I would say we just mark this as fixed:

#syz fix:
fou: Prevent unbounded recursion in GUE error handler also with UDP-Lite

Next after root cause bisection is fix bisection, so this part will be
automated to some degree as well.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: KASAN: slab-out-of-bounds Read in tick_sched_handle
  2019-03-16 16:07     ` Dmitry Vyukov
@ 2019-03-16 16:22       ` Stefano Brivio
  0 siblings, 0 replies; 4+ messages in thread
From: Stefano Brivio @ 2019-03-16 16:22 UTC (permalink / raw)
  To: Dmitry Vyukov
  Cc: syzbot, David Miller, Frédéric Weisbecker,
	Alexey Kuznetsov, LKML, Ingo Molnar, netdev, Sabrina Dubroca,
	syzkaller-bugs, Thomas Gleixner, Hideaki YOSHIFUJI, Eric Dumazet

On Sat, 16 Mar 2019 17:07:13 +0100
Dmitry Vyukov <dvyukov@google.com> wrote:

> On Sat, Mar 16, 2019 at 4:53 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> >
> > On Sat, 16 Mar 2019 07:49:01 -0700
> > syzbot <syzbot+09d51a30df9fe76edb2a@syzkaller.appspotmail.com> wrote:
> >  
> > > syzbot has bisected this bug to:
> > >
> > > commit b8a51b38e4d4dec3e379d52c0fe1a66827f7cf1e
> > > Author: Stefano Brivio <sbrivio@redhat.com>
> > > Date:   Thu Nov 8 11:19:23 2018 +0000
> > >
> > >      fou, fou6: ICMP error handlers for FoU and GUE
> > >
> > > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=16f943e7200000
> > > start commit:   b8a51b38 fou, fou6: ICMP error handlers for FoU and GUE
> > > git tree:       upstream
> > > final crash:    https://syzkaller.appspot.com/x/report.txt?x=15f943e7200000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=11f943e7200000
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=b05cfdb4ee8ab9b2
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=09d51a30df9fe76edb2a
> > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17359fab400000
> > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=154a2a37400000
> > >
> > > Reported-by: syzbot+09d51a30df9fe76edb2a@syzkaller.appspotmail.com
> > > Fixes: b8a51b38 ("fou, fou6: ICMP error handlers for FoU and GUE")  
> >
> > Might be fixed by bc6e019b6ee6 ("fou: Prevent unbounded recursion in GUE
> > error handler also with UDP-Lite"), testing/checking now.  
> 
> Yes, most likely it is. The bug was just never closed as fixed. But
> the last crash happened 2 months ago.
> So I would say we just mark this as fixed:
> 
> #syz fix:
> fou: Prevent unbounded recursion in GUE error handler also with UDP-Lite

Confirmed by testing, too.

> Next after root cause bisection is fix bisection, so this part will be
> automated to some degree as well.

Nice, thanks for doing that.

-- 
Stefano

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-16 16:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <000000000000551b80057d31a5f7@google.com>
2019-03-16 14:49 ` KASAN: slab-out-of-bounds Read in tick_sched_handle syzbot
2019-03-16 15:52   ` Stefano Brivio
2019-03-16 16:07     ` Dmitry Vyukov
2019-03-16 16:22       ` Stefano Brivio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).