[syzbot] [net?] UBSAN: array-index-out-of-bounds in cake_enqueue

[syzbot] [net?] UBSAN: array-index-out-of-bounds in cake_enqueue

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    a99ef548bba0 bnx2x: Set ivi->vlan field as an integer
git tree:       net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=10baacfd980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=7229118d88b4a71b
dashboard link: https://syzkaller.appspot.com/bug?extid=7fe7b81d602cc1e6b94d
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d555f757c854/disk-a99ef548.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8e46d450e252/vmlinux-a99ef548.xz
kernel image: https://storage.googleapis.com/syzbot-assets/bc2197d1b6a7/bzImage-a99ef548.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com

------------[ cut here ]------------
UBSAN: array-index-out-of-bounds in net/sched/sch_cake.c:1876:6
index 65535 is out of range for type 'u16[1025]' (aka 'unsigned short[1025]')
CPU: 0 UID: 0 PID: 5282 Comm: kworker/0:6 Not tainted 6.11.0-rc3-syzkaller-00482-ga99ef548bba0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Workqueue: wg-crypt-wg0 wg_packet_tx_worker
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:93 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
 ubsan_epilogue lib/ubsan.c:231 [inline]
 __ubsan_handle_out_of_bounds+0x121/0x150 lib/ubsan.c:429
 cake_enqueue+0x785e/0x9340 net/sched/sch_cake.c:1876
 dev_qdisc_enqueue+0x4b/0x290 net/core/dev.c:3775
 __dev_xmit_skb net/core/dev.c:3871 [inline]
 __dev_queue_xmit+0xf4a/0x3e90 net/core/dev.c:4389
 dev_queue_xmit include/linux/netdevice.h:3073 [inline]
 neigh_hh_output include/net/neighbour.h:526 [inline]
 neigh_output include/net/neighbour.h:540 [inline]
 ip6_finish_output2+0xfc2/0x1680 net/ipv6/ip6_output.c:137
 ip6_finish_output+0x41e/0x810 net/ipv6/ip6_output.c:222
 ip6tunnel_xmit include/net/ip6_tunnel.h:161 [inline]
 udp_tunnel6_xmit_skb+0x590/0x9d0 net/ipv6/ip6_udp_tunnel.c:111
 send6+0x6da/0xaf0 drivers/net/wireguard/socket.c:152
 wg_socket_send_skb_to_peer+0x115/0x1d0 drivers/net/wireguard/socket.c:178
 wg_packet_create_data_done drivers/net/wireguard/send.c:251 [inline]
 wg_packet_tx_worker+0x1bf/0x810 drivers/net/wireguard/send.c:276
 process_one_work kernel/workqueue.c:3231 [inline]
 process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3312
 worker_thread+0x86d/0xd40 kernel/workqueue.c:3390
 kthread+0x2f0/0x390 kernel/kthread.c:389
 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
 </TASK>
---[ end trace ]---


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [net?] UBSAN: array-index-out-of-bounds in cake_enqueue

[Aleksandr Nogikh]

#syz upstream

On Mon, Aug 19, 2024 at 11:54 AM syzbot
<syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com> wrote:
>
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:    a99ef548bba0 bnx2x: Set ivi->vlan field as an integer
> git tree:       net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=10baacfd980000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=7229118d88b4a71b
> dashboard link: https://syzkaller.appspot.com/bug?extid=7fe7b81d602cc1e6b94d
> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
>
> Unfortunately, I don't have any reproducer for this issue yet.
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/d555f757c854/disk-a99ef548.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/8e46d450e252/vmlinux-a99ef548.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/bc2197d1b6a7/bzImage-a99ef548.xz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com
>
> ------------[ cut here ]------------
> UBSAN: array-index-out-of-bounds in net/sched/sch_cake.c:1876:6
> index 65535 is out of range for type 'u16[1025]' (aka 'unsigned short[1025]')
> CPU: 0 UID: 0 PID: 5282 Comm: kworker/0:6 Not tainted 6.11.0-rc3-syzkaller-00482-ga99ef548bba0 #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
> Workqueue: wg-crypt-wg0 wg_packet_tx_worker
> Call Trace:
>  <TASK>
>  __dump_stack lib/dump_stack.c:93 [inline]
>  dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
>  ubsan_epilogue lib/ubsan.c:231 [inline]
>  __ubsan_handle_out_of_bounds+0x121/0x150 lib/ubsan.c:429
>  cake_enqueue+0x785e/0x9340 net/sched/sch_cake.c:1876
>  dev_qdisc_enqueue+0x4b/0x290 net/core/dev.c:3775
>  __dev_xmit_skb net/core/dev.c:3871 [inline]
>  __dev_queue_xmit+0xf4a/0x3e90 net/core/dev.c:4389
>  dev_queue_xmit include/linux/netdevice.h:3073 [inline]
>  neigh_hh_output include/net/neighbour.h:526 [inline]
>  neigh_output include/net/neighbour.h:540 [inline]
>  ip6_finish_output2+0xfc2/0x1680 net/ipv6/ip6_output.c:137
>  ip6_finish_output+0x41e/0x810 net/ipv6/ip6_output.c:222
>  ip6tunnel_xmit include/net/ip6_tunnel.h:161 [inline]
>  udp_tunnel6_xmit_skb+0x590/0x9d0 net/ipv6/ip6_udp_tunnel.c:111
>  send6+0x6da/0xaf0 drivers/net/wireguard/socket.c:152
>  wg_socket_send_skb_to_peer+0x115/0x1d0 drivers/net/wireguard/socket.c:178
>  wg_packet_create_data_done drivers/net/wireguard/send.c:251 [inline]
>  wg_packet_tx_worker+0x1bf/0x810 drivers/net/wireguard/send.c:276
>  process_one_work kernel/workqueue.c:3231 [inline]
>  process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3312
>  worker_thread+0x86d/0xd40 kernel/workqueue.c:3390
>  kthread+0x2f0/0x390 kernel/kthread.c:389
>  ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
>  ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
>  </TASK>
> ---[ end trace ]---
>
>
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@googlegroups.com.
>
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>
> If the report is already addressed, let syzbot know by replying with:
> #syz fix: exact-commit-title
>
> If you want to overwrite report's subsystems, reply with:
> #syz set subsystems: new-subsystem
> (See the list of subsystem names on the web dashboard)
>
> If the report is a duplicate of another one, reply with:
> #syz dup: exact-subject-of-another-report
>
> If you want to undo deduplication, reply with:
> #syz undup
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/00000000000071e6110620064b4c%40google.com.

Re: [syzbot] [net?] UBSAN: array-index-out-of-bounds in cake_enqueue

[syzbot]

> #syz upstream

Can't upstream, this is final destination.

>
> On Mon, Aug 19, 2024 at 11:54 AM syzbot
> <syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com> wrote:
>>
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:    a99ef548bba0 bnx2x: Set ivi->vlan field as an integer
>> git tree:       net-next
>> console output: https://syzkaller.appspot.com/x/log.txt?x=10baacfd980000
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=7229118d88b4a71b
>> dashboard link: https://syzkaller.appspot.com/bug?extid=7fe7b81d602cc1e6b94d
>> compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
>>
>> Unfortunately, I don't have any reproducer for this issue yet.
>>
>> Downloadable assets:
>> disk image: https://storage.googleapis.com/syzbot-assets/d555f757c854/disk-a99ef548.raw.xz
>> vmlinux: https://storage.googleapis.com/syzbot-assets/8e46d450e252/vmlinux-a99ef548.xz
>> kernel image: https://storage.googleapis.com/syzbot-assets/bc2197d1b6a7/bzImage-a99ef548.xz
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+7fe7b81d602cc1e6b94d@syzkaller.appspotmail.com
>>
>> ------------[ cut here ]------------
>> UBSAN: array-index-out-of-bounds in net/sched/sch_cake.c:1876:6
>> index 65535 is out of range for type 'u16[1025]' (aka 'unsigned short[1025]')
>> CPU: 0 UID: 0 PID: 5282 Comm: kworker/0:6 Not tainted 6.11.0-rc3-syzkaller-00482-ga99ef548bba0 #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
>> Workqueue: wg-crypt-wg0 wg_packet_tx_worker
>> Call Trace:
>>  <TASK>
>>  __dump_stack lib/dump_stack.c:93 [inline]
>>  dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
>>  ubsan_epilogue lib/ubsan.c:231 [inline]
>>  __ubsan_handle_out_of_bounds+0x121/0x150 lib/ubsan.c:429
>>  cake_enqueue+0x785e/0x9340 net/sched/sch_cake.c:1876
>>  dev_qdisc_enqueue+0x4b/0x290 net/core/dev.c:3775
>>  __dev_xmit_skb net/core/dev.c:3871 [inline]
>>  __dev_queue_xmit+0xf4a/0x3e90 net/core/dev.c:4389
>>  dev_queue_xmit include/linux/netdevice.h:3073 [inline]
>>  neigh_hh_output include/net/neighbour.h:526 [inline]
>>  neigh_output include/net/neighbour.h:540 [inline]
>>  ip6_finish_output2+0xfc2/0x1680 net/ipv6/ip6_output.c:137
>>  ip6_finish_output+0x41e/0x810 net/ipv6/ip6_output.c:222
>>  ip6tunnel_xmit include/net/ip6_tunnel.h:161 [inline]
>>  udp_tunnel6_xmit_skb+0x590/0x9d0 net/ipv6/ip6_udp_tunnel.c:111
>>  send6+0x6da/0xaf0 drivers/net/wireguard/socket.c:152
>>  wg_socket_send_skb_to_peer+0x115/0x1d0 drivers/net/wireguard/socket.c:178
>>  wg_packet_create_data_done drivers/net/wireguard/send.c:251 [inline]
>>  wg_packet_tx_worker+0x1bf/0x810 drivers/net/wireguard/send.c:276
>>  process_one_work kernel/workqueue.c:3231 [inline]
>>  process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3312
>>  worker_thread+0x86d/0xd40 kernel/workqueue.c:3390
>>  kthread+0x2f0/0x390 kernel/kthread.c:389
>>  ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
>>  ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
>>  </TASK>
>> ---[ end trace ]---
>>
>>
>> ---
>> This report is generated by a bot. It may contain errors.
>> See https://goo.gl/tpsmEJ for more information about syzbot.
>> syzbot engineers can be reached at syzkaller@googlegroups.com.
>>
>> syzbot will keep track of this issue. See:
>> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>>
>> If the report is already addressed, let syzbot know by replying with:
>> #syz fix: exact-commit-title
>>
>> If you want to overwrite report's subsystems, reply with:
>> #syz set subsystems: new-subsystem
>> (See the list of subsystem names on the web dashboard)
>>
>> If the report is a duplicate of another one, reply with:
>> #syz dup: exact-subject-of-another-report
>>
>> If you want to undo deduplication, reply with:
>> #syz undup
>>
>> --
>> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/00000000000071e6110620064b4c%40google.com.