* [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2)
@ 2024-05-27 0:44 syzbot
2024-06-09 11:34 ` syzbot
2024-08-31 20:55 ` syzbot
0 siblings, 2 replies; 5+ messages in thread
From: syzbot @ 2024-05-27 0:44 UTC (permalink / raw)
To: andrii, ast, bpf, daniel, davem, eddyz87, haoluo, hawk,
john.fastabend, jolsa, kpsingh, kuba, linux-kernel, martin.lau,
netdev, sdf, song, syzkaller-bugs, yonghong.song
Hello,
syzbot found the following issue on:
HEAD commit: 8f6a15f095a6 Merge tag 'cocci-for-6.10' of git://git.kerne..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=136bd8fc980000
kernel config: https://syzkaller.appspot.com/x/.config?x=6be91306a8917025
dashboard link: https://syzkaller.appspot.com/bug?extid=cca39e6e84a367a7e6f6
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/02867060d65d/disk-8f6a15f0.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4bb75fbf6fb1/vmlinux-8f6a15f0.xz
kernel image: https://storage.googleapis.com/syzbot-assets/fd38cadddf33/bzImage-8f6a15f0.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cca39e6e84a367a7e6f6@syzkaller.appspotmail.com
Oops: general protection fault, probably for non-canonical address 0xdffffc000000003b: 0000 [#1] PREEMPT SMP KASAN PTI
KASAN: null-ptr-deref in range [0x00000000000001d8-0x00000000000001df]
CPU: 0 PID: 12830 Comm: syz-executor.1 Not tainted 6.9.0-syzkaller-10323-g8f6a15f095a6 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
RIP: 0010:__xdp_enqueue kernel/bpf/devmap.c:484 [inline]
RIP: 0010:dev_map_enqueue+0x70/0x3e0 kernel/bpf/devmap.c:541
Code: c5 18 48 89 e8 48 c1 e8 03 42 80 3c 30 00 74 08 48 89 ef e8 b2 10 3a 00 48 8b 5d 00 49 8d af d8 01 00 00 48 89 e8 48 c1 e8 03 <42> 0f b6 04 30 84 c0 0f 85 3a 02 00 00 8b 6d 00 89 ee 83 e6 04 31
RSP: 0018:ffffc900031ff678 EFLAGS: 00010202
RAX: 000000000000003b RBX: ffff888023efa078 RCX: 0000000000040000
RDX: ffffc90015e01000 RSI: 0000000000000ba1 RDI: 0000000000000ba2
RBP: 00000000000001d9 R08: ffffffff895b0946 R09: ffffffff895b0903
R10: 0000000000000004 R11: ffff888020d73c00 R12: ffff888058f06000
R13: ffff888021fff070 R14: dffffc0000000000 R15: 0000000000000001
FS: 00007f9f791576c0(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b30823000 CR3: 000000002e298000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__xdp_do_redirect_frame net/core/filter.c:4397 [inline]
xdp_do_redirect_frame+0x2a6/0x660 net/core/filter.c:4451
xdp_test_run_batch net/bpf/test_run.c:336 [inline]
bpf_test_run_xdp_live+0xe60/0x1e60 net/bpf/test_run.c:384
bpf_prog_test_run_xdp+0x80e/0x11b0 net/bpf/test_run.c:1275
bpf_prog_test_run+0x33a/0x3b0 kernel/bpf/syscall.c:4291
__sys_bpf+0x48d/0x810 kernel/bpf/syscall.c:5705
__do_sys_bpf kernel/bpf/syscall.c:5794 [inline]
__se_sys_bpf kernel/bpf/syscall.c:5792 [inline]
__x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5792
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f9f7847cee9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9f791570c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000141
RAX: ffffffffffffffda RBX: 00007f9f785ac050 RCX: 00007f9f7847cee9
RDX: 0000000000000048 RSI: 00000000200000c0 RDI: 000000000000000a
RBP: 00007f9f784c949e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000006e R14: 00007f9f785ac050 R15: 00007ffc7dc03298
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:__xdp_enqueue kernel/bpf/devmap.c:484 [inline]
RIP: 0010:dev_map_enqueue+0x70/0x3e0 kernel/bpf/devmap.c:541
Code: c5 18 48 89 e8 48 c1 e8 03 42 80 3c 30 00 74 08 48 89 ef e8 b2 10 3a 00 48 8b 5d 00 49 8d af d8 01 00 00 48 89 e8 48 c1 e8 03 <42> 0f b6 04 30 84 c0 0f 85 3a 02 00 00 8b 6d 00 89 ee 83 e6 04 31
RSP: 0018:ffffc900031ff678 EFLAGS: 00010202
RAX: 000000000000003b RBX: ffff888023efa078 RCX: 0000000000040000
RDX: ffffc90015e01000 RSI: 0000000000000ba1 RDI: 0000000000000ba2
RBP: 00000000000001d9 R08: ffffffff895b0946 R09: ffffffff895b0903
R10: 0000000000000004 R11: ffff888020d73c00 R12: ffff888058f06000
R13: ffff888021fff070 R14: dffffc0000000000 R15: 0000000000000001
FS: 00007f9f791576c0(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b30823000 CR3: 000000002e298000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess), 1 bytes skipped:
0: 18 48 89 sbb %cl,-0x77(%rax)
3: e8 48 c1 e8 03 call 0x3e8c150
8: 42 80 3c 30 00 cmpb $0x0,(%rax,%r14,1)
d: 74 08 je 0x17
f: 48 89 ef mov %rbp,%rdi
12: e8 b2 10 3a 00 call 0x3a10c9
17: 48 8b 5d 00 mov 0x0(%rbp),%rbx
1b: 49 8d af d8 01 00 00 lea 0x1d8(%r15),%rbp
22: 48 89 e8 mov %rbp,%rax
25: 48 c1 e8 03 shr $0x3,%rax
* 29: 42 0f b6 04 30 movzbl (%rax,%r14,1),%eax <-- trapping instruction
2e: 84 c0 test %al,%al
30: 0f 85 3a 02 00 00 jne 0x270
36: 8b 6d 00 mov 0x0(%rbp),%ebp
39: 89 ee mov %ebp,%esi
3b: 83 e6 04 and $0x4,%esi
3e: 31 .byte 0x31
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2)
2024-05-27 0:44 [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2) syzbot
@ 2024-06-09 11:34 ` syzbot
2024-08-31 20:55 ` syzbot
1 sibling, 0 replies; 5+ messages in thread
From: syzbot @ 2024-06-09 11:34 UTC (permalink / raw)
To: andrii, ast, bpf, daniel, davem, eddyz87, haoluo, hawk,
john.fastabend, jolsa, kpsingh, kuba, linux-kernel, martin.lau,
netdev, sdf, song, syzkaller-bugs, yonghong.song
syzbot has found a reproducer for the following issue on:
HEAD commit: c44711b78608 liquidio: Adjust a NULL pointer handling path..
git tree: net
console+strace: https://syzkaller.appspot.com/x/log.txt?x=1175e6f6980000
kernel config: https://syzkaller.appspot.com/x/.config?x=333ebe38d43c42e2
dashboard link: https://syzkaller.appspot.com/bug?extid=cca39e6e84a367a7e6f6
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=172b3126980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17caa30a980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/47ff53e982e7/disk-c44711b7.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/7b10dcb52f35/vmlinux-c44711b7.xz
kernel image: https://storage.googleapis.com/syzbot-assets/b4a6bf6f87c5/bzImage-c44711b7.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cca39e6e84a367a7e6f6@syzkaller.appspotmail.com
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN PTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 1 PID: 5098 Comm: syz-executor784 Not tainted 6.10.0-rc2-syzkaller-00228-gc44711b78608 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
RIP: 0010:dev_map_enqueue+0x31/0x3e0 kernel/bpf/devmap.c:539
Code: 41 56 41 55 41 54 53 48 83 ec 18 49 89 d4 49 89 f5 48 89 fd 49 be 00 00 00 00 00 fc ff df e8 46 9c d7 ff 48 89 e8 48 c1 e8 03 <42> 80 3c 30 00 74 08 48 89 ef e8 a0 5e 3d 00 4c 8b 7d 00 48 83 c5
RSP: 0018:ffffc9000343f678 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff88807eb31e00
RDX: 0000000000000000 RSI: ffff88802224a070 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff89625806 R09: ffffffff896257c3
R10: 0000000000000004 R11: ffff88807eb31e00 R12: ffff8880151d8000
R13: ffff88802224a070 R14: dffffc0000000000 R15: 0000000000000000
FS: 00005555867d5380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fdc79c59303 CR3: 0000000022bc8000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__xdp_do_redirect_frame net/core/filter.c:4397 [inline]
xdp_do_redirect_frame+0x2a6/0x660 net/core/filter.c:4451
xdp_test_run_batch net/bpf/test_run.c:336 [inline]
bpf_test_run_xdp_live+0xe60/0x1e60 net/bpf/test_run.c:384
bpf_prog_test_run_xdp+0x80e/0x11b0 net/bpf/test_run.c:1281
bpf_prog_test_run+0x33a/0x3b0 kernel/bpf/syscall.c:4292
__sys_bpf+0x48d/0x810 kernel/bpf/syscall.c:5706
__do_sys_bpf kernel/bpf/syscall.c:5795 [inline]
__se_sys_bpf kernel/bpf/syscall.c:5793 [inline]
__x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5793
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fdc79c5b239
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff5780f908 EFLAGS: 00000246 ORIG_RAX: 0000000000000141
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fdc79c5b239
RDX: 0000000000000050 RSI: 0000000020000240 RDI: 000000000000000a
RBP: 0000000000000000 R08: 0000000000000006 R09: 0000000000000006
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000001 R15: 0000000000000001
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:dev_map_enqueue+0x31/0x3e0 kernel/bpf/devmap.c:539
Code: 41 56 41 55 41 54 53 48 83 ec 18 49 89 d4 49 89 f5 48 89 fd 49 be 00 00 00 00 00 fc ff df e8 46 9c d7 ff 48 89 e8 48 c1 e8 03 <42> 80 3c 30 00 74 08 48 89 ef e8 a0 5e 3d 00 4c 8b 7d 00 48 83 c5
RSP: 0018:ffffc9000343f678 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff88807eb31e00
RDX: 0000000000000000 RSI: ffff88802224a070 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff89625806 R09: ffffffff896257c3
R10: 0000000000000004 R11: ffff88807eb31e00 R12: ffff8880151d8000
R13: ffff88802224a070 R14: dffffc0000000000 R15: 0000000000000000
FS: 00005555867d5380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fdc79c59303 CR3: 0000000022bc8000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: 41 56 push %r14
2: 41 55 push %r13
4: 41 54 push %r12
6: 53 push %rbx
7: 48 83 ec 18 sub $0x18,%rsp
b: 49 89 d4 mov %rdx,%r12
e: 49 89 f5 mov %rsi,%r13
11: 48 89 fd mov %rdi,%rbp
14: 49 be 00 00 00 00 00 movabs $0xdffffc0000000000,%r14
1b: fc ff df
1e: e8 46 9c d7 ff call 0xffd79c69
23: 48 89 e8 mov %rbp,%rax
26: 48 c1 e8 03 shr $0x3,%rax
* 2a: 42 80 3c 30 00 cmpb $0x0,(%rax,%r14,1) <-- trapping instruction
2f: 74 08 je 0x39
31: 48 89 ef mov %rbp,%rdi
34: e8 a0 5e 3d 00 call 0x3d5ed9
39: 4c 8b 7d 00 mov 0x0(%rbp),%r15
3d: 48 rex.W
3e: 83 .byte 0x83
3f: c5 .byte 0xc5
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2)
2024-05-27 0:44 [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2) syzbot
2024-06-09 11:34 ` syzbot
@ 2024-08-31 20:55 ` syzbot
2024-09-02 8:02 ` Sebastian Andrzej Siewior
1 sibling, 1 reply; 5+ messages in thread
From: syzbot @ 2024-08-31 20:55 UTC (permalink / raw)
To: alexei.starovoitov, andrii, ast, bigeasy, bpf, daniel, davem,
eddyz87, haoluo, hawk, john.fastabend, jolsa, kpsingh, kuba,
linux-kernel, martin.lau, michal.switala, netdev, revest, sdf,
sdf, song, syzkaller-bugs, toke, yonghong.song
syzbot suspects this issue was fixed by commit:
commit 401cb7dae8130fd34eb84648e02ab4c506df7d5e
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: Thu Jun 20 13:22:04 2024 +0000
net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12597c63980000
start commit: 36534d3c5453 tcp: use signed arithmetic in tcp_rtx_probe0_..
git tree: bpf
kernel config: https://syzkaller.appspot.com/x/.config?x=333ebe38d43c42e2
dashboard link: https://syzkaller.appspot.com/bug?extid=cca39e6e84a367a7e6f6
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13390aea980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10948741980000
If the result looks correct, please mark the issue as fixed by replying with:
#syz fix: net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2)
2024-08-31 20:55 ` syzbot
@ 2024-09-02 8:02 ` Sebastian Andrzej Siewior
2024-09-20 11:18 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2024-09-02 8:02 UTC (permalink / raw)
To: syzbot
Cc: alexei.starovoitov, andrii, ast, bpf, daniel, davem, eddyz87,
haoluo, hawk, john.fastabend, jolsa, kpsingh, kuba, linux-kernel,
martin.lau, michal.switala, netdev, revest, sdf, sdf, song,
syzkaller-bugs, toke, yonghong.song
On 2024-08-31 13:55:02 [-0700], syzbot wrote:
> syzbot suspects this issue was fixed by commit:
>
> commit 401cb7dae8130fd34eb84648e02ab4c506df7d5e
> Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Date: Thu Jun 20 13:22:04 2024 +0000
>
> net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12597c63980000
> start commit: 36534d3c5453 tcp: use signed arithmetic in tcp_rtx_probe0_..
> git tree: bpf
> kernel config: https://syzkaller.appspot.com/x/.config?x=333ebe38d43c42e2
> dashboard link: https://syzkaller.appspot.com/bug?extid=cca39e6e84a367a7e6f6
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13390aea980000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10948741980000
This looks like ri->tgt_value is a NULL pointer (dst in
dev_map_enqueue()). The commit referenced by syz should not have fixed
that.
It is possible that there were leftovers in bpf_redirect_info (from a
previous invocation) which were memset(,0,) during the switch from
per-CPU to stack usage and now it does not trigger anymore.
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2)
2024-09-02 8:02 ` Sebastian Andrzej Siewior
@ 2024-09-20 11:18 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 5+ messages in thread
From: Toke Høiland-Jørgensen @ 2024-09-20 11:18 UTC (permalink / raw)
To: Sebastian Andrzej Siewior, syzbot
Cc: alexei.starovoitov, andrii, ast, bpf, daniel, davem, eddyz87,
haoluo, hawk, john.fastabend, jolsa, kpsingh, kuba, linux-kernel,
martin.lau, michal.switala, netdev, revest, sdf, sdf, song,
syzkaller-bugs, yonghong.song
Sebastian Andrzej Siewior <bigeasy@linutronix.de> writes:
> On 2024-08-31 13:55:02 [-0700], syzbot wrote:
>> syzbot suspects this issue was fixed by commit:
>>
>> commit 401cb7dae8130fd34eb84648e02ab4c506df7d5e
>> Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>> Date: Thu Jun 20 13:22:04 2024 +0000
>>
>> net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.
>>
>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12597c63980000
>> start commit: 36534d3c5453 tcp: use signed arithmetic in tcp_rtx_probe0_..
>> git tree: bpf
>> kernel config: https://syzkaller.appspot.com/x/.config?x=333ebe38d43c42e2
>> dashboard link: https://syzkaller.appspot.com/bug?extid=cca39e6e84a367a7e6f6
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13390aea980000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10948741980000
>
> This looks like ri->tgt_value is a NULL pointer (dst in
> dev_map_enqueue()). The commit referenced by syz should not have fixed
> that.
> It is possible that there were leftovers in bpf_redirect_info (from a
> previous invocation) which were memset(,0,) during the switch from
> per-CPU to stack usage and now it does not trigger anymore.
Yes, I believe you are right. AFAICT, the original issue stems from the
SKB path and XDP path using the same numeric flag values in the
ri->flags field (specifically, BPF_F_BROADCAST == BPF_F_NEXTHOP). So if
bpf_redirect_neigh() was used and subsequently, an XDP redirect was
performed using the same bpf_redirect_info struct, the XDP path would
get confused and end up crashing. Now, with the stack-allocated
bpf_redirect_info, this sharing can no longer happen, so the crash
doesn't happen anymore.
However, different code paths using identically-numbered flag values
in the same struct field still seems like a bit of a mess, so I'll send
a patch to fix this just to be safe in case we ever move back to sharing
this data structure.
-Toke
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-20 11:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 0:44 [syzbot] [bpf?] [net?] general protection fault in dev_map_enqueue (2) syzbot
2024-06-09 11:34 ` syzbot
2024-08-31 20:55 ` syzbot
2024-09-02 8:02 ` Sebastian Andrzej Siewior
2024-09-20 11:18 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).