From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 984E7143C4D for ; Fri, 26 Apr 2024 11:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714132775; cv=none; b=XbEAXZ4RDtGyv17yixASHEeLTj77yrwPs9Bc6yVwDT+jnySzzIwMtQsoCIm4A0n23tBwu6Dxwko0x6uhwmUOcjT+6vUmhplNMZ34KJ0MszLFpLPO/ElbeThED2b0PquzwHl1J+9roQWM3gBhrqzasCBk+ucvfJtIzPeRKaQqNMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714132775; c=relaxed/simple; bh=JBuZy1bt/9FILwIZSnflDr8oLiXFVxcY2jMoj+aEbPg=; h=MIME-Version:Date:Message-ID:Subject:From:To:Content-Type; b=Fn7lc0E9vrQMBUAM6OahSxMAq39MLY36T3cBhsHyuF0PhS7UQaLeGf3qZy/Ir/tt4/p4rtLofyl8b9hiQtZ72521oQPVAdbxOx+c14y+hOg6U9A0qAzZBrnsZlL7IerLeiJNzTkVysNgNnddD13k6lW6JAz6/Iv4JqHkG7HYQz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-io1-f69.google.com with SMTP id ca18e2360f4ac-7dd8cd201d6so206287639f.0 for ; Fri, 26 Apr 2024 04:59:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714132773; x=1714737573; h=to:from:subject:message-id:date:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=r0erjBV+MLY5PdUBoIMW0OzfOzBuRXn3QcsfoGqGHBM=; b=tPiRwYR8ycQ+3SXhrS7gt42M4WOZ0dL7QuIMsUg4c7R/9eUailC23YnWbfZu3+qy38 fcnz/wjlj3hAdzdTK1waqY1kboNkfK+PvKzx1p7ALH61IgL+pscGKMutZtV4tq11vJ/7 n7pehE/I+0fZNjXSPdGzd8lwadYl9MpDLIwg9PZyLbrAjKVILoL6tN5jOsGRfIQNiHxz QT2sNqiW1p5Wz68Tyd39x1ugM89gH5PUTmPH5w4Wcyx3z/G9fqRNHXxKlbpPsU89R+PV kpJuxhQlvyPPH1FyNYgiMyoe6bdkcK104otezH70D13uLdIIdKvVLBpxCgW5Yq8gqHrc E5XA== X-Forwarded-Encrypted: i=1; AJvYcCXkvsOm4y6+wBavvOBjNsSXmP4Bo24+aHo9NFi0+tbSeVRcNI3junhxAEaJbJYMVlIo13okcj7PifR1E0T+KtT3qz8lDOpJ X-Gm-Message-State: AOJu0YxBsoaKj5zBUB5jxThB3bFUly1BqfHPlrMB4GbVbNGMn2Fg1DNi Egqr5UoZRmWhXs6sC7pfgbWBNCAKO9sBTH4sCHm7RYB6xZAAEY2NCVM+k4Fpfw5VQSIU3zDeamq avPpP2DCIlhnKA5HzTNJISgnosGDpPDC41IPVaKkwWXscRH+UT/LKwWw= X-Google-Smtp-Source: AGHT+IGwUhYLW/IXtUriZ2Njd4fLqjpzT8wYDq6WGdz+06ws02CRkBM+iwUxX3fMQdj1rYO4h6ScgGkvHDpn9DOhKhxIva5xBOVS Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6638:860f:b0:487:ce7:2c63 with SMTP id iu15-20020a056638860f00b004870ce72c63mr233069jab.3.1714132772433; Fri, 26 Apr 2024 04:59:32 -0700 (PDT) Date: Fri, 26 Apr 2024 04:59:32 -0700 X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <000000000000ffc5d80616fea23d@google.com> Subject: [syzbot] [net?] possible deadlock in team_del_slave (3) From: syzbot To: davem@davemloft.net, edumazet@google.com, jiri@resnulli.us, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Hello, syzbot found the following issue on: HEAD commit: 480e035fc4c7 Merge tag 'drm-next-2024-03-13' of https://gi.. git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=1662179e180000 kernel config: https://syzkaller.appspot.com/x/.config?x=1e5b814e91787669 dashboard link: https://syzkaller.appspot.com/bug?extid=705c61d60b091ef42c04 compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1058e7b9180000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11919365180000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/5f73b6ef963d/disk-480e035f.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/46c949396aad/vmlinux-480e035f.xz kernel image: https://storage.googleapis.com/syzbot-assets/e3b4d0f5a5f8/bzImage-480e035f.xz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+705c61d60b091ef42c04@syzkaller.appspotmail.com ====================================================== WARNING: possible circular locking dependency detected 6.8.0-syzkaller-08073-g480e035fc4c7 #0 Not tainted ------------------------------------------------------ syz-executor419/5074 is trying to acquire lock: ffff888023dc4d20 (team->team_lock_key){+.+.}-{3:3}, at: team_del_slave+0x32/0x1d0 drivers/net/team/team.c:1988 but task is already holding lock: ffff88802a210768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0x11a/0x140 net/wireless/nl80211.c:4389 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&rdev->wiphy.mtx){+.+.}-{3:3}: lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 wiphy_lock include/net/cfg80211.h:5951 [inline] ieee80211_open+0xe7/0x200 net/mac80211/iface.c:449 __dev_open+0x2d3/0x450 net/core/dev.c:1430 dev_open+0xae/0x1b0 net/core/dev.c:1466 team_port_add drivers/net/team/team.c:1214 [inline] team_add_slave+0x9b3/0x2750 drivers/net/team/team.c:1974 do_set_master net/core/rtnetlink.c:2685 [inline] do_setlink+0xe70/0x41f0 net/core/rtnetlink.c:2891 rtnl_setlink+0x40d/0x5a0 net/core/rtnetlink.c:3185 rtnetlink_rcv_msg+0x89b/0x10d0 net/core/rtnetlink.c:6595 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2559 netlink_unicast_kernel net/netlink/af_netlink.c:1335 [inline] netlink_unicast+0x7ea/0x980 net/netlink/af_netlink.c:1361 netlink_sendmsg+0x8e1/0xcb0 net/netlink/af_netlink.c:1905 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x221/0x270 net/socket.c:745 ____sys_sendmsg+0x525/0x7d0 net/socket.c:2584 ___sys_sendmsg net/socket.c:2638 [inline] __sys_sendmsg+0x2b0/0x3a0 net/socket.c:2667 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 -> #0 (team->team_lock_key){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 team_del_slave+0x32/0x1d0 drivers/net/team/team.c:1988 team_device_event+0x200/0x5b0 drivers/net/team/team.c:3029 notifier_call_chain+0x18f/0x3b0 kernel/notifier.c:93 call_netdevice_notifiers_extack net/core/dev.c:1988 [inline] call_netdevice_notifiers net/core/dev.c:2002 [inline] unregister_netdevice_many_notify+0xd96/0x16d0 net/core/dev.c:11096 unregister_netdevice_many net/core/dev.c:11154 [inline] unregister_netdevice_queue+0x303/0x370 net/core/dev.c:11033 unregister_netdevice include/linux/netdevice.h:3115 [inline] _cfg80211_unregister_wdev+0x162/0x560 net/wireless/core.c:1206 ieee80211_if_remove+0x25d/0x3a0 net/mac80211/iface.c:2242 ieee80211_del_iface+0x19/0x30 net/mac80211/cfg.c:202 rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline] cfg80211_remove_virtual_intf+0x230/0x3f0 net/wireless/util.c:2847 genl_family_rcv_msg_doit net/netlink/genetlink.c:1113 [inline] genl_family_rcv_msg net/netlink/genetlink.c:1193 [inline] genl_rcv_msg+0xb14/0xec0 net/netlink/genetlink.c:1208 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2559 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1217 netlink_unicast_kernel net/netlink/af_netlink.c:1335 [inline] netlink_unicast+0x7ea/0x980 net/netlink/af_netlink.c:1361 netlink_sendmsg+0x8e1/0xcb0 net/netlink/af_netlink.c:1905 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x221/0x270 net/socket.c:745 ____sys_sendmsg+0x525/0x7d0 net/socket.c:2584 ___sys_sendmsg net/socket.c:2638 [inline] __sys_sendmsg+0x2b0/0x3a0 net/socket.c:2667 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rdev->wiphy.mtx); lock(team->team_lock_key); lock(&rdev->wiphy.mtx); lock(team->team_lock_key); *** DEADLOCK *** 3 locks held by syz-executor419/5074: #0: ffffffff8f3f1a30 (cb_lock){++++}-{3:3}, at: genl_rcv+0x19/0x40 net/netlink/genetlink.c:1216 #1: ffffffff8f38ce88 (rtnl_mutex){+.+.}-{3:3}, at: nl80211_pre_doit+0x5f/0x8b0 net/wireless/nl80211.c:16401 #2: ffff88802a210768 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0x11a/0x140 net/wireless/nl80211.c:4389 stack backtrace: CPU: 1 PID: 5074 Comm: syz-executor419 Not tainted 6.8.0-syzkaller-08073-g480e035fc4c7 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 team_del_slave+0x32/0x1d0 drivers/net/team/team.c:1988 team_device_event+0x200/0x5b0 drivers/net/team/team.c:3029 notifier_call_chain+0x18f/0x3b0 kernel/notifier.c:93 call_netdevice_notifiers_extack net/core/dev.c:1988 [inline] call_netdevice_notifiers net/core/dev.c:2002 [inline] unregister_netdevice_many_notify+0xd96/0x16d0 net/core/dev.c:11096 unregister_netdevice_many net/core/dev.c:11154 [inline] unregister_netdevice_queue+0x303/0x370 net/core/dev.c:11033 unregister_netdevice include/linux/netdevice.h:3115 [inline] _cfg80211_unregister_wdev+0x162/0x560 net/wireless/core.c:1206 ieee80211_if_remove+0x25d/0x3a0 net/mac80211/iface.c:2242 ieee80211_del_iface+0x19/0x30 net/mac80211/cfg.c:202 rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline] cfg80211_remove_virtual_intf+0x230/0x3f0 net/wireless/util.c:2847 genl_family_rcv_msg_doit net/netlink/genetlink.c:1113 [inline] genl_family_rcv_msg net/netlink/genetlink.c:1193 [inline] genl_rcv_msg+0xb14/0xec0 net/netlink/genetlink.c:1208 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2559 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1217 netlink_unicast_kernel net/netlink/af_netlink.c:1335 [inline] netlink_unicast+0x7ea/0x980 net/netlink/af_netlink.c:1361 netlink_sendmsg+0x8e1/0xcb0 net/netlink/af_netlink.c:1905 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x221/0x270 net/socket.c:745 ____sys_sendmsg+0x525/0x7d0 net/socket.c:2584 ___sys_sendmsg net/socket.c:2638 [inline] __sys_sendmsg+0x2b0/0x3a0 net/socket.c:2667 do_syscall_64+0xfb/0x240 entry_SYSCALL_64_after_hwframe+0x6d/0x75 RIP: 0033:0x7f963cb981a9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 d1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffdde1419a8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007f963cbe53f6 RCX: 00007f963cb981a9 RDX: 0000000000000000 RSI: 0000000020000400 RDI: 0000000000000004 RBP: 00007f963cc17440 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000031 R13: 0000000000000003 R14: 0000000000050012 R15: 00007ffdde141a02 team0: Port device wlan0 removed --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. If the report is already addressed, let syzbot know by replying with: #syz fix: exact-commit-title If you want syzbot to run the reproducer, reply with: #syz test: git://repo/address.git branch-or-commit-hash If you attach or paste a git patch, syzbot will apply it before testing. If you want to overwrite report's subsystems, reply with: #syz set subsystems: new-subsystem (See the list of subsystem names on the web dashboard) If the report is a duplicate of another one, reply with: #syz dup: exact-subject-of-another-report If you want to undo deduplication, reply with: #syz undup