Netdev List
 help / color / mirror / Atom feed
From: "Joonwoo Park" <joonwpark81@gmail.com>
To: "'Jay Cliburn'" <jacliburn@bellsouth.net>
Cc: <jeff@garzik.org>, <csnook@redhat.com>,
	<linux-kernel@vger.kernel.org>,
	<atl1-devel@lists.sourceforge.net>, <netdev@vger.kernel.org>,
	<shemminger@linux-foundation.org>
Subject: RE: [PATCH 25/26] [REVISED] atl1: add NAPI support
Date: Wed, 2 Jan 2008 11:56:36 +0900	[thread overview]
Message-ID: <000001c84ceb$18a967c0$47e7a8c0@jason> (raw)
In-Reply-To: <20080101121536.3df9c497@osprey.hogchain.net>

Hi Jay,

+	if ((work_done < budget) || !netif_running(poll_dev)) {
+quit_polling:
+		netif_rx_complete(poll_dev, napi);
+
+		if (!test_bit(__ATL1_DOWN, &adapter->flags))
+			atlx_irq_enable(adapter);
+	}

Not enough :)
If netif_running() is false, it can make problem.
The problem occurs calling netif_rx_complete with work_done == budget.
If do that, net_rx_action would do poll list double deletion.

Since we had reached a consensus on fixing it without each drivers modifications, there is no best solution for that problem for
now. I'm expecting Dave or others work for net-core.
(http://lkml.org/lkml/2007/12/20/600)

IMHO, atl1_clean should wait for work_done != budget even though netif_running is false at this time.
At least, It would not make oops.

Thanks,
Joonwoo


  reply	other threads:[~2008-01-02  2:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1199152804-3889-1-git-send-email-jacliburn@bellsouth.net>
     [not found] ` <1199152804-3889-26-git-send-email-jacliburn@bellsouth.net>
2008-01-01 18:15   ` [PATCH 25/26] [REVISED] atl1: add NAPI support Jay Cliburn
2008-01-02  2:56     ` Joonwoo Park [this message]
2008-01-02  3:07       ` David Miller
     [not found] ` <1199152804-3889-10-git-send-email-jacliburn@bellsouth.net>
     [not found]   ` <4795BE39.6000505@garzik.org>
2008-01-23  0:31     ` [PATCH 09/26] atl1: refactor tx processing Jay Cliburn
2008-01-25  1:00       ` Jay Cliburn
2008-01-25  1:08         ` Chris Snook
2008-01-25  3:01         ` Jeff Garzik
     [not found] ` <1199152804-3889-7-git-send-email-jacliburn@bellsouth.net>
     [not found]   ` <4795BDBB.10904@garzik.org>
2008-01-23  2:13     ` [PATCH 06/26] atl1: update initialization parameters Jay Cliburn
2008-01-23  2:19       ` Jeff Garzik
2008-01-23  2:30       ` Chris Snook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001c84ceb$18a967c0$47e7a8c0@jason' \
    --to=joonwpark81@gmail.com \
    --cc=atl1-devel@lists.sourceforge.net \
    --cc=csnook@redhat.com \
    --cc=jacliburn@bellsouth.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox