From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: <andy.shevchenko@gmail.com>
Cc: <netdev@vger.kernel.org>, <jarkko.nikula@linux.intel.com>,
<andriy.shevchenko@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <jsd@semihalf.com>,
<Jose.Abreu@synopsys.com>, <andrew@lunn.ch>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<linux-i2c@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<mengyuanlou@net-swift.com>
Subject: RE: [RFC PATCH net-next v6 2/9] i2c: designware: Add driver support for Wangxun 10Gb NIC
Date: Sat, 6 May 2023 17:29:15 +0800 [thread overview]
Message-ID: <000001d97ffd$39ae2db0$ad0a8910$@trustnetic.com> (raw)
In-Reply-To: <ZFViufP6qh79C1-T@surfacebook>
On Saturday, May 6, 2023 4:11 AM, andy.shevchenko@gmail.com wrote:
> Fri, May 05, 2023 at 09:48:01PM +0300, andy.shevchenko@gmail.com kirjoitti:
> > Fri, May 05, 2023 at 03:42:21PM +0800, Jiawen Wu kirjoitti:
>
> ...
>
> > > + device_property_read_u32(&pdev->dev, "wx,i2c-snps-model", &dev->flags);
> >
> > I believe in your case it should be named something like
> > "linux,i2c-synopsys-platform". But in any case this I leave
> > to the more experienced people.
>
> Or "snps,i2c-platform", I dunno...
I thought you wanted me to introduce a property specific to my device,
so I named it "wx,...". But if it's a universal property for platform device,
maybe it's necessary to check if flag is NULL, otherwise the second result
will overwrite it.
next prev parent reply other threads:[~2023-05-06 9:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 7:42 [RFC PATCH net-next v6 0/9] TXGBE PHYLINK support Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 1/9] net: txgbe: Add software nodes to support phylink Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 2/9] i2c: designware: Add driver support for Wangxun 10Gb NIC Jiawen Wu
2023-05-05 18:48 ` andy.shevchenko
2023-05-05 20:10 ` andy.shevchenko
2023-05-06 9:29 ` Jiawen Wu [this message]
2023-05-06 11:34 ` Andy Shevchenko
2023-05-05 7:42 ` [RFC PATCH net-next v6 3/9] net: txgbe: Register fixed rate clock Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 4/9] net: txgbe: Register I2C platform device Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 5/9] net: txgbe: Add SFP module identify Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 6/9] net: txgbe: Support GPIO to SFP socket Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 7/9] net: pcs: Add 10GBASE-R mode for Synopsys Designware XPCS Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 8/9] net: txgbe: Implement phylink pcs Jiawen Wu
2023-05-05 7:42 ` [RFC PATCH net-next v6 9/9] net: txgbe: Support phylink MAC layer Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d97ffd$39ae2db0$ad0a8910$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).