From: Gur Stavi <gur.stavi@huawei.com>
To: 'Jakub Kicinski' <kuba@kernel.org>
Cc: "Gongfan (Eric, Chip)" <gongfan1@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
"Guoxin (D)" <guoxin09@huawei.com>,
shenchenyang <shenchenyang1@hisilicon.com>,
"zhoushuai (A)" <zhoushuai28@huawei.com>,
"Wulike (Collin)" <wulike1@huawei.com>,
"shijing (A)" <shijing34@huawei.com>,
Meny Yossefi <meny.yossefi@huawei.com>
Subject: RE: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC
Date: Sun, 3 Nov 2024 14:29:27 +0200 [thread overview]
Message-ID: <000001db2dec$10d92680$328b7380$@huawei.com> (raw)
In-Reply-To: <20241031193523.09f63a7e@kernel.org>
> On Wed, 30 Oct 2024 14:25:47 +0200 Gur Stavi wrote:
> > 50 files changed, 18058 insertions(+)
>
> 4kLoC is the right ballpark to target for the initial submission.
> Please cut this down and submit a minimal driver, then add the
> features.
Ack.
There is indeed code which is not critical to basic Ethernet functionality
that can be postponed to later.
Our HW management infrastructure is rather large and contains 2 separate
mechanisms (cmdq+mbox). While I hope we can trim the driver to a VF-only
version with no ethtool support that will fit the 10KLoC ballpark, the 4KLoC
goal is probably unrealistic for a functional driver.
Is it valid to submit a non-functional kernel module and make it functional
with follow-up submissions? For example:
Submission 1: TX+RX logic
Submission 2: Device management infrastructure
Submission 3: PCI device registration and netdev creation
Some initial submission cases we studied before our submission:
Amazon/ena: 10858 insertions
https://lore.kernel.org/netdev/1470827002-23081-1-git-send-email-netanel@ann
apurnalabs.com/
Microsoft/mana: 6168 insertions
https://lore.kernel.org/netdev/20210416060705.21998-1-decui@microsoft.com/
Huawei/hinic: 12728 insertions
https://lore.kernel.org/netdev/cover.1503330613.git.aviad.krawczyk@huawei.co
m/
next prev parent reply other threads:[~2024-11-03 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:25 [RFC net-next v01 0/1] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2024-10-30 12:25 ` [RFC net-next v01 1/1] " Gur Stavi
2024-11-01 2:35 ` Jakub Kicinski
2024-11-03 12:29 ` Gur Stavi [this message]
2024-11-03 18:54 ` Andrew Lunn
2024-11-03 20:17 ` Gur Stavi
2024-11-03 21:19 ` Andrew Lunn
2024-11-03 22:19 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001db2dec$10d92680$328b7380$@huawei.com' \
--to=gur.stavi@huawei.com \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).