* [PATCH V2 4/4] net: wan: remove unnecessary platform_set_drvdata()
@ 2013-05-28 5:08 Jingoo Han
2013-05-28 5:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-28 5:08 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, Jingoo Han, 'Krzysztof Halasa'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/ixp4xx_hss.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
index fc9d11d..e7bbdb7 100644
--- a/drivers/net/wan/ixp4xx_hss.c
+++ b/drivers/net/wan/ixp4xx_hss.c
@@ -1384,7 +1384,6 @@ static int hss_remove_one(struct platform_device *pdev)
unregister_hdlc_device(port->netdev);
free_netdev(port->netdev);
npe_release(port->npe);
- platform_set_drvdata(pdev, NULL);
kfree(port);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2 4/4] net: wan: remove unnecessary platform_set_drvdata()
2013-05-28 5:08 [PATCH V2 4/4] net: wan: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-28 5:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-28 5:40 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, khc
From: Jingoo Han <jg1.han@samsung.com>
Date: Tue, 28 May 2013 14:08:17 +0900
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-28 5:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-28 5:08 [PATCH V2 4/4] net: wan: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-28 5:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).