From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Prashant Bhole" <bhole_prashant_q7@lab.ntt.co.jp>
Subject: RE: [PATCH net-next] netdevsim: check return value of debugfs_create_dir
Date: Thu, 7 Dec 2017 13:10:39 +0900
Message-ID: <000401d36f11$577e2b90$067a82b0$@lab.ntt.co.jp>
References: <20171207010213.4792-1-bhole_prashant_q7@lab.ntt.co.jp> <20171206183341.00175b36@cakuba.netronome.com>
Mime-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: "'David S . Miller'" <davem@davemloft.net>,
        <netdev@vger.kernel.org>
To: "'Jakub Kicinski'" <jakub.kicinski@netronome.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:34646 "EHLO
        tama50.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752142AbdLGEMC (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 6 Dec 2017 23:12:02 -0500
In-Reply-To: <20171206183341.00175b36@cakuba.netronome.com>
Content-Language: en-us
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


> From: Jakub Kicinski [mailto:jakub.kicinski@netronome.com]
> 
> On Thu,  7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote:
> > - Handled debugfs_create_dir failure in nsim_init()
> > - Fixed return value of nsim_module_init() when debugfs_create_dir
> > fails
> >
> > Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> 
> Why?  Failing to expose the state via DebugFS is not fatal to the driver.

Ok, my intention was to handle the return code properly, which is not needed
as per your comment.
Shall I remove the existing handling in nsim_module_init() in separate
patch?  Because it will prevent netdevsim from loading when debugfs is
disabled.

Thanks,
Prashant