From: Byungho An <bh74.an@samsung.com>
To: 'Jingoo Han' <jg1.han@samsung.com>,
netdev@vger.kernel.org, 'David Miller' <davem@davemloft.net>
Cc: 'Girish K S' <ks.giri@samsung.com>,
'Siva Reddy Kallam' <siva.kallam@samsung.com>,
'Vipul Pandya' <vipul.pandya@samsung.com>
Subject: RE: [PATCH] net: sxgbe: make local functions static
Date: Fri, 18 Apr 2014 20:35:33 +0900 [thread overview]
Message-ID: <000501cf5afa$4f401f80$edc05e80$%an@samsung.com> (raw)
In-Reply-To: <004401cf5a25$bc8ed200$35ac7600$%han@samsung.com>
Jingoo Han wrote:
>
> Make local functions static, because these are used only in this
> file.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Byungho An <bh74.an@samsung.com>
> ---
> drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> index a72688e..dbb0abb 100644
> --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
> @@ -425,8 +425,8 @@ dmamem_err:
> * @rx_rsize: ring size
> * Description: this function initializes the DMA RX descriptor
> */
> -void free_rx_ring(struct device *dev, struct sxgbe_rx_queue *rx_ring,
> - int rx_rsize)
> +static void free_rx_ring(struct device *dev, struct sxgbe_rx_queue
> *rx_ring,
> + int rx_rsize)
> {
> dma_free_coherent(dev, rx_rsize * sizeof(struct sxgbe_rx_norm_desc),
> rx_ring->dma_rx, rx_ring->dma_rx_phy);
> @@ -519,8 +519,8 @@ error:
> * @tx_rsize: ring size
> * Description: this function initializes the DMA TX descriptor
> */
> -void free_tx_ring(struct device *dev, struct sxgbe_tx_queue *tx_ring,
> - int tx_rsize)
> +static void free_tx_ring(struct device *dev, struct sxgbe_tx_queue
> *tx_ring,
> + int tx_rsize)
> {
> dma_free_coherent(dev, tx_rsize * sizeof(struct sxgbe_tx_norm_desc),
> tx_ring->dma_tx, tx_ring->dma_tx_phy);
> @@ -1218,11 +1218,10 @@ static int sxgbe_release(struct net_device *dev)
>
> return 0;
> }
> -
> /* Prepare first Tx descriptor for doing TSO operation */
> -void sxgbe_tso_prepare(struct sxgbe_priv_data *priv,
> - struct sxgbe_tx_norm_desc *first_desc,
> - struct sk_buff *skb)
> +static void sxgbe_tso_prepare(struct sxgbe_priv_data *priv,
> + struct sxgbe_tx_norm_desc *first_desc,
> + struct sk_buff *skb)
> {
> unsigned int total_hdr_len, tcp_hdr_len;
>
> --
> 1.7.10.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-18 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 10:13 [PATCH] net: sxgbe: make local functions static Jingoo Han
2014-04-18 11:35 ` Byungho An [this message]
2014-04-20 22:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501cf5afa$4f401f80$edc05e80$%an@samsung.com' \
--to=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=jg1.han@samsung.com \
--cc=ks.giri@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=siva.kallam@samsung.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).