From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386342571A7 for ; Wed, 19 Mar 2025 12:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742387431; cv=none; b=iVkt452qt5F9FiIdz6mj+8Jv3TK1Y2LGBihJlWTJFGmCmqFGjTro5+DeQ4rYmgoWVSqlqeBA6JRSiV8May2B/CtOxQuaQir8a2j+J82nedDAWtX5iSKO2HjPZPTojKrfF7Jn11/7eWe4Mfp11iCjV4hfKgF9N+rbN3nX8FljsA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742387431; c=relaxed/simple; bh=r+yvknpWT7YSh9LWAzi7AELE+HiHlP2N0ABv5fArup0=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=JODU10E+24ssVHb6tW9eMe89lCa1CVxHDufBkDBparlSCikP5X0mxBrjJwfy59iVvSnsJfe1aK2NGp0b1JYv01ljLPdWRHMin0Ty32OJrJf892LiXivS60/OCS5BzxlwP23U3lUa9bsyJVe5OfQePbuFQG6+Rueopw/bLnd1mjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=Rl8aOkvn; arc=none smtp.client-ip=203.254.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="Rl8aOkvn" Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20250319123022epoutp04bf9e88f174a54ea3cc37d5568c811521~uNCEJfMKR0115001150epoutp04j for ; Wed, 19 Mar 2025 12:30:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20250319123022epoutp04bf9e88f174a54ea3cc37d5568c811521~uNCEJfMKR0115001150epoutp04j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1742387422; bh=gD9Sr1WH7oBqjVnHxW56qgptKH/950gTsxbz1DfjlQM=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=Rl8aOkvn+agBf3Si2cNbj5uHQltdw+RkuuilkWCOLKgzu0+wiMeYmGT2054frQc3I RyxJJpO3r242d46ePvwt2XhSxU0wJ15iF3Qa4ql7GdQ7Y4Aem3hdNiH8Zf89vc/JPB RQ4nvBjRm06gDvTCcir3UkKhr1tSmgIiDjchDA1o= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas5p2.samsung.com (KnoxPortal) with ESMTP id 20250319123021epcas5p25c3c94b54fe3fbc4768f981d3fcfa202~uNCDb804K0839608396epcas5p2i; Wed, 19 Mar 2025 12:30:21 +0000 (GMT) Received: from epsmges5p3new.samsung.com (unknown [182.195.38.175]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4ZHp2M4snMz4x9Q0; Wed, 19 Mar 2025 12:30:19 +0000 (GMT) Received: from epcas5p4.samsung.com ( [182.195.41.42]) by epsmges5p3new.samsung.com (Symantec Messaging Gateway) with SMTP id B3.BA.19956.BD8BAD76; Wed, 19 Mar 2025 21:30:19 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20250318105612epcas5p34f450be02cce619b638594c488b31440~t4Gkce5Ye2841228412epcas5p3h; Tue, 18 Mar 2025 10:56:12 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250318105612epsmtrp2c35a86035ab44ea22c50ce1c1a785518~t4GkbagS_0212302123epsmtrp2h; Tue, 18 Mar 2025 10:56:12 +0000 (GMT) X-AuditID: b6c32a4b-fd1f170000004df4-29-67dab8db51ef Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 05.F2.18729.C4159D76; Tue, 18 Mar 2025 19:56:12 +0900 (KST) Received: from FDSFTE596 (unknown [107.122.82.131]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250318105610epsmtip2063c82de3e89d1e8ad55f420d5c19370~t4Ghvs-CR2200322003epsmtip21; Tue, 18 Mar 2025 10:56:09 +0000 (GMT) From: "Swathi K S" To: "'Russell King \(Oracle\)'" Cc: , , , , , , , , , , , , , , , , , , In-Reply-To: Subject: RE: [PATCH v8 2/2] net: stmmac: dwc-qos: Add FSD EQoS support Date: Tue, 18 Mar 2025 16:26:03 +0530 Message-ID: <000501db97f4$5cf4e7d0$16deb770$@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHcwqSBZNYxUrKMqce/4F1P5N/GfgHDYTN3Am9yBUoC+lQhMgFBTkwbszLu+LA= Content-Language: en-in X-Brightmail-Tracker: H4sIAAAAAAAAA02Tf0xTVxTHc99r+x5sZc+C84IZK4/YCBNstS2P8UMXDT7ULETisvHHoIG3 QoC2a4tTF4VkjA0myFCcNh02ihLKAC0/Wn4OK6AowpAJOIJzrPywTHBicMhwa32w8d/nnPM9 95zvvbk4Klji+eFpKj2jVSkySJ4np/F6UHDIqO0XpdhaTlKLj84AquKhjUv90NaHUMb+XA51 vrOPS010j2PU/Y4mhHpkeMCjfmos4lKW34e41GCzkUcVDDm4lL20DVBly9Vcqtv0JrVw+w9A XWh4hlG/PWnFqM7eaZT6p9WG7fShB4cGULq+8j5CT5xswOgmwxhGmyxZtMWcz6PryrPpJts8 Qs+13+PRRfVmQF9rl9DzFv+41xPSI1MZRQqjFTKqZHVKmkoZRe6LT9yVKJOLJSGScCqMFKoU mUwUuXt/XEhMWobLJik8pMjIcqXiFDoduTU6UqvO0jPCVLVOH0UympQMjVQTqlNk6rJUylAV o39XIhZvk7mESempk19+hWoG1x3OtzuxHDDhVQA8cEhIYelwLigAnriAaAHwUp8VYYOnADaX PV+pLADYX+fgrrbctBeibKENwLlTTh4bTANYYzEjbhWPCIYXitoxN/sQYbA0v5PrFqFECQee bZh0iXDcg5DBmVGpG72JGJhzQ+aWc4hNMP+8HbiZT4TDvDMzGMvrYM85B8fNKPE2tD42ouxC Qrg4cZnLjnofzk+9BKxmA+xaPPFqUUhUeMDK7hrANuyGxS+qeSx7Q+eNeoxlPzg/27aSp+G5 2sIVxylwxtzHYXkH7PjZyHHvjBJBsLZ5K5t+C5beqkHYuV6wcMmBsHk+tJWtciBcnhlaOcYX Nl6aw4oBaVhjzbDGmmGNBcP/00yAYwa+jEaXqWR0Ms12FfPZfw+erM60gFe/IHifDYw/fBJq BwgO7ADiKOnD3+MYVgr4KYojRxmtOlGblcHo7EDmuu9vUb/1yWrXN1LpEyXScLFULpdLw7fL JeQG/hdNuUoBoVTomXSG0TDa1T4E9/DLQY7cDX72NOD7CH+z7bhNJGy5GLvxbLTeVl7vrDXP NKZl41hOVMHzvM6gb0r2+277a/xjkffsDmvt+GtdS95/xm96J6Bjsa5owMea177x6suxN/Z8 nuBf4fwaHs5Prcu++XhLZWdC8e2hqRr8pD2xJ1B066DJcefAdNVevtD+4KNfBQM7q5J+/OC6 9zAxOFJ/dUt1aezxgMrN3yEfjsUffa9/tDdSc0zeNLDstX6Xcyq5xRR9yDR/z9jVupcYLB8x GIkFVYm5ree05xSWlHA59KLg1Kc11gjQHDYe4REb5+xVk7E+1/7uq3gRE6i8M7v5bpUoSa4T jxz7ZPLKAU1PUpDoRLeI5OhSFZJgVKtT/AteSFcxjgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWy7bCSvK5P4M10g4V/9Cx+vpzGaLH8wQ5W izV7zzFZzDnfwmIx/8g5Vounxx6xW9w8sJPJ4uWse2wWF7b1sVpsenyN1eLyrjlsFl3XnrBa HJq6l9Fi3t+1rBbHFohZfDv9htFi0dYv7BYPP+xhtzhy5gWzxf89O9gdRDwuX7vI7LFl5U0m j6f9W9k9ds66y+6xYFOpx6ZVnWwem5fUe+zc8ZnJ4/2+q2wefVtWMXoc3Gfo8XmTXABPFJdN SmpOZllqkb5dAlfGs9Z25oLLghWdh16xNzA+5eti5OSQEDCROHGol7mLkYtDSGA3o8StA9uY IBKSEp+ap7JC2MISK/89Z4coesYocWP5AnaQBJuAlsSivn1gtoiAucTUziOsIEXMAitYJG7s u8MC0dHPJLFg9n8gh4ODU8BU4vVtExBTWMBNouG4KUgvi4CqROf8Q4wgNq+ApUTbtNfsELag xMmZT8A6mQX0JNo2gpUwC8hLbH87hxniNgWJn0+XsUKc4Cfx+fk/qBpxiaM/e5gnMArPQjJp FsKkWUgmzULSsYCRZRWjZGpBcW56brFhgWFearlecWJucWleul5yfu4mRnAq0NLcwbh91Qe9 Q4xMHIyHGCU4mJVEeN2fXE8X4k1JrKxKLcqPLyrNSS0+xCjNwaIkziv+ojdFSCA9sSQ1OzW1 ILUIJsvEwSnVwFR25dTS28tUUq9dnLtJWy9ukdc75eBjmvc2Tem1l6p+vJR98do57s9u3txj UXiwSOz25dBVHA0f66M/KIVPb9kfcPjQgSlMfXylyz5wMdx/aKy6aK2IsdoUifl1pw8kC93Y 8eHv6U93uhZY7jw9XSA7xGNxlMj1t5NYLjyayTCvPvRK2J5TH59PUDzSvcqx88uO6F3nN8yx 11x806HlxcTrsXY/0rzYvk+ZupPpjGKWsPXzySvWVyyeov/eqbVPQM/QmGXjqgifI++O2+pW T7ygmbFSdL5nqDLj0Y3ddTc6pDoTPm64HNhmW2NxcK7eDO53J22knNZceOKmmzpLz7VENIr3 e4s+04VC0dhmvYj/SizFGYmGWsxFxYkAXY4muHQDAAA= X-CMS-MailID: 20250318105612epcas5p34f450be02cce619b638594c488b31440 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250305091856epcas5p4228c09989c7acfe45a99541eef01fbcd References: <20250305091246.106626-1-swathi.ks@samsung.com> <20250305091246.106626-3-swathi.ks@samsung.com> > -----Original Message----- > From: Russell King (Oracle) > Sent: 12 March 2025 23:27 > To: Swathi K S > Cc: krzk+dt@kernel.org; andrew+netdev@lunn.ch; davem@davemloft.net; > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > robh@kernel.org; conor+dt@kernel.org; richardcochran@gmail.com; > mcoquelin.stm32@gmail.com; alexandre.torgue@foss.st.com; > netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-stm32@st-md- > mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; pankaj.dubey@samsung.com; > ravi.patel@samsung.com; gost.dev@samsung.com > Subject: Re: [PATCH v8 2/2] net: stmmac: dwc-qos: Add FSD EQoS support > > On Wed, Mar 05, 2025 at 02:43:52PM +0000, Russell King (Oracle) wrote: > > On Wed, Mar 05, 2025 at 02:42:46PM +0530, Swathi K S wrote: > > > The FSD SoC contains two instance of the Synopsys DWC ethernet QOS IP > core. > > > The binding that it uses is slightly different from existing ones > > > because of the integration (clocks, resets). > > > > > > Signed-off-by: Swathi K S > > > > This looks much better! > > > > Reviewed-by: Russell King (Oracle) > > > > Thanks! > > Hi Swathi, > > Please can you test with my TX clock gating series applied ( > https://lore.kernel.org/r/Z9FVHEf3uUqtKzyt@shell.armlinux.org.uk ) with > STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP set as per the attached diff. > Please let me know whether this passes your testing, so I know whether this > platform supports it - please check that this results in a message in the kernel > log indicating "tx_clk_stop = 1". Thanks. Hi Russell, Applied your patches and tested. It did not cause any functional issue, but at the same time, as EEE is not enabled in our HW, we cannot really test that particular functionality. Regards, Swathi > > -- > RMK's Patch system: https://protect2.fireeye.com/v1/url?k=23e12f6a- > 429cc5e9-23e0a425-74fe48600158-954ebfe080aed91e&q=1&e=40e60980- > bcfe-49e0-a9c9- > d9b87765f87c&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2F > patches%2F > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!