From: Thomas Huth <thuth@redhat.com>
To: Nathan Chancellor <nathan@kernel.org>,
akpm@linux-foundation.org, arnd@arndb.de, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com,
wintera@linux.ibm.com, twinkler@linux.ibm.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
llvm@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH 3/3] s390/netiucv: Remove function pointer cast
Date: Thu, 18 Apr 2024 07:57:42 +0200 [thread overview]
Message-ID: <00054ec1-66c2-46e3-917f-cd5a43ffe4cd@redhat.com> (raw)
In-Reply-To: <20240417-s390-drivers-fix-cast-function-type-v1-3-fd048c9903b0@kernel.org>
On 17/04/2024 20.24, Nathan Chancellor wrote:
> Clang warns (or errors with CONFIG_WERROR) after enabling
> -Wcast-function-type-strict by default:
>
> drivers/s390/net/netiucv.c:1716:18: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
> 1716 | dev->release = (void (*)(struct device *))kfree;
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> Add a standalone function to fix the warning properly, which addresses
> the root of the warning that these casts are not safe for kCFI. The
> comment is not really relevant after this change, so remove it.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/s390/net/netiucv.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2024-04-18 5:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 18:24 [PATCH 0/3] drivers/s390: Fix instances of -Wcast-function-type-strict Nathan Chancellor
2024-04-17 18:24 ` [PATCH 1/3] s390/vmlogrdr: Remove function pointer cast Nathan Chancellor
2024-04-17 18:55 ` Arnd Bergmann
2024-04-18 5:56 ` Thomas Huth
2024-04-18 9:54 ` Heiko Carstens
2024-04-18 10:25 ` Heiko Carstens
2024-04-18 14:51 ` Nathan Chancellor
2024-04-18 15:15 ` Heiko Carstens
2024-04-18 15:34 ` Nathan Chancellor
2024-04-18 19:21 ` Heiko Carstens
2024-04-18 20:32 ` Nathan Chancellor
2024-04-18 19:46 ` Arnd Bergmann
2024-04-19 12:15 ` Heiko Carstens
2024-04-19 12:19 ` Arnd Bergmann
2024-04-19 14:12 ` Heiko Carstens
2024-04-23 7:34 ` Alexandra Winter
2024-05-06 19:26 ` Heiko Carstens
2024-04-17 18:24 ` [PATCH 2/3] s390/smsgiucv_app: " Nathan Chancellor
2024-04-17 18:56 ` Arnd Bergmann
2024-04-18 5:56 ` Thomas Huth
2024-04-17 18:24 ` [PATCH 3/3] s390/netiucv: " Nathan Chancellor
2024-04-17 18:57 ` Arnd Bergmann
2024-04-18 5:57 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00054ec1-66c2-46e3-917f-cd5a43ffe4cd@redhat.com \
--to=thuth@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).