* [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3
@ 2013-10-22 4:13 Jingoo Han
2013-10-22 4:14 ` [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata() Jingoo Han
` (15 more replies)
0 siblings, 16 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:13 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
---
drivers/net/ethernet/pasemi/pasemi_mac.c | 1 -
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 2 --
drivers/net/ethernet/qlogic/qla3xxx.c | 2 --
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 --
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 1 -
drivers/net/ethernet/rdc/r6040.c | 2 --
drivers/net/ethernet/realtek/8139cp.c | 1 -
drivers/net/ethernet/realtek/8139too.c | 1 -
drivers/net/ethernet/realtek/r8169.c | 1 -
drivers/net/ethernet/sis/sis190.c | 1 -
drivers/net/ethernet/smsc/epic100.c | 1 -
drivers/net/ethernet/smsc/smsc9420.c | 2 --
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 1 -
drivers/net/ethernet/sun/cassini.c | 2 --
drivers/net/ethernet/sun/sunhme.c | 2 --
15 files changed, 22 deletions(-)
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
@ 2013-10-22 4:14 ` Jingoo Han
2013-10-22 6:07 ` Olof Johansson
2013-10-22 4:15 ` [PATCH 02/15] net: netxen: " Jingoo Han
` (14 subsequent siblings)
15 siblings, 1 reply; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:14 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Olof Johansson'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/pasemi/pasemi_mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c
index 5b65356..dbaa49e 100644
--- a/drivers/net/ethernet/pasemi/pasemi_mac.c
+++ b/drivers/net/ethernet/pasemi/pasemi_mac.c
@@ -1870,7 +1870,6 @@ static void pasemi_mac_remove(struct pci_dev *pdev)
pasemi_dma_free_chan(&mac->tx->chan);
pasemi_dma_free_chan(&mac->rx->chan);
- pci_set_drvdata(pdev, NULL);
free_netdev(netdev);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 02/15] net: netxen: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
2013-10-22 4:14 ` [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-10-22 4:15 ` Jingoo Han
2013-10-22 4:15 ` [PATCH 03/15] net: qlge: " Jingoo Han
` (13 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:15 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Manish Chopra',
'Sony Chacko', 'Rajesh Borundia'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index 5ec21c5..3bec8cf 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -1630,7 +1630,6 @@ err_out_free_res:
pci_release_regions(pdev);
err_out_disable_pdev:
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
return err;
}
@@ -1689,7 +1688,6 @@ static void netxen_nic_remove(struct pci_dev *pdev)
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
free_netdev(netdev);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 03/15] net: qlge: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
2013-10-22 4:14 ` [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata() Jingoo Han
2013-10-22 4:15 ` [PATCH 02/15] net: netxen: " Jingoo Han
@ 2013-10-22 4:15 ` Jingoo Han
2013-10-22 4:16 ` [PATCH 04/15] net: qlcnic: " Jingoo Han
` (12 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:15 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Shahed Shaikh',
'Jitendra Kalsaria', 'Ron Mercer'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index 64f9409..a245dc1 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -4577,7 +4577,6 @@ static void ql_release_all(struct pci_dev *pdev)
iounmap(qdev->doorbell_area);
vfree(qdev->mpi_coredump);
pci_release_regions(pdev);
- pci_set_drvdata(pdev, NULL);
}
static int ql_init_device(struct pci_dev *pdev, struct net_device *ndev,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 04/15] net: qlcnic: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (2 preceding siblings ...)
2013-10-22 4:15 ` [PATCH 03/15] net: qlge: " Jingoo Han
@ 2013-10-22 4:16 ` Jingoo Han
2013-10-22 4:16 ` [PATCH 05/15] net: qla3xxx: " Jingoo Han
` (11 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:16 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Himanshu Madhani',
'Rajesh Borundia', 'Shahed Shaikh',
'Jitendra Kalsaria', 'Sony Chacko',
'Sucheta Chakraborty'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 0274832..24e6b11 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2406,7 +2406,6 @@ err_out_free_res:
pci_release_regions(pdev);
err_out_disable_pdev:
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
return err;
@@ -2482,7 +2481,6 @@ static void qlcnic_remove(struct pci_dev *pdev)
pci_disable_pcie_error_reporting(pdev);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
if (adapter->qlcnic_wq) {
destroy_workqueue(adapter->qlcnic_wq);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 05/15] net: qla3xxx: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (3 preceding siblings ...)
2013-10-22 4:16 ` [PATCH 04/15] net: qlcnic: " Jingoo Han
@ 2013-10-22 4:16 ` Jingoo Han
2013-10-22 4:17 ` [PATCH 06/15] net: r6040: " Jingoo Han
` (10 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:16 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Jitendra Kalsaria',
'Ron Mercer'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 91a8fcd..0758b94 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -3916,7 +3916,6 @@ err_out_free_regions:
pci_release_regions(pdev);
err_out_disable_pdev:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
err_out:
return err;
}
@@ -3939,7 +3938,6 @@ static void ql3xxx_remove(struct pci_dev *pdev)
iounmap(qdev->mem_map_registers);
pci_release_regions(pdev);
- pci_set_drvdata(pdev, NULL);
free_netdev(ndev);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 06/15] net: r6040: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (4 preceding siblings ...)
2013-10-22 4:16 ` [PATCH 05/15] net: qla3xxx: " Jingoo Han
@ 2013-10-22 4:17 ` Jingoo Han
2013-10-22 4:17 ` [PATCH 07/15] net: 8139cp: " Jingoo Han
` (9 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:17 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Florian Fainelli'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/rdc/r6040.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index e9dc849..1e49ec5 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -1231,7 +1231,6 @@ err_out_mdio:
mdiobus_free(lp->mii_bus);
err_out_unmap:
netif_napi_del(&lp->napi);
- pci_set_drvdata(pdev, NULL);
pci_iounmap(pdev, ioaddr);
err_out_free_res:
pci_release_regions(pdev);
@@ -1257,7 +1256,6 @@ static void r6040_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev);
free_netdev(dev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 07/15] net: 8139cp: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (5 preceding siblings ...)
2013-10-22 4:17 ` [PATCH 06/15] net: r6040: " Jingoo Han
@ 2013-10-22 4:17 ` Jingoo Han
2013-10-22 4:17 ` [PATCH 08/15] net: 8139too: " Jingoo Han
` (8 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:17 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/realtek/8139cp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c
index d2e5919..f2a2128 100644
--- a/drivers/net/ethernet/realtek/8139cp.c
+++ b/drivers/net/ethernet/realtek/8139cp.c
@@ -2052,7 +2052,6 @@ static void cp_remove_one (struct pci_dev *pdev)
pci_release_regions(pdev);
pci_clear_mwi(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
free_netdev(dev);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 08/15] net: 8139too: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (6 preceding siblings ...)
2013-10-22 4:17 ` [PATCH 07/15] net: 8139cp: " Jingoo Han
@ 2013-10-22 4:17 ` Jingoo Han
2013-10-22 4:18 ` [PATCH 09/15] net: r8169: " Jingoo Han
` (7 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:17 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/realtek/8139too.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/8139too.c b/drivers/net/ethernet/realtek/8139too.c
index 3ccedeb..50a9210 100644
--- a/drivers/net/ethernet/realtek/8139too.c
+++ b/drivers/net/ethernet/realtek/8139too.c
@@ -727,7 +727,6 @@ static void __rtl8139_cleanup_dev (struct net_device *dev)
pci_release_regions (pdev);
free_netdev(dev);
- pci_set_drvdata (pdev, NULL);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 09/15] net: r8169: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (7 preceding siblings ...)
2013-10-22 4:17 ` [PATCH 08/15] net: 8139too: " Jingoo Han
@ 2013-10-22 4:18 ` Jingoo Han
2013-10-22 4:18 ` [PATCH 10/15] net: sis190: " Jingoo Han
` (6 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:18 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han',
'Realtek linux nic maintainers',
'Francois Romieu'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/realtek/r8169.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 3397cee..7993875 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -6811,7 +6811,6 @@ static void rtl_remove_one(struct pci_dev *pdev)
rtl_disable_msi(pdev, tp);
rtl8169_release_board(pdev, dev, tp->mmio_addr);
- pci_set_drvdata(pdev, NULL);
}
static const struct net_device_ops rtl_netdev_ops = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 10/15] net: sis190: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (8 preceding siblings ...)
2013-10-22 4:18 ` [PATCH 09/15] net: r8169: " Jingoo Han
@ 2013-10-22 4:18 ` Jingoo Han
2013-10-22 4:19 ` [PATCH 11/15] net: epic100: " Jingoo Han
` (5 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:18 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Francois Romieu'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sis/sis190.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c
index ee18e6f..acbbe48 100644
--- a/drivers/net/ethernet/sis/sis190.c
+++ b/drivers/net/ethernet/sis/sis190.c
@@ -1921,7 +1921,6 @@ static void sis190_remove_one(struct pci_dev *pdev)
cancel_work_sync(&tp->phy_task);
unregister_netdev(dev);
sis190_release_board(pdev);
- pci_set_drvdata(pdev, NULL);
}
static struct pci_driver sis190_pci_driver = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 11/15] net: epic100: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (9 preceding siblings ...)
2013-10-22 4:18 ` [PATCH 10/15] net: sis190: " Jingoo Han
@ 2013-10-22 4:19 ` Jingoo Han
2013-10-22 4:19 ` [PATCH 12/15] net: smsc9420: " Jingoo Han
` (4 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:19 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/smsc/epic100.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/epic100.c b/drivers/net/ethernet/smsc/epic100.c
index 03b256a..8c5c24a 100644
--- a/drivers/net/ethernet/smsc/epic100.c
+++ b/drivers/net/ethernet/smsc/epic100.c
@@ -1535,7 +1535,6 @@ static void epic_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev);
free_netdev(dev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
/* pci_power_off(pdev, -1); */
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 12/15] net: smsc9420: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (10 preceding siblings ...)
2013-10-22 4:19 ` [PATCH 11/15] net: epic100: " Jingoo Han
@ 2013-10-22 4:19 ` Jingoo Han
2013-10-22 4:20 ` [PATCH 13/15] net: stmmac: " Jingoo Han
` (3 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:19 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Steve Glendinning'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/smsc/smsc9420.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc9420.c b/drivers/net/ethernet/smsc/smsc9420.c
index 5f9e79f..e55e336 100644
--- a/drivers/net/ethernet/smsc/smsc9420.c
+++ b/drivers/net/ethernet/smsc/smsc9420.c
@@ -1707,8 +1707,6 @@ static void smsc9420_remove(struct pci_dev *pdev)
if (!dev)
return;
- pci_set_drvdata(pdev, NULL);
-
pd = netdev_priv(dev);
unregister_netdev(dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 13/15] net: stmmac: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (11 preceding siblings ...)
2013-10-22 4:19 ` [PATCH 12/15] net: smsc9420: " Jingoo Han
@ 2013-10-22 4:20 ` Jingoo Han
2013-10-22 4:20 ` [PATCH 14/15] net: sunhme: " Jingoo Han
` (2 subsequent siblings)
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:20 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Giuseppe Cavallaro'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
index 023b7c2..644d80e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
@@ -138,7 +138,6 @@ static void stmmac_pci_remove(struct pci_dev *pdev)
stmmac_dvr_remove(ndev);
- pci_set_drvdata(pdev, NULL);
pci_iounmap(pdev, priv->ioaddr);
pci_release_regions(pdev);
pci_disable_device(pdev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 14/15] net: sunhme: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (12 preceding siblings ...)
2013-10-22 4:20 ` [PATCH 13/15] net: stmmac: " Jingoo Han
@ 2013-10-22 4:20 ` Jingoo Han
2013-10-22 4:21 ` [PATCH 15/15] net: cassini: " Jingoo Han
2013-10-22 6:13 ` [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 David Miller
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:20 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sun/sunhme.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index 99043b7..0dbf46f 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -3170,8 +3170,6 @@ static void happy_meal_pci_remove(struct pci_dev *pdev)
pci_release_regions(hp->happy_dev);
free_netdev(net_dev);
-
- pci_set_drvdata(pdev, NULL);
}
static DEFINE_PCI_DEVICE_TABLE(happymeal_pci_ids) = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 15/15] net: cassini: remove unnecessary pci_set_drvdata()
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (13 preceding siblings ...)
2013-10-22 4:20 ` [PATCH 14/15] net: sunhme: " Jingoo Han
@ 2013-10-22 4:21 ` Jingoo Han
2013-10-22 6:13 ` [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 David Miller
15 siblings, 0 replies; 18+ messages in thread
From: Jingoo Han @ 2013-10-22 4:21 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sun/cassini.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
index a72ecc4..b4d50d7 100644
--- a/drivers/net/ethernet/sun/cassini.c
+++ b/drivers/net/ethernet/sun/cassini.c
@@ -5168,7 +5168,6 @@ err_out_free_netdev:
err_out_disable_pdev:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
return -ENODEV;
}
@@ -5206,7 +5205,6 @@ static void cas_remove_one(struct pci_dev *pdev)
free_netdev(dev);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
#ifdef CONFIG_PM
--
1.7.10.4
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata()
2013-10-22 4:14 ` [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-10-22 6:07 ` Olof Johansson
0 siblings, 0 replies; 18+ messages in thread
From: Olof Johansson @ 2013-10-22 6:07 UTC (permalink / raw)
To: Jingoo Han; +Cc: David S. Miller, Network Development
On Mon, Oct 21, 2013 at 9:14 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Olof Johansson <olof@lixom.net>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
` (14 preceding siblings ...)
2013-10-22 4:21 ` [PATCH 15/15] net: cassini: " Jingoo Han
@ 2013-10-22 6:13 ` David Miller
15 siblings, 0 replies; 18+ messages in thread
From: David Miller @ 2013-10-22 6:13 UTC (permalink / raw)
To: jg1.han; +Cc: netdev
From: Jingoo Han <jg1.han@samsung.com>
Date: Tue, 22 Oct 2013 13:13:44 +0900
> Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound),
> the driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
Series applied, thanks.
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-10-22 6:13 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 4:13 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 Jingoo Han
2013-10-22 4:14 ` [PATCH 01/15] net: pasemi: remove unnecessary pci_set_drvdata() Jingoo Han
2013-10-22 6:07 ` Olof Johansson
2013-10-22 4:15 ` [PATCH 02/15] net: netxen: " Jingoo Han
2013-10-22 4:15 ` [PATCH 03/15] net: qlge: " Jingoo Han
2013-10-22 4:16 ` [PATCH 04/15] net: qlcnic: " Jingoo Han
2013-10-22 4:16 ` [PATCH 05/15] net: qla3xxx: " Jingoo Han
2013-10-22 4:17 ` [PATCH 06/15] net: r6040: " Jingoo Han
2013-10-22 4:17 ` [PATCH 07/15] net: 8139cp: " Jingoo Han
2013-10-22 4:17 ` [PATCH 08/15] net: 8139too: " Jingoo Han
2013-10-22 4:18 ` [PATCH 09/15] net: r8169: " Jingoo Han
2013-10-22 4:18 ` [PATCH 10/15] net: sis190: " Jingoo Han
2013-10-22 4:19 ` [PATCH 11/15] net: epic100: " Jingoo Han
2013-10-22 4:19 ` [PATCH 12/15] net: smsc9420: " Jingoo Han
2013-10-22 4:20 ` [PATCH 13/15] net: stmmac: " Jingoo Han
2013-10-22 4:20 ` [PATCH 14/15] net: sunhme: " Jingoo Han
2013-10-22 4:21 ` [PATCH 15/15] net: cassini: " Jingoo Han
2013-10-22 6:13 ` [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 3 David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).