* [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4
@ 2013-10-23 7:05 Jingoo Han
2013-10-23 7:06 ` [PATCH 1/7] net: sungem: remove unnecessary pci_set_drvdata() Jingoo Han
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:05 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
---
drivers/net/ethernet/sun/niu.c | 2 --
drivers/net/ethernet/sun/sungem.c | 2 --
drivers/net/ethernet/tehuti/tehuti.c | 1 -
drivers/net/ethernet/ti/tlan.c | 1 -
drivers/net/ethernet/toshiba/spider_net.c | 1 -
drivers/net/ethernet/toshiba/tc35815.c | 1 -
drivers/net/ethernet/via/via-rhine.c | 1 -
7 files changed, 9 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/7] net: sungem: remove unnecessary pci_set_drvdata()
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
@ 2013-10-23 7:06 ` Jingoo Han
2013-10-23 7:07 ` [PATCH 2/7] net: niu: " Jingoo Han
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:06 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sun/sungem.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c
index a235bd9..b5655b7 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -2806,8 +2806,6 @@ static void gem_remove_one(struct pci_dev *pdev)
iounmap(gp->regs);
pci_release_regions(pdev);
free_netdev(dev);
-
- pci_set_drvdata(pdev, NULL);
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/7] net: niu: remove unnecessary pci_set_drvdata()
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
2013-10-23 7:06 ` [PATCH 1/7] net: sungem: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-10-23 7:07 ` Jingoo Han
2013-10-23 7:07 ` [PATCH 3/7] net: tehuti: " Jingoo Han
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:07 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/sun/niu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
index f28460c..388540f 100644
--- a/drivers/net/ethernet/sun/niu.c
+++ b/drivers/net/ethernet/sun/niu.c
@@ -9875,7 +9875,6 @@ err_out_free_res:
err_out_disable_pdev:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
return err;
}
@@ -9900,7 +9899,6 @@ static void niu_pci_remove_one(struct pci_dev *pdev)
free_netdev(dev);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/7] net: tehuti: remove unnecessary pci_set_drvdata()
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
2013-10-23 7:06 ` [PATCH 1/7] net: sungem: remove unnecessary pci_set_drvdata() Jingoo Han
2013-10-23 7:07 ` [PATCH 2/7] net: niu: " Jingoo Han
@ 2013-10-23 7:07 ` Jingoo Han
2013-10-23 7:08 ` [PATCH 4/7] net: tlan: " Jingoo Han
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:07 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Andy Gospodarek'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/tehuti/tehuti.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c
index 571452e..dd0dd627 100644
--- a/drivers/net/ethernet/tehuti/tehuti.c
+++ b/drivers/net/ethernet/tehuti/tehuti.c
@@ -2447,7 +2447,6 @@ static void bdx_remove(struct pci_dev *pdev)
iounmap(nic->regs);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
vfree(nic);
RET();
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/7] net: tlan: remove unnecessary pci_set_drvdata()
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
` (2 preceding siblings ...)
2013-10-23 7:07 ` [PATCH 3/7] net: tehuti: " Jingoo Han
@ 2013-10-23 7:08 ` Jingoo Han
2013-10-23 7:09 ` [PATCH 5/7] net: spider_net: " Jingoo Han
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:08 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Samuel Chessman'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/ti/tlan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index 591437e..62b19be 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -319,7 +319,6 @@ static void tlan_remove_one(struct pci_dev *pdev)
free_netdev(dev);
- pci_set_drvdata(pdev, NULL);
cancel_work_sync(&priv->tlan_tqueue);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/7] net: spider_net: remove unnecessary pci_set_drvdata()
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
` (3 preceding siblings ...)
2013-10-23 7:08 ` [PATCH 4/7] net: tlan: " Jingoo Han
@ 2013-10-23 7:09 ` Jingoo Han
2013-10-23 7:09 ` [PATCH 6/7] net: tc35815: " Jingoo Han
2013-10-23 7:09 ` [PATCH 7/7] net: via-rhine: " Jingoo Han
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:09 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Ishizaki Kou',
'Jens Osterkamp'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/toshiba/spider_net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c
index 5734480..3f4a32e 100644
--- a/drivers/net/ethernet/toshiba/spider_net.c
+++ b/drivers/net/ethernet/toshiba/spider_net.c
@@ -2478,7 +2478,6 @@ out_release_regions:
pci_release_regions(pdev);
out_disable_dev:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
return NULL;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 6/7] net: tc35815: remove unnecessary pci_set_drvdata()
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
` (4 preceding siblings ...)
2013-10-23 7:09 ` [PATCH 5/7] net: spider_net: " Jingoo Han
@ 2013-10-23 7:09 ` Jingoo Han
2013-10-23 7:09 ` [PATCH 7/7] net: via-rhine: " Jingoo Han
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:09 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/toshiba/tc35815.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/net/ethernet/toshiba/tc35815.c
index a971b9c..1322546 100644
--- a/drivers/net/ethernet/toshiba/tc35815.c
+++ b/drivers/net/ethernet/toshiba/tc35815.c
@@ -887,7 +887,6 @@ static void tc35815_remove_one(struct pci_dev *pdev)
mdiobus_free(lp->mii_bus);
unregister_netdev(dev);
free_netdev(dev);
- pci_set_drvdata(pdev, NULL);
}
static int
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 7/7] net: via-rhine: remove unnecessary pci_set_drvdata()
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
` (5 preceding siblings ...)
2013-10-23 7:09 ` [PATCH 6/7] net: tc35815: " Jingoo Han
@ 2013-10-23 7:09 ` Jingoo Han
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-10-23 7:09 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Roger Luethi'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/via/via-rhine.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
index bdf697b..4a7293e 100644
--- a/drivers/net/ethernet/via/via-rhine.c
+++ b/drivers/net/ethernet/via/via-rhine.c
@@ -2292,7 +2292,6 @@ static void rhine_remove_one(struct pci_dev *pdev)
free_netdev(dev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static void rhine_shutdown (struct pci_dev *pdev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-10-23 7:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-23 7:05 [PATCH 0/7] net: ethernet: remove unnecessary pci_set_drvdata() part 4 Jingoo Han
2013-10-23 7:06 ` [PATCH 1/7] net: sungem: remove unnecessary pci_set_drvdata() Jingoo Han
2013-10-23 7:07 ` [PATCH 2/7] net: niu: " Jingoo Han
2013-10-23 7:07 ` [PATCH 3/7] net: tehuti: " Jingoo Han
2013-10-23 7:08 ` [PATCH 4/7] net: tlan: " Jingoo Han
2013-10-23 7:09 ` [PATCH 5/7] net: spider_net: " Jingoo Han
2013-10-23 7:09 ` [PATCH 6/7] net: tc35815: " Jingoo Han
2013-10-23 7:09 ` [PATCH 7/7] net: via-rhine: " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).