* [PATCH 1/2] irda: via-ircc: remove unnecessary pci_set_drvdata()
@ 2013-12-09 3:28 Jingoo Han
2013-12-09 3:29 ` [PATCH 2/2] irda: vlsi_ir: " Jingoo Han
2013-12-09 23:10 ` [PATCH 1/2] irda: via-ircc: " David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Jingoo Han @ 2013-12-09 3:28 UTC (permalink / raw)
To: 'David Miller'
Cc: netdev, 'Samuel Ortiz', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/irda/via-ircc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c
index 26cb45d..2900af0 100644
--- a/drivers/net/irda/via-ircc.c
+++ b/drivers/net/irda/via-ircc.c
@@ -407,7 +407,6 @@ static int via_ircc_open(struct pci_dev *pdev, chipio_t *info, unsigned int id)
err_out2:
release_region(self->io.fir_base, self->io.fir_ext);
err_out1:
- pci_set_drvdata(pdev, NULL);
free_netdev(dev);
return err;
}
@@ -441,7 +440,6 @@ static void via_remove_one(struct pci_dev *pdev)
if (self->rx_buff.head)
dma_free_coherent(&pdev->dev, self->rx_buff.truesize,
self->rx_buff.head, self->rx_buff_dma);
- pci_set_drvdata(pdev, NULL);
free_netdev(self->netdev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] irda: vlsi_ir: remove unnecessary pci_set_drvdata()
2013-12-09 3:28 [PATCH 1/2] irda: via-ircc: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-12-09 3:29 ` Jingoo Han
2013-12-09 23:10 ` David Miller
2013-12-09 23:10 ` [PATCH 1/2] irda: via-ircc: " David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2013-12-09 3:29 UTC (permalink / raw)
To: 'David Miller'
Cc: netdev, 'Samuel Ortiz', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/irda/vlsi_ir.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
index cc9b866..4850066 100644
--- a/drivers/net/irda/vlsi_ir.c
+++ b/drivers/net/irda/vlsi_ir.c
@@ -1693,7 +1693,6 @@ out_freedev:
out_disable:
pci_disable_device(pdev);
out:
- pci_set_drvdata(pdev, NULL);
return -ENODEV;
}
@@ -1719,8 +1718,6 @@ static void vlsi_irda_remove(struct pci_dev *pdev)
free_netdev(ndev);
- pci_set_drvdata(pdev, NULL);
-
IRDA_MESSAGE("%s: %s removed\n", drivername, pci_name(pdev));
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] irda: via-ircc: remove unnecessary pci_set_drvdata()
2013-12-09 3:28 [PATCH 1/2] irda: via-ircc: remove unnecessary pci_set_drvdata() Jingoo Han
2013-12-09 3:29 ` [PATCH 2/2] irda: vlsi_ir: " Jingoo Han
@ 2013-12-09 23:10 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2013-12-09 23:10 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, samuel
From: Jingoo Han <jg1.han@samsung.com>
Date: Mon, 09 Dec 2013 12:28:28 +0900
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] irda: via-ircc: remove unnecessary pci_set_drvdata()
@ 2013-11-25 1:54 Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-11-25 1:54 UTC (permalink / raw)
To: 'David Miller'
Cc: netdev, 'Samuel Ortiz', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/irda/via-ircc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c
index 9abaec2..b0e8207 100644
--- a/drivers/net/irda/via-ircc.c
+++ b/drivers/net/irda/via-ircc.c
@@ -408,7 +408,6 @@ static int via_ircc_open(struct pci_dev *pdev, chipio_t *info, unsigned int id)
err_out2:
release_region(self->io.fir_base, self->io.fir_ext);
err_out1:
- pci_set_drvdata(pdev, NULL);
free_netdev(dev);
return err;
}
@@ -442,7 +441,6 @@ static void via_remove_one(struct pci_dev *pdev)
if (self->rx_buff.head)
dma_free_coherent(&pdev->dev, self->rx_buff.truesize,
self->rx_buff.head, self->rx_buff_dma);
- pci_set_drvdata(pdev, NULL);
free_netdev(self->netdev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-09 23:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 3:28 [PATCH 1/2] irda: via-ircc: remove unnecessary pci_set_drvdata() Jingoo Han
2013-12-09 3:29 ` [PATCH 2/2] irda: vlsi_ir: " Jingoo Han
2013-12-09 23:10 ` David Miller
2013-12-09 23:10 ` [PATCH 1/2] irda: via-ircc: " David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-11-25 1:54 Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).