From: Jingoo Han <jg1.han@samsung.com>
To: "'David S. Miller'" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>,
'Francois Romieu' <romieu@fr.zoreil.com>
Subject: [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata()
Date: Mon, 25 Nov 2013 10:56:35 +0900 [thread overview]
Message-ID: <000b01cee981$9254d850$b6fe88f0$%han@samsung.com> (raw)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/dscc4.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 851dc7b..288610d 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -699,8 +699,6 @@ static void dscc4_free1(struct pci_dev *pdev)
for (i = 0; i < dev_per_card; i++)
unregister_hdlc_device(dscc4_to_dev(root + i));
- pci_set_drvdata(pdev, NULL);
-
for (i = 0; i < dev_per_card; i++)
free_netdev(root[i].dev);
kfree(root);
--
1.7.10.4
next reply other threads:[~2013-11-25 1:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 1:56 Jingoo Han [this message]
2013-11-25 1:57 ` [PATCH 2/5] wan: lmc: remove unnecessary pci_set_drvdata() Jingoo Han
2013-11-25 1:58 ` [PATCH 3/5] wan: pc300too: " Jingoo Han
2013-11-25 1:58 ` [PATCH 4/5] wan: pci200syn: " Jingoo Han
2013-11-25 1:59 ` [PATCH 5/5] wan: wanxl: " Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-12-09 3:29 [PATCH 1/5] wan: dscc4: " Jingoo Han
2013-12-09 23:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01cee981$9254d850$b6fe88f0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).