* [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata()
@ 2013-11-25 1:56 Jingoo Han
2013-11-25 1:57 ` [PATCH 2/5] wan: lmc: " Jingoo Han
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Jingoo Han @ 2013-11-25 1:56 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Francois Romieu'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/dscc4.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 851dc7b..288610d 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -699,8 +699,6 @@ static void dscc4_free1(struct pci_dev *pdev)
for (i = 0; i < dev_per_card; i++)
unregister_hdlc_device(dscc4_to_dev(root + i));
- pci_set_drvdata(pdev, NULL);
-
for (i = 0; i < dev_per_card; i++)
free_netdev(root[i].dev);
kfree(root);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/5] wan: lmc: remove unnecessary pci_set_drvdata()
2013-11-25 1:56 [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-11-25 1:57 ` Jingoo Han
2013-11-25 1:58 ` [PATCH 3/5] wan: pc300too: " Jingoo Han
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2013-11-25 1:57 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/lmc/lmc_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 7ef435b..c59b91f 100644
--- a/drivers/net/wan/lmc/lmc_main.c
+++ b/drivers/net/wan/lmc/lmc_main.c
@@ -973,7 +973,6 @@ static int lmc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return 0;
err_hdlcdev:
- pci_set_drvdata(pdev, NULL);
kfree(sc);
err_kzalloc:
pci_release_regions(pdev);
@@ -995,7 +994,6 @@ static void lmc_remove_one(struct pci_dev *pdev)
free_netdev(dev);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/5] wan: pc300too: remove unnecessary pci_set_drvdata()
2013-11-25 1:56 [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata() Jingoo Han
2013-11-25 1:57 ` [PATCH 2/5] wan: lmc: " Jingoo Han
@ 2013-11-25 1:58 ` Jingoo Han
2013-11-25 1:58 ` [PATCH 4/5] wan: pci200syn: " Jingoo Han
2013-11-25 1:59 ` [PATCH 5/5] wan: wanxl: " Jingoo Han
3 siblings, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2013-11-25 1:58 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Krzysztof Halasa'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/pc300too.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c
index 53efc57..5b72f7f 100644
--- a/drivers/net/wan/pc300too.c
+++ b/drivers/net/wan/pc300too.c
@@ -281,7 +281,6 @@ static void pc300_pci_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
if (card->ports[0].netdev)
free_netdev(card->ports[0].netdev);
if (card->ports[1].netdev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/5] wan: pci200syn: remove unnecessary pci_set_drvdata()
2013-11-25 1:56 [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata() Jingoo Han
2013-11-25 1:57 ` [PATCH 2/5] wan: lmc: " Jingoo Han
2013-11-25 1:58 ` [PATCH 3/5] wan: pc300too: " Jingoo Han
@ 2013-11-25 1:58 ` Jingoo Han
2013-11-25 1:59 ` [PATCH 5/5] wan: wanxl: " Jingoo Han
3 siblings, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2013-11-25 1:58 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Krzysztof Halasa'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/pci200syn.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wan/pci200syn.c b/drivers/net/wan/pci200syn.c
index ddbce54..fe4e3ec 100644
--- a/drivers/net/wan/pci200syn.c
+++ b/drivers/net/wan/pci200syn.c
@@ -260,7 +260,6 @@ static void pci200_pci_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
if (card->ports[0].netdev)
free_netdev(card->ports[0].netdev);
if (card->ports[1].netdev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 5/5] wan: wanxl: remove unnecessary pci_set_drvdata()
2013-11-25 1:56 [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata() Jingoo Han
` (2 preceding siblings ...)
2013-11-25 1:58 ` [PATCH 4/5] wan: pci200syn: " Jingoo Han
@ 2013-11-25 1:59 ` Jingoo Han
3 siblings, 0 replies; 7+ messages in thread
From: Jingoo Han @ 2013-11-25 1:59 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Krzysztof Halasa'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/wanxl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index 4c0a697..f76aa90 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -542,7 +542,6 @@ static void wanxl_pci_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
kfree(card);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata()
@ 2013-12-09 3:29 Jingoo Han
2013-12-09 23:10 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Jingoo Han @ 2013-12-09 3:29 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, 'Jingoo Han', 'Francois Romieu'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wan/dscc4.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 851dc7b..288610d 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -699,8 +699,6 @@ static void dscc4_free1(struct pci_dev *pdev)
for (i = 0; i < dev_per_card; i++)
unregister_hdlc_device(dscc4_to_dev(root + i));
- pci_set_drvdata(pdev, NULL);
-
for (i = 0; i < dev_per_card; i++)
free_netdev(root[i].dev);
kfree(root);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata()
2013-12-09 3:29 [PATCH 1/5] wan: dscc4: " Jingoo Han
@ 2013-12-09 23:10 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2013-12-09 23:10 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, romieu
From: Jingoo Han <jg1.han@samsung.com>
Date: Mon, 09 Dec 2013 12:29:46 +0900
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-12-09 23:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-25 1:56 [PATCH 1/5] wan: dscc4: remove unnecessary pci_set_drvdata() Jingoo Han
2013-11-25 1:57 ` [PATCH 2/5] wan: lmc: " Jingoo Han
2013-11-25 1:58 ` [PATCH 3/5] wan: pc300too: " Jingoo Han
2013-11-25 1:58 ` [PATCH 4/5] wan: pci200syn: " Jingoo Han
2013-11-25 1:59 ` [PATCH 5/5] wan: wanxl: " Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-12-09 3:29 [PATCH 1/5] wan: dscc4: " Jingoo Han
2013-12-09 23:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).