From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: [PATCH 3/7] net: vmxnet3: remove unnecessary pci_set_drvdata() Date: Tue, 10 Dec 2013 12:50:09 +0900 Message-ID: <000d01cef55a$ebbfa430$c33eec90$%han@samsung.com> References: <000601cef55a$b605fab0$2211f010$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, 'Shreyas Bhatewara' , pv-drivers@vmware.com, 'Jingoo Han' , 'Andy King' , 'Aditya Sarwade' , 'George Zhang' To: "'David S. Miller'" Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:10316 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707Ab3LJDuQ (ORCPT ); Mon, 9 Dec 2013 22:50:16 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MXK009JXNZLMO60@mailout3.samsung.com> for netdev@vger.kernel.org; Tue, 10 Dec 2013 12:50:09 +0900 (KST) In-reply-to: <000601cef55a$b605fab0$2211f010$%han@samsung.com> Content-language: ko Sender: netdev-owner@vger.kernel.org List-ID: The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/net/vmxnet3/vmxnet3_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 7e2788c..a300a18 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -3132,7 +3132,6 @@ err_alloc_queue_desc: err_alloc_shared: dma_unmap_single(&adapter->pdev->dev, adapter->adapter_pa, sizeof(struct vmxnet3_adapter), PCI_DMA_TODEVICE); - pci_set_drvdata(pdev, NULL); free_netdev(netdev); return err; } -- 1.7.10.4