From: "Paul Rolland" <rol@witbe.net>
To: "'Jesse Brandeburg'" <jesse.brandeburg@intel.com>,
<linux-kernel@vger.kernel.org>
Cc: <netdev@vger.kernel.org>, <john.ronciak@intel.com>
Subject: Re: [2.4.32 - 2.6.15.4] e1000 - Fix mii interface
Date: Tue, 28 Feb 2006 11:46:31 +0100 [thread overview]
Message-ID: <001101c63c54$3d02f040$b600a8c0@cortex> (raw)
In-Reply-To: <Pine.WNT.4.63.0602271818570.284@jbrandeb-desk.amr.corp.intel.com>
Hello Jesse,
> spddplx += (mii_reg & 0x100)
> - ? FULL_DUPLEX :
> - HALF_DUPLEX;
> + ? DUPLEX_FULL :
> + DUPLEX_HALF;
As I said in my first mail, I didn't want to go that way as one of the
two DUPLEX_FULL or DUPLEX_HALF is defined as being 0, which prevents
detecting incorrect/incomplete initializations.
The problem I had came from :
mii-tool -F 100BaseTx-FD eth0
when at the same time the ethtool interface was OK.
But you are right, the change I made missed the second caller.
The correct change is yours, though for the reason I put above, I think
it'll make it harder to spot other bugs ;)
Well done,
Paul
prev parent reply other threads:[~2006-02-28 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060225085409.GA22456@infradead.org>
2006-02-25 10:08 ` [2.4.32 - 2.6.15.4] e1000 - Fix mii interface Paul Rolland
2006-02-26 10:42 ` Willy TARREAU
2006-02-26 11:39 ` Paul Rolland
2006-02-26 12:59 ` Jesper Juhl
2006-02-26 14:55 ` Paul Rolland
2006-02-26 15:00 ` Jesper Juhl
2006-02-26 15:12 ` Paul Rolland
2006-02-27 19:26 ` Jesse Brandeburg
[not found] ` <4807377b0602271234v4b6cdeecpbcf8d4a6ac51cd20@mail.gmail.com>
2006-02-28 2:31 ` Jesse Brandeburg
2006-02-28 10:46 ` Paul Rolland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101c63c54$3d02f040$b600a8c0@cortex' \
--to=rol@witbe.net \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).