From: "Venkat Yekkirala" <vyekkirala@trustedcs.com>
To: "'Eric Paris'" <eparis@parisplace.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <davem@davemloft.net>, <jamesm@namei.org>,
"Venkat Yekkirala" <vyekkirala@tcsfw4.tcs-sec.com>,
<cxzhang@watson.ibm.com>, <sds@tycho.nsa.gov>,
<latten@austin.ibm.com>
Subject: RE: [PATCH] xfrm_policy delete security check misplaced
Date: Mon, 5 Mar 2007 09:33:27 -0600 [thread overview]
Message-ID: <001301c75f3b$9efedb00$cc0a010a@tcssec.com> (raw)
In-Reply-To: <1172860190.31047.11.camel@localhost.localdomain>
> @@ -2552,7 +2550,7 @@ static int pfkey_spdget(struct sock
> *sk, struct sk_buff *skb, struct sadb_msg *h
> return -EINVAL;
>
> xp = xfrm_policy_byid(XFRM_POLICY_TYPE_MAIN, dir,
> pol->sadb_x_policy_id,
> - hdr->sadb_msg_type == SADB_X_SPDDELETE2);
> + hdr->sadb_msg_type ==
> SADB_X_SPDDELETE2, &err);
> if (xp == NULL)
> return -ENOENT;
I guess you meant to do this here?
else if (err)
return err;
Also, [Joy cc'd] deletions here needn't be audited?
next prev parent reply other threads:[~2007-03-05 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 18:29 [PATCH] xfrm_policy delete security check misplaced Eric Paris
2007-03-05 15:33 ` Venkat Yekkirala [this message]
2007-03-05 15:58 ` Venkat Yekkirala
2007-03-05 16:39 ` James Morris
2007-03-05 16:51 ` Eric Paris
2007-03-05 17:10 ` Venkat Yekkirala
2007-03-06 0:37 ` James Morris
2007-03-07 23:38 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-03-05 15:36 Venkat Yekkirala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001301c75f3b$9efedb00$cc0a010a@tcssec.com' \
--to=vyekkirala@trustedcs.com \
--cc=cxzhang@watson.ibm.com \
--cc=davem@davemloft.net \
--cc=eparis@parisplace.org \
--cc=jamesm@namei.org \
--cc=latten@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=vyekkirala@tcsfw4.tcs-sec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).