From mboxrd@z Thu Jan 1 00:00:00 1970 From: Franko Fang Subject: Re: PATCH 23/10]Optimize the upload speed for PPP connection. Date: Mon, 26 Oct 2009 10:44:39 +0800 Message-ID: <001401ca55e6$435c1e30$76900b0a@china.huawei.com> References: <4AE19780.3020507@gmail.com> <20091024.064603.249036129.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zihan@huawei.com, greg@kroah.com, haegar@sdinet.de To: David Miller , william.allen.simpson@gmail.com Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Thanks your advice. But generally, PAGE_SIZE is 4096, whether it is too large or not? If PAGE_SIZE is really appropriate, then I can resubmit the patch. Thanks very much. ----- Original Message ----- From: "David Miller" To: Cc: ; ; ; ; ; Sent: Saturday, October 24, 2009 9:46 PM Subject: Re: PATCH 23/10]Optimize the upload speed for PPP connection. > From: William Allen Simpson > Date: Fri, 23 Oct 2009 07:46:08 -0400 > >> Concur. I'd go further than that, my code usually made room for at >> least >> a full MTU (MRU) with HDLC escaping. To minimize context switches, >> that >> should be 3014 ((1500 MRU + 2 FCS + 4 header) * 2 escapes + 2 flags). >> >> Even in the old days, when memory was tight, context switches and >> interrupt >> time were more expensive, too. PPP is supposed to scale to OC-192. > > Actually I'd like to see ->obuf allocated externally and then > make it simply PAGE_SIZE. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/