* [PATCH 05/36] net: ethernet: 8390: remove unnecessary platform_set_drvdata()
@ 2013-05-07 4:18 Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 4:18 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, Jingoo Han, 'Jeff Kirsher'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/8390/ne.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/8390/ne.c b/drivers/net/ethernet/8390/ne.c
index 47618e5..b2e8405 100644
--- a/drivers/net/ethernet/8390/ne.c
+++ b/drivers/net/ethernet/8390/ne.c
@@ -849,7 +849,6 @@ static int ne_drv_remove(struct platform_device *pdev)
free_irq(dev->irq, dev);
release_region(dev->base_addr, NE_IO_EXTENT);
free_netdev(dev);
- platform_set_drvdata(pdev, NULL);
}
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 05/36] net: ethernet: 8390: remove unnecessary platform_set_drvdata()
@ 2013-05-28 4:53 Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-05-28 4:53 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, Jingoo Han
On Tuesday, May 07, 2013 1:19 PM, Jingoo Han wrote:
>
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Hi David,
I will squash everything down into one patch with the ACKs,
and send it again.
Best regards,
Jingoo Han
> ---
> drivers/net/ethernet/8390/ne.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/8390/ne.c b/drivers/net/ethernet/8390/ne.c
> index 47618e5..b2e8405 100644
> --- a/drivers/net/ethernet/8390/ne.c
> +++ b/drivers/net/ethernet/8390/ne.c
> @@ -849,7 +849,6 @@ static int ne_drv_remove(struct platform_device *pdev)
> free_irq(dev->irq, dev);
> release_region(dev->base_addr, NE_IO_EXTENT);
> free_netdev(dev);
> - platform_set_drvdata(pdev, NULL);
> }
> return 0;
> }
> --
> 1.7.2.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-28 4:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-07 4:18 [PATCH 05/36] net: ethernet: 8390: remove unnecessary platform_set_drvdata() Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-05-28 4:53 Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).