* net: usb: cdc_ncm: add support IFF_NOARP
@ 2013-01-08 13:14 Wei Shuai
2013-01-08 22:24 ` Alexey Orishko
2013-01-08 22:27 ` Bjørn Mork
0 siblings, 2 replies; 3+ messages in thread
From: Wei Shuai @ 2013-01-08 13:14 UTC (permalink / raw)
To: 'Greg Kroah-Hartman', 'Alexey Orishko',
'Hans Petter Selasky'
Cc: linux-usb, netdev
Hi Alexey,
Recently I met a Modem which cannot do ARP. But I found our
cdc_ncm_bind() function cannot handle this special case. Do you have any
plan to handle it?
static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf)
{
...
/* cannot do ARP */
dev->net->flags |= IFF_NOARP;
...
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: net: usb: cdc_ncm: add support IFF_NOARP
2013-01-08 13:14 net: usb: cdc_ncm: add support IFF_NOARP Wei Shuai
@ 2013-01-08 22:24 ` Alexey Orishko
2013-01-08 22:27 ` Bjørn Mork
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Orishko @ 2013-01-08 22:24 UTC (permalink / raw)
To: Wei Shuai
Cc: Greg Kroah-Hartman, Alexey Orishko, Hans Petter Selasky,
linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA
Hi,
On Tue, Jan 8, 2013 at 2:14 PM, Wei Shuai <cpuwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Alexey,
> Recently I met a Modem which cannot do ARP. But I found our
> cdc_ncm_bind() function cannot handle this special case. Do you have any
> plan to handle it?
>
>
> static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf)
> {
> ...
> /* cannot do ARP */
> dev->net->flags |= IFF_NOARP;
> ...
> }
All devices I have can handle ARP, so there was no need for such a
feature in the driver..
Last version of the driver also supports MBIM devices, which have no
MAC address at all
since payload is a pure IP, While considering changes this shall be
taken into account.
There is no way to find out if ARP is supported or not by looking at
CDC Ethernet
Networking or NCM Functional Descriptors. If control that flag to be
added to the driver,
it shall be based on matching VID/PID.
Regards,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: net: usb: cdc_ncm: add support IFF_NOARP
2013-01-08 13:14 net: usb: cdc_ncm: add support IFF_NOARP Wei Shuai
2013-01-08 22:24 ` Alexey Orishko
@ 2013-01-08 22:27 ` Bjørn Mork
1 sibling, 0 replies; 3+ messages in thread
From: Bjørn Mork @ 2013-01-08 22:27 UTC (permalink / raw)
To: Wei Shuai, 'Greg Kroah-Hartman', 'Alexey Orishko',
'Hans Petter Selasky'
Cc: linux-usb, netdev
Wei Shuai <cpuwolf@gmail.com> wrote:
>Hi Alexey,
> Recently I met a Modem which cannot do ARP. But I found our
>cdc_ncm_bind() function cannot handle this special case. Do you have
>any
>plan to handle it?
>
>
>static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf)
>{
> ...
> /* cannot do ARP */
> dev->net->flags |= IFF_NOARP;
> ...
>}
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
Are you sure all CDC NCM devices will handle this? Maybe the buggy device need a device specific quirk instead?
Bjørn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-08 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 13:14 net: usb: cdc_ncm: add support IFF_NOARP Wei Shuai
2013-01-08 22:24 ` Alexey Orishko
2013-01-08 22:27 ` Bjørn Mork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).