From: Jingoo Han <jg1.han@samsung.com>
To: "'David S. Miller'" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, 'Maxime Bizon' <mbizon@freebox.fr>,
'Florian Fainelli' <florian@openwrt.org>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: [PATCH 2/2] ethernet: broadcom: remove unnecessary platform_set_drvdata()
Date: Thu, 22 Aug 2013 10:57:20 +0900 [thread overview]
Message-ID: <001a01ce9eda$efcfdf80$cf6f9e80$%han@samsung.com> (raw)
In-Reply-To: <001901ce9eda$a9351310$fb9f3930$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index b1bcd4b..ca963d4 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -2836,7 +2836,6 @@ static int bcm_enetsw_remove(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));
- platform_set_drvdata(pdev, NULL);
free_netdev(dev);
return 0;
}
--
1.7.10.4
next prev parent reply other threads:[~2013-08-22 1:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 1:55 [PATCH 1/2] ethernet: moxa: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 1:57 ` Jingoo Han [this message]
2013-08-22 22:12 ` [PATCH 2/2] ethernet: broadcom: " David Miller
2013-08-22 22:12 ` [PATCH 1/2] ethernet: moxa: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001a01ce9eda$efcfdf80$cf6f9e80$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=mbizon@freebox.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).