From: "Gao Feng" <gfree.wind@foxmail.com>
To: "'Neal Cardwell'" <ncardwell@google.com>
Cc: "'David Miller'" <davem@davemloft.net>,
"'Alexey Kuznetsov'" <kuznet@ms2.inr.ac.ru>,
"'James Morris'" <jmorris@namei.org>,
"'Patrick McHardy'" <kaber@trash.net>,
"'Netdev'" <netdev@vger.kernel.org>
Subject: RE: [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST
Date: Thu, 6 Apr 2017 23:11:23 +0800 [thread overview]
Message-ID: <001c01d2aee8$0e807130$2b815390$@foxmail.com> (raw)
In-Reply-To: <CADVnQy=5GXBQzvDtbxQp-0ndJ1KphcxkY42mHsDPST0+sMGw2A@mail.gmail.com>
Hi Neal
> -----Original Message-----
>
> On Thu, Apr 6, 2017 at 10:05 AM, Gao Feng <gfree.wind@foxmail.com> wrote:
> > If so, we should increase the TCP_MIB_OUTRSTS too when fail to alloc skb.
> > When machine is overloaded and mem is exhausted, it may fail to alloc skb.
>
> Moving the increment of TCP_MIB_OUTRSTS to the top of
> tcp_send_active_reset() sounds fine to me.
>
> neal
I sent the v2 patch, and didn't change the tcp_v4_send_reset and tcp_v6_send_response.
Because I think they are only used during connecting. The rst count is not as important as
tcp_send_active_reset.
Regards
Feng
.
next prev parent reply other threads:[~2017-04-06 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 13:35 [PATCH net 1/1] net: tcp: Don't increase the TCP_MIB_OUTRSTS when fail to transmit RST gfree.wind
2017-04-06 14:00 ` Neal Cardwell
2017-04-06 14:05 ` Gao Feng
2017-04-06 14:08 ` Neal Cardwell
2017-04-06 15:11 ` Gao Feng [this message]
2017-04-06 15:24 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001c01d2aee8$0e807130$2b815390$@foxmail.com' \
--to=gfree.wind@foxmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox