From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: "'Simon Horman'" <horms@kernel.org>, <netdev@vger.kernel.org>,
"'Andrew Lunn'" <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Jakub Kicinski'" <kuba@kernel.org>,
"'Paolo Abeni'" <pabeni@redhat.com>,
"'Russell King \(Oracle\)'" <rmk+kernel@armlinux.org.uk>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next 1/3] net: txgbe: expend SW-FW mailbox buffer size to identify QSFP module
Date: Sat, 11 Oct 2025 09:57:24 +0800 [thread overview]
Message-ID: <002301dc3a52$63a80fc0$2af82f40$@trustnetic.com> (raw)
In-Reply-To: <f4c6d749-020a-46ca-844b-558542113327@lunn.ch>
On Fri, Oct 10, 2025 9:53 PM, Andrew Lunn wrote:
> On Fri, Oct 10, 2025 at 03:42:00PM +0800, Jiawen Wu wrote:
> > On Mon, Sep 29, 2025 9:52 PM, Simon Horman wrote:
> > > On Sun, Sep 28, 2025 at 05:39:21PM +0800, Jiawen Wu wrote:
> > > > In order to identify 40G and 100G QSFP modules, expend mailbox buffer
> > > > size to store more information read from the firmware.
> > >
> > > Hi,
> > >
> > > I see that the message size is increased by 4 bytes,
> > > including two new one-byte fields.
> > > But I don't see how that is used by this patchset.
> > > Could you expand on this a little?
> >
> > It is used for QSFP modules, I haven't added the part of these modules yet.
> > But the firmware was changed. So when using the new firmware, the module
> > cannot be identified due to incorrect length of mailbox buffer.
>
> And with old firmware? Can you tell the end of the message has not
> been filled in with old firmware?
The old firmware has not been released to the public, so there is no need
to worry about the compatibility on the old firmware.
next prev parent reply other threads:[~2025-10-11 1:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 9:39 [PATCH net-next 0/3] TXGBE feat new AML firmware Jiawen Wu
2025-09-28 9:39 ` [PATCH net-next 1/3] net: txgbe: expend SW-FW mailbox buffer size to identify QSFP module Jiawen Wu
2025-09-29 13:52 ` Simon Horman
2025-10-10 7:42 ` Jiawen Wu
2025-10-10 13:52 ` Andrew Lunn
2025-10-11 1:57 ` Jiawen Wu [this message]
2025-10-11 14:20 ` Andrew Lunn
2025-09-28 9:39 ` [PATCH net-next 2/3] net: txgbe: optimize the flow to setup PHY for AML devices Jiawen Wu
2025-09-30 1:39 ` Jakub Kicinski
2025-10-10 7:48 ` Jiawen Wu
2025-10-10 13:51 ` Andrew Lunn
2025-10-11 1:53 ` Jiawen Wu
2025-09-28 9:39 ` [PATCH net-next 3/3] net: txgbe: rename txgbe_get_phy_link() Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002301dc3a52$63a80fc0$2af82f40$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).