From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: [PATCH 1/2] atm: he: remove unnecessary pci_set_drvdata() Date: Mon, 25 Nov 2013 12:31:37 +0900 Message-ID: <002801cee98e$d93e9c30$8bbbd490$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: 'Chas Williams' , netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net, 'Jingoo Han' To: "'David S. Miller'" Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:21957 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366Ab3KYDbj (ORCPT ); Sun, 24 Nov 2013 22:31:39 -0500 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MWS006QAV4QQL70@mailout4.samsung.com> for netdev@vger.kernel.org; Mon, 25 Nov 2013 12:31:38 +0900 (KST) Content-language: ko Sender: netdev-owner@vger.kernel.org List-ID: The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/atm/he.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 8557adc..aa6be26 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -419,7 +419,6 @@ static void he_remove_one(struct pci_dev *pci_dev) atm_dev_deregister(atm_dev); kfree(he_dev); - pci_set_drvdata(pci_dev, NULL); pci_disable_device(pci_dev); } -- 1.7.10.4