From: "ravinandan arakali" <ravinandan.arakali@s2io.com>
To: "'Jeff Garzik'" <jgarzik@pobox.com>,
"'Leonid Grossman'" <leonid.grossman@s2io.com>
Cc: <netdev@oss.sgi.com>, "'Stephen Hemminger'" <shemminger@osdl.org>,
"'Christoph Hellwig'" <hch@infradead.org>,
<raghavendra.koushik@s2io.com>
Subject: RE: Submission #3 for S2io 10GbE driver
Date: Fri, 12 Mar 2004 13:55:37 -0800 [thread overview]
Message-ID: <002f01c4087c$c1df99c0$6610100a@S2IOtech.com> (raw)
In-Reply-To: <4040F866.9040200@pobox.com>
Hi Jeff,
Regarding comment #15, we don't think locking is required, because we
just reflect what ever the statistics block is reflecting at the current
moment.
Thanks,
Ravi
-----Original Message-----
From: Jeff Garzik [mailto:jgarzik@pobox.com]
Sent: Saturday, February 28, 2004 12:22 PM
To: Leonid Grossman
Cc: netdev@oss.sgi.com; 'Stephen Hemminger'; 'Christoph Hellwig';
'ravinandan arakali'; raghavendra.koushik@s2io.com
Subject: Re: Submission #3 for S2io 10GbE driver
Looking a lot better. A few merge issues remain, and some operational
ones as well. There are 39 issues in this review, but IMO they are
mostly minor issues that don't require much thought or work.
Comments:
<snipped>
15) does s2io_get_stats need locking?
<snipped>
next prev parent reply other threads:[~2004-03-12 21:55 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 21:22 FW: Submission for S2io 10GbE driver Leonid Grossman
2004-01-23 21:54 ` Stephen Hemminger
2004-01-23 21:58 ` Leonid Grossman
2004-01-23 22:22 ` FW: " Andi Kleen
2004-01-24 0:21 ` Stephen Hemminger
2004-01-27 5:32 ` Leonid Grossman
2004-01-27 6:08 ` Jeff Garzik
2004-01-27 6:19 ` Leonid Grossman
2004-02-04 20:44 ` FW: " Leonid Grossman
2004-02-05 0:49 ` Grant Grundler
2004-02-05 1:14 ` Leonid Grossman
2004-02-16 21:16 ` Leonid Grossman
2004-02-16 22:12 ` Jeff Garzik
2004-02-16 23:53 ` Leonid Grossman
2004-02-17 0:11 ` Christoph Hellwig
2004-02-17 0:16 ` Stephen Hemminger
2004-02-28 15:08 ` Submission #3 " Leonid Grossman
2004-02-28 20:21 ` Jeff Garzik
2004-03-12 21:55 ` ravinandan arakali [this message]
2004-03-13 2:30 ` Jeff Garzik
2004-03-20 4:35 ` Submission #4 " Leonid Grossman
2004-03-20 9:56 ` Jeff Garzik
2004-03-20 10:00 ` Jeff Garzik
2004-03-22 19:36 ` ravinandan arakali
2004-03-22 19:43 ` Jeff Garzik
2004-03-20 10:48 ` Christoph Hellwig
2004-02-05 1:32 ` FW: Submission " Andi Kleen
2004-02-05 1:51 ` Anton Blanchard
2004-02-05 2:46 ` Leonid Grossman
2004-02-05 3:25 ` Anton Blanchard
2004-02-05 9:27 ` Jeff Garzik
2004-02-05 9:29 ` Jeff Garzik
2004-02-05 22:09 ` Leonid Grossman
2004-02-05 22:34 ` Grant Grundler
2004-02-05 23:23 ` Jes Sorensen
2004-01-24 0:38 ` Francois Romieu
2004-01-24 3:14 ` jamal
2004-01-24 5:10 ` Leonid Grossman
2004-01-24 14:58 ` Andi Kleen
2004-01-24 17:54 ` jamal
2004-01-24 19:52 ` Leonid Grossman
2004-01-25 19:07 ` jamal
2004-01-25 17:56 ` Leonid Grossman
2004-01-24 18:00 ` jamal
2004-01-24 20:04 ` Leonid Grossman
2004-01-25 19:14 ` jamal
-- strict thread matches above, loose matches on Subject: below --
2004-03-01 6:21 Submission #3 " raghavendra.koushik
2004-03-01 6:53 ` Jeff Garzik
2004-03-01 13:05 raghavendra.koushik
2004-03-01 15:24 ` Leonid Grossman
2004-03-02 13:46 raghavendra.koushik
2004-03-02 18:47 ` Jeff Garzik
2004-03-02 21:16 Feldman, Scott
2004-03-02 21:21 ` Jeff Garzik
2004-03-02 21:33 ` Ben Greear
2004-03-02 21:38 ` Jeff Garzik
2004-03-02 21:47 Feldman, Scott
2004-03-02 22:21 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01c4087c$c1df99c0$6610100a@S2IOtech.com' \
--to=ravinandan.arakali@s2io.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=leonid.grossman@s2io.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@s2io.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).