From: "jungwon park" <jwpark2@whitecode.co.kr>
To: "'Florian Westphal'" <fw@strlen.de>
Cc: <netdev@vger.kernel.org>
Subject: RE: GRO issue with kernel 3.4.94 (icmp fragmentation needed)
Date: Fri, 27 Jun 2014 19:07:25 +0900 [thread overview]
Message-ID: <002f01cf91ef$98792080$c96b6180$@whitecode.co.kr> (raw)
In-Reply-To: <20140627090525.GA30075@breakpoint.cc>
Good!
When I apply the patch(ipv4: set transport header earlier), there is no
problem.
Thanks, Florian.
-----Original Message-----
From: Florian Westphal [mailto:fw@strlen.de]
Sent: Friday, June 27, 2014 6:05 PM
To: jungwon park
Cc: netdev@vger.kernel.org
Subject: Re: GRO issue with kernel 3.4.94 (icmp fragmentation needed)
jungwon park <jwpark2@whitecode.co.kr> wrote:
> When using the linux router is turned on GRO, router send the
> 'fragmentation needed' packets to the sender.
Indeed 8-(
> When I turned off GRO, the router operate normally, and there is no
problem.
> and with 3.4.91 kernel, the router has no problem.
>
> I doubt 'ipv4: ip_forward: fix inverted local_df test' patch.
> (http://patchwork.ozlabs.org/patch/345509/)
> When I revert this patch, the router has no problem.
Can you please cherry-pick following patch on top of vanilla 3.4.92?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2
1d1196a35f5686c4323e42a62fdb4b23b0ab4a3
commit 21d1196a35f5686c4323e42a62fdb4b23b0ab4a3
Author: Eric Dumazet <edumazet@google.com>
ipv4: set transport header earlier
I think that should fix this bug, it should apply cleanly on top of 3.4.y
tree.
[ patch is in 3.11, also backported to 3.10.y tree ]
The problem is that, when dealing with GRO packets, we try to determine the
size of the individual packets. To do this, we rely on the transport
header.
Unfortunately the transport header is not set for the forward path in 3.4,
so we look at the network header instead.
next prev parent reply other threads:[~2014-06-27 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 23:42 GRO issue with kernel 3.4.94 (icmp fragmentation needed) jungwon park
2014-06-27 9:05 ` Florian Westphal
2014-06-27 10:07 ` jungwon park [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-11 15:12 Fwd: " Thomas Jarosch
2014-07-30 0:22 ` Greg KH
2014-07-30 6:37 ` Florian Westphal
2014-07-31 19:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01cf91ef$98792080$c96b6180$@whitecode.co.kr' \
--to=jwpark2@whitecode.co.kr \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).