From: "Subash Abhinov Kasiviswanathan" <subashab@codeaurora.org>
To: "'Alexander Duyck'" <alexander.duyck@gmail.com>,
"'David Miller'" <davem@davemloft.net>
Cc: "'Eric Dumazet'" <eric.dumazet@gmail.com>,
"'Alex Duyck'" <aduyck@mirantis.com>,
"'Herbert Xu'" <herbert@gondor.apana.org.au>,
"'Tom Herbert'" <tom@herbertland.com>,
"'Jesse Gross'" <jesse@kernel.org>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Netdev'" <netdev@vger.kernel.org>
Subject: RE: [net PATCH 2/2] ipv4/GRO: Make GRO conform to RFC 6864
Date: Fri, 1 Apr 2016 15:13:42 -0600 [thread overview]
Message-ID: <003901d18c5b$5f6f5760$1e4e0620$@codeaurora.org> (raw)
In-Reply-To: <CAKgT0UcLvAF9gTzcaR=GZyTkM2UQ6ymDmnisjgZiG8hTE+PdLA@mail.gmail.com>
| For transmit we can leave the IP ID code as is. For receive we should not be
| snooping into the IP ID for any frames that have the DF bit set as devices
| that have adopted RFC 6864 on their transmit path will end up causing issues.
Currently, GRO does not coalesce TCP packets originating from nodes which do IPv6 to IPv4 translation.
These packets have DF set to 1 and IP ID set 0 according to https://tools.ietf.org/html/rfc6145#page-17
With this patch, we should be able to see coalescing happen for those cases as well.
next prev parent reply other threads:[~2016-04-01 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 18:05 [net PATCH 0/2] Fixes for GRO and GRE tunnels Alexander Duyck
2016-04-01 18:05 ` [net PATCH 1/2] GRE: Disable segmentation offloads w/ CSUM and we are encapsulated via FOU Alexander Duyck
2016-04-01 18:05 ` [net PATCH 2/2] ipv4/GRO: Make GRO conform to RFC 6864 Alexander Duyck
2016-04-01 18:49 ` Eric Dumazet
2016-04-01 19:24 ` David Miller
2016-04-01 19:58 ` Alexander Duyck
2016-04-01 21:13 ` Subash Abhinov Kasiviswanathan [this message]
2016-04-02 2:16 ` David Miller
2016-04-02 2:21 ` Eric Dumazet
2016-04-02 20:26 ` Rick Jones
2016-04-02 6:02 ` Alexander Duyck
2016-04-02 1:57 ` Herbert Xu
2016-04-02 2:15 ` Eric Dumazet
2016-04-02 2:19 ` Herbert Xu
2016-04-02 2:26 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003901d18c5b$5f6f5760$1e4e0620$@codeaurora.org' \
--to=subashab@codeaurora.org \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).