netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ravinandan Arakali" <ravinandan.arakali@s2io.com>
To: "'Jeff Garzik'" <jgarzik@pobox.com>
Cc: <netdev@oss.sgi.com>, <leonid.grossman@s2io.com>,
	<raghavendra.koushik@s2io.com>, <rapuru.sriram@s2io.com>
Subject: RE: Patch submission for S2io Xframe driver to 2.6 kernel
Date: Mon, 13 Sep 2004 15:45:55 -0700	[thread overview]
Message-ID: <003c01c499e3$6e910440$a010100a@S2IOtech.com> (raw)
In-Reply-To: 

Hi Jeff,
>From the time we generated the patch to the latest kernel version(2.6.8.1),
there seems to be a one line change(see change below) in s2io.c(done by 
one of the community developers). So, our patch may not apply cleanly. 
If you want us to regenerate the patch, we'll do it but the patch itself
is still valid. Following is the change done in the latest 2.6.8.1 kernel:

1428c1428
< 		skb = dev_alloc_skb(size + HEADER_ALIGN_LAYER_3);
---
> 		skb = dev_alloc_skb(size + NET_IP_ALIGN);
1434c1434
< 		skb_reserve(skb, HEADER_ALIGN_LAYER_3);
---
> 		skb_reserve(skb, NET_IP_ALIGN);

Thanks,
Ravi

-----Original Message-----
From: Ravinandan Arakali [mailto:ravinandan.arakali@s2io.com]
Sent: Monday, September 13, 2004 10:10 AM
To: 'Jeff Garzik'
Cc: 'netdev@oss.sgi.com'; 'leonid.grossman@s2io.com';
'raghavendra.koushik@s2io.com'; 'rapuru.sriram@s2io.com'
Subject: RE: Patch submission for S2io Xframe driver to 2.6 kernel


Hi Jeff,
Attached is the patch with the first round comments incorporated.
In addition, this patch contains
Some fixes related to 32-bit systems.
Few fixes related to Rx path in NAPI.

Thanks to all for the comments.

Pls review this patch as well and come back with your comments.

Regards,
Ravi

-----Original Message-----
From: Jeff Garzik [mailto:jgarzik@pobox.com]
Sent: Saturday, August 28, 2004 4:37 PM
To: ravinandan.arakali@s2io.com
Cc: netdev@oss.sgi.com; leonid.grossman@s2io.com;
raghavendra.koushik@s2io.com
Subject: Re: Patch submission for S2io Xframe driver to 2.6 kernel


is there a follow-up patch addressing the comments ?

             reply	other threads:[~2004-09-13 22:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-13 22:45 Ravinandan Arakali [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-08-14  0:19 Patch submission for S2io Xframe driver to 2.6 kernel Ravinandan Arakali
2004-08-21  6:21 ` Randy.Dunlap
2004-08-21 23:43 ` Francois Romieu
2004-08-28 23:36 ` Jeff Garzik
2004-08-29  5:53   ` Leonid Grossman
2004-08-30 17:25     ` Ravinandan Arakali
2004-09-13 17:09   ` Ravinandan Arakali
2004-09-17  0:38     ` Jeff Garzik
2004-09-17  0:53       ` Ravinandan Arakali
2004-09-17  0:52         ` Jeff Garzik
2004-09-17  3:07           ` Randy.Dunlap
2004-09-28  0:42           ` Ravinandan Arakali
2004-09-28  3:54             ` Randy.Dunlap
2004-09-28 15:05             ` Jeff Garzik
2004-09-28 17:13               ` Ravinandan Arakali
2004-10-06 20:14               ` Ravinandan Arakali
2004-10-06 20:09                 ` Jeff Garzik
2004-10-06 20:20                   ` Francois Romieu
2004-10-06 22:52                     ` Jeff Garzik
2004-09-17  3:58     ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003c01c499e3$6e910440$a010100a@S2IOtech.com' \
    --to=ravinandan.arakali@s2io.com \
    --cc=jgarzik@pobox.com \
    --cc=leonid.grossman@s2io.com \
    --cc=netdev@oss.sgi.com \
    --cc=raghavendra.koushik@s2io.com \
    --cc=rapuru.sriram@s2io.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).