From: Jingoo Han <jg1.han@samsung.com>
To: "'David S. Miller'" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, 'Jingoo Han' <jg1.han@samsung.com>,
'Mirko Lindner' <mlindner@marvell.com>,
'Stephen Hemminger' <stephen@networkplumber.org>
Subject: [PATCH 09/15] net: skge: remove unnecessary pci_set_drvdata()
Date: Mon, 21 Oct 2013 11:13:58 +0900 [thread overview]
Message-ID: <004101cece03$337a9b60$9a6fd220$%han@samsung.com> (raw)
In-Reply-To: <003801cece02$6abb0160$40310420$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/ethernet/marvell/skge.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index ecc7f7b..5978461 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -4046,7 +4046,6 @@ err_out_free_regions:
pci_release_regions(pdev);
err_out_disable_pdev:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
err_out:
return err;
}
@@ -4090,7 +4089,6 @@ static void skge_remove(struct pci_dev *pdev)
iounmap(hw->regs);
kfree(hw);
- pci_set_drvdata(pdev, NULL);
}
#ifdef CONFIG_PM_SLEEP
--
1.7.10.4
next prev parent reply other threads:[~2013-10-21 2:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 2:08 [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 2 Jingoo Han
2013-10-21 2:09 ` [PATCH 01/15] net: tulip: remove unnecessary pci_set_drvdata() Jingoo Han
2013-10-21 2:10 ` [PATCH 02/15] net: sundance: " Jingoo Han
2013-10-21 2:11 ` [PATCH 03/15] net: dl2k: " Jingoo Han
2013-10-21 2:11 ` [PATCH 04/15] net: be2net: " Jingoo Han
2013-10-21 2:12 ` [PATCH 05/15] net: fealnx: " Jingoo Han
2013-10-21 2:12 ` [PATCH 06/15] net: icplus: " Jingoo Han
2013-10-21 2:13 ` [PATCH 07/15] net: e100: " Jingoo Han
2013-10-21 2:13 ` [PATCH 08/15] net: jme: " Jingoo Han
2013-10-21 2:13 ` Jingoo Han [this message]
2013-10-21 2:14 ` [PATCH 10/15] net: sky2: " Jingoo Han
2013-10-21 2:14 ` [PATCH 11/15] net: ksz884x: " Jingoo Han
2013-10-21 2:15 ` [PATCH 12/15] net: myri10ge: " Jingoo Han
2013-10-21 2:15 ` [PATCH 13/15] net: natsemi: " Jingoo Han
2013-10-21 2:16 ` [PATCH 14/15] net: neterion: " Jingoo Han
2013-10-21 2:17 ` [PATCH 15/15] net: packetengines: " Jingoo Han
2013-10-21 21:21 ` [PATCH 00/15] net: ethernet: remove unnecessary pci_set_drvdata() part 2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004101cece03$337a9b60$9a6fd220$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=davem@davemloft.net \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).