From: "John Efstathiades" <john.efstathiades@pebblebay.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <UNGLinuxDriver@microchip.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <Woojung.Huh@microchip.com>
Subject: RE: [PATCH net-next 1/9] lan78xx: add NAPI interface support
Date: Wed, 10 Feb 2021 15:23:30 -0000 [thread overview]
Message-ID: <004601d6ffc0$bbf46c90$33dd45b0$@pebblebay.com> (raw)
In-Reply-To: <YBv4VVhsswYtX6qc@lunn.ch>
Apologies for taking a while to reply.
> This patch is big. Given your description, it sounds like it can be
> split up. That will make reviewing a lot easier.
The patch changes the way the driver works in a fundamental way so finding
ways to split out the modifications into self-contained parts might be
tricky. I need to discuss with colleagues on how to best do this.
If that's not possible or results in some ugly patches do you have any
suggestions how we can make it easier for reviewers to understand and review
the patch?
> It would also be nice to include in the 0/X patch some performance
> data.
Yes, I can do that.
Thanks for the other comments. I'll sort out the issues before preparing an
update but it will take a few weeks to re-test the driver and prepare a new
patch.
John
next prev parent reply other threads:[~2021-02-10 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 11:31 [PATCH net-next 0/9] LAN7800 USB network interface driver NAPI support John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 1/9] lan78xx: add NAPI interface support John Efstathiades
2021-02-04 20:43 ` Jesse Brandeburg
2021-02-10 16:11 ` John Efstathiades
[not found] ` <YBv4VVhsswYtX6qc@lunn.ch>
2021-02-10 15:23 ` John Efstathiades [this message]
2021-02-10 16:31 ` Andrew Lunn
2021-02-04 11:31 ` [PATCH net-next 2/9] lan78xx: disable U1/U2 power state transitions John Efstathiades
[not found] ` <YBv5S3OVWnPX5Y+M@lunn.ch>
2021-02-10 15:27 ` John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 3/9] lan78xx: fix USB errors and packet loss on suspend/resume John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 4/9] lan78xx: disable MAC address filter before updating entry John Efstathiades
[not found] ` <YBv6tF1caI7L96sW@lunn.ch>
2021-02-10 15:33 ` John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 5/9] lan78xx: fix race condition in PHY handling causing kernel lock up John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 6/9] lan78xx: reduce number of register access failure warnings John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 7/9] lan78xx: set maximum MTU John Efstathiades
[not found] ` <YBv6/zr82VZcgGMG@lunn.ch>
2021-02-10 15:35 ` John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 8/9] lan78xx: fix exception on link speed change John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 9/9] lan78xx: remove set but unused 'ret' variable John Efstathiades
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004601d6ffc0$bbf46c90$33dd45b0$@pebblebay.com' \
--to=john.efstathiades@pebblebay.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).