From: "John Efstathiades" <john.efstathiades@pebblebay.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <UNGLinuxDriver@microchip.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <Woojung.Huh@microchip.com>
Subject: RE: [PATCH net-next 4/9] lan78xx: disable MAC address filter before updating entry
Date: Wed, 10 Feb 2021 15:33:27 -0000 [thread overview]
Message-ID: <004c01d6ffc2$1fd9e400$5f8dac00$@pebblebay.com> (raw)
In-Reply-To: <YBv6tF1caI7L96sW@lunn.ch>
> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: 04 February 2021 13:46
>
> On Thu, Feb 04, 2021 at 11:31:16AM +0000, John Efstathiades wrote:
> > Disable the station MAC address entry in the perfect address filter
> > table before updating the table entry with a new MAC address.
>
> This seems like a real fix. Please base this on net, not net-next, and
> add a Fixes: tag.
Thanks, I'll do that.
> > - /* Added to support MAC address changes */
> > - lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
> > - lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
> > + /* The station MAC address in the perfect address filter table
> > + * must also be updated to ensure frames are received
> > + */
> > + ret = lan78xx_write_reg(dev, MAF_HI(0), 0);
> > + ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
> > + ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
>
> Why bother with ret is you are going to 1) overwrite it, 2) ignore it!
This is a side-effect of my rebase on the latest net-next tree and linked to
patch 9/9 in this set, which you also commented on.
I need to change the way I rebased my work on the latest driver code so this
goes away.
John
next prev parent reply other threads:[~2021-02-10 15:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 11:31 [PATCH net-next 0/9] LAN7800 USB network interface driver NAPI support John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 1/9] lan78xx: add NAPI interface support John Efstathiades
2021-02-04 20:43 ` Jesse Brandeburg
2021-02-10 16:11 ` John Efstathiades
[not found] ` <YBv4VVhsswYtX6qc@lunn.ch>
2021-02-10 15:23 ` John Efstathiades
2021-02-10 16:31 ` Andrew Lunn
2021-02-04 11:31 ` [PATCH net-next 2/9] lan78xx: disable U1/U2 power state transitions John Efstathiades
[not found] ` <YBv5S3OVWnPX5Y+M@lunn.ch>
2021-02-10 15:27 ` John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 3/9] lan78xx: fix USB errors and packet loss on suspend/resume John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 4/9] lan78xx: disable MAC address filter before updating entry John Efstathiades
[not found] ` <YBv6tF1caI7L96sW@lunn.ch>
2021-02-10 15:33 ` John Efstathiades [this message]
2021-02-04 11:31 ` [PATCH net-next 5/9] lan78xx: fix race condition in PHY handling causing kernel lock up John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 6/9] lan78xx: reduce number of register access failure warnings John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 7/9] lan78xx: set maximum MTU John Efstathiades
[not found] ` <YBv6/zr82VZcgGMG@lunn.ch>
2021-02-10 15:35 ` John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 8/9] lan78xx: fix exception on link speed change John Efstathiades
2021-02-04 11:31 ` [PATCH net-next 9/9] lan78xx: remove set but unused 'ret' variable John Efstathiades
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004c01d6ffc2$1fd9e400$5f8dac00$@pebblebay.com' \
--to=john.efstathiades@pebblebay.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).