From: "Peter Huang (Peng)" <peter.huangpeng@huawei.com>
To: 'Eric Dumazet' <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, harry.majun@huawei.com,
zhoukang7@huawei.com, 'netdev' <netdev@vger.kernel.org>
Subject: 答复: 答复: 答复: [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops.
Date: Sat, 31 Mar 2012 09:26:50 +0800 [thread overview]
Message-ID: <004d01cd0edd$593f3bd0$0bbdb370$%huangpeng@huawei.com> (raw)
In-Reply-To: <1333020682.2325.517.camel@edumazet-glaptop>
> > >Check net/bridge/br_netfilter.c and commits e688a6048076 (net: introduce
> > >DST_NOPEER dst flag ) 4adf0af6818f3ea5 (bridge: send correct MTU value
> > >in PMTU (revised))
Hi, Eric
I confirmed the patch contents again.
For our case, NF_INET_PRE_ROUTING is involved, not NF_BR_LOCAL_IN.
It seems pre-routing is not included in the patch you mentioned.
BTW, our pkts are all ipv6 DHCP pkts(with MAC 33 33 00 01 00 02).
We verified the patch bellow, and this works fine, no WARN_ON happened.
--------------------------------
Peter Huang(peng)
> On Thu, 2012-03-29 at 17:38 +0800, Peter Huang (Peng) wrote:
> > Thks for your mail.
> >
> > >Check net/bridge/br_netfilter.c and commits e688a6048076 (net: introduce
> > >DST_NOPEER dst flag ) 4adf0af6818f3ea5 (bridge: send correct MTU value
> > >in PMTU (revised))
> >
> > This patch already included in kernel-3.3, but for our case, virtual tap device's delayed
> > Deletion will also cause kernel oops even in kernel3.3.
>
> I was suggesting you take a look at the commit content ;)
>
> Then you can see the code in br_nf_local_in(), a bit cleaner than yours.
>
next prev parent reply other threads:[~2012-03-31 1:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <002501cd0d74$317fd100$947f7300$%huangpeng@huawei.com>
2012-03-29 6:36 ` [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops Eric Dumazet
2012-03-29 6:40 ` 答复: " Peter Huang (Peng)
2012-03-29 8:52 ` Eric Dumazet
2012-03-29 9:38 ` 答复: " Peter Huang (Peng)
2012-03-29 11:31 ` Eric Dumazet
2012-03-29 11:41 ` 答复: " Peter Huang (Peng)
2012-03-31 1:26 ` Peter Huang (Peng) [this message]
2012-03-31 5:41 ` Eric Dumazet
2012-03-31 7:29 ` 答复: " Peter Huang (Peng)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004d01cd0edd$593f3bd0$0bbdb370$%huangpeng@huawei.com' \
--to=peter.huangpeng@huawei.com \
--cc=eric.dumazet@gmail.com \
--cc=harry.majun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhoukang7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).