From: Johannes Zink <j.zink@pengutronix.de>
To: Simon Horman <horms@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
patchwork-jzi@pengutronix.de, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index
Date: Tue, 17 Oct 2023 11:12:53 +0200 [thread overview]
Message-ID: <004d6ce9-7d15-4944-b31c-c9e628e7483a@pengutronix.de> (raw)
In-Reply-To: <20231014144428.GA1386676@kernel.org>
Hi Simon,
On 10/14/23 16:44, Simon Horman wrote:
> On Thu, Oct 12, 2023 at 11:02:13AM +0200, Johannes Zink wrote:
>> The stmmac supports up to 4 auxiliary snapshots that can be enabled by
>> setting the appropriate bits in the PTP_ACR bitfield.
>>
>> Previously instead of setting the bits, a fixed value was written to
>> this bitfield instead of passing the appropriate bitmask.
>>
>> Now the correct bit is set according to the ptp_clock_request.extts_index
>> passed as a parameter to stmmac_enable().
>>
>> Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping")
>> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
>
> Hi Johannes,
>
> The fix language of the subject and presence of a fixes tag implies that
> this is a bug fix. But it's not clear to me that this is resolving
> bug that manifests as a problem.
Thank you for taking your time to read through the series. This series is
somewhere in the realm between "fixing some stuff added previously (and never
worked)" and "filling the gaps/adding a new feature in some template code that
never worked as intended". However, I do not have strong opinions about this.
If you prefer to have the commits reworded, I will just wait a bit more for any
additional feedback and resend the series with the commit messages reworded+
fixes, should any be required.
>
> If it is a bug fix then it should probably be targeted at 'net',
> creating a dependency for the remainder of this series.
>
> On the other hand, if it is not a bug fix then perhaps it is best to
> update the subject and drop the Fixes tag.
I added the fixes-Tag in order to make code archeology easier, but as it may
trigger picks to stable branches (which is not required imho), I have no
objections to dropping it for a v2.
>
> I'm no expert on stmmac, but the rest of the series looks good to me.
>
> ...
>
that's good news. thx for looking through the series.
Best regards
Johannes
--
Pengutronix e.K. | Johannes Zink |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-10-17 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 9:02 [PATCH net-next 0/5] net: stmmac: fix PPS input indexing Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 1/5] net: stmmac: simplify debug message on stmmac_enable() Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 2/5] net: stmmac: fix PPS capture input index Johannes Zink
2023-10-14 14:44 ` Simon Horman
2023-10-17 9:12 ` Johannes Zink [this message]
2023-10-17 15:26 ` Jakub Kicinski
2023-10-17 20:27 ` Marc Kleine-Budde
2023-10-17 23:50 ` Jakub Kicinski
2023-10-18 5:55 ` Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 3/5] net: stmmac: intel: remove unnecessary field struct plat_stmmacenet_data::ext_snapshot_num Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 4/5] net: stmmac: ptp: stmmac_enable(): move change of plat->flags into mutex Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 5/5] net: stmmac: do not silently change auxiliary snapshot capture channel Johannes Zink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=004d6ce9-7d15-4944-b31c-c9e628e7483a@pengutronix.de \
--to=j.zink@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-jzi@pengutronix.de \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).