* [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING
@ 2019-06-11 18:47 Vladimir Oltean
2019-06-12 1:56 ` Randy Dunlap
2019-06-14 5:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Oltean @ 2019-06-11 18:47 UTC (permalink / raw)
To: f.fainelli, vivien.didelot, andrew, rdunlap, sfr, davem
Cc: netdev, linux-next, Vladimir Oltean
The packing facility is needed to decode Ethernet meta frames containing
source port and RX timestamping information.
The DSA driver selects CONFIG_PACKING, but the tagger did not, and since
taggers can be now compiled as modules independently from the drivers
themselves, this is an issue now, as CONFIG_PACKING is disabled by
default on all architectures.
Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
---
net/dsa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
index d449f78c1bd0..6e942dda1bcd 100644
--- a/net/dsa/Kconfig
+++ b/net/dsa/Kconfig
@@ -106,6 +106,7 @@ config NET_DSA_TAG_LAN9303
config NET_DSA_TAG_SJA1105
tristate "Tag driver for NXP SJA1105 switches"
select NET_DSA_TAG_8021Q
+ select PACKING
help
Say Y or M if you want to enable support for tagging frames with the
NXP SJA1105 switch family. Both the native tagging protocol (which
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING
2019-06-11 18:47 [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING Vladimir Oltean
@ 2019-06-12 1:56 ` Randy Dunlap
2019-06-14 5:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2019-06-12 1:56 UTC (permalink / raw)
To: Vladimir Oltean, f.fainelli, vivien.didelot, andrew, sfr, davem
Cc: netdev, linux-next
On 6/11/19 11:47 AM, Vladimir Oltean wrote:
> The packing facility is needed to decode Ethernet meta frames containing
> source port and RX timestamping information.
>
> The DSA driver selects CONFIG_PACKING, but the tagger did not, and since
> taggers can be now compiled as modules independently from the drivers
> themselves, this is an issue now, as CONFIG_PACKING is disabled by
> default on all architectures.
>
> Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> net/dsa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index d449f78c1bd0..6e942dda1bcd 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -106,6 +106,7 @@ config NET_DSA_TAG_LAN9303
> config NET_DSA_TAG_SJA1105
> tristate "Tag driver for NXP SJA1105 switches"
> select NET_DSA_TAG_8021Q
> + select PACKING
> help
> Say Y or M if you want to enable support for tagging frames with the
> NXP SJA1105 switch family. Both the native tagging protocol (which
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING
2019-06-11 18:47 [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING Vladimir Oltean
2019-06-12 1:56 ` Randy Dunlap
@ 2019-06-14 5:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-14 5:44 UTC (permalink / raw)
To: olteanv
Cc: f.fainelli, vivien.didelot, andrew, rdunlap, sfr, netdev,
linux-next
From: Vladimir Oltean <olteanv@gmail.com>
Date: Tue, 11 Jun 2019 21:47:45 +0300
> The packing facility is needed to decode Ethernet meta frames containing
> source port and RX timestamping information.
>
> The DSA driver selects CONFIG_PACKING, but the tagger did not, and since
> taggers can be now compiled as modules independently from the drivers
> themselves, this is an issue now, as CONFIG_PACKING is disabled by
> default on all architectures.
>
> Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-14 5:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-11 18:47 [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING Vladimir Oltean
2019-06-12 1:56 ` Randy Dunlap
2019-06-14 5:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).